[v1] drivers: base: Print error code on synthetic uevent failure

[tip: sched/psi] drivers: base: Print error code on synthetic uevent failure

tip-bot2 for Brian Norris posted 1 patch 3 years, 7 months ago

Diff against v1
Download mbox

drivers/base/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[tip: sched/psi] drivers: base: Print error code on synthetic uevent failure

Posted by tip-bot2 for Brian Norris 3 years, 7 months ago

The following commit has been merged into the sched/psi branch of tip:

Commit-ID:     6bb7ea3afd3eaae95eda6ef5589c3087f2cd70d8
Gitweb:        https://git.kernel.org/tip/6bb7ea3afd3eaae95eda6ef5589c3087f2cd70d8
Author:        Brian Norris <briannorris@chromium.org>
AuthorDate:    Wed, 24 Aug 2022 16:52:16 -07:00
Committer:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CommitterDate: Thu, 01 Sep 2022 18:15:50 +02:00

drivers: base: Print error code on synthetic uevent failure

If we're going to log the failure, we might as well log the return code
too.

Signed-off-by: Brian Norris <briannorris@chromium.org>
Link: https://lore.kernel.org/r/20220824165213.1.Ifdb98af3d0c23708a11d8d5ae5697bdb7e96a3cc@changeid
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/base/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/core.c b/drivers/base/core.c
index 753e7cc..fd04103 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -2509,7 +2509,7 @@ static ssize_t uevent_store(struct device *dev, struct device_attribute *attr,
 	rc = kobject_synth_uevent(&dev->kobj, buf, count);
 
 	if (rc) {
-		dev_err(dev, "uevent: failed to send synthetic uevent\n");
+		dev_err(dev, "uevent: failed to send synthetic uevent: %d\n", rc);
 		return rc;
 	}