fstat is replaced by statx on the new architecture, so an exception
is added to the checksyscalls script to silence the following build
warning on LoongArch:

  CALL    scripts/checksyscalls.sh
<stdin>:569:2: warning: #warning syscall fstat not implemented [-Wcpp]

Suggested-by: WANG Xuerui <kernel@xen0n.name>
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---

Hi Xuerui and Arnd,

Thank you for your reviews and suggestions.

v2:
  -- Change scripts/checksyscalls.sh
  -- Modify patch subject and commit message

 scripts/checksyscalls.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checksyscalls.sh b/scripts/checksyscalls.sh
index f33e61a..c0a093c 100755
--- a/scripts/checksyscalls.sh
+++ b/scripts/checksyscalls.sh
@@ -114,7 +114,6 @@ cat << EOF
 #define __IGNORE_truncate
 #define __IGNORE_stat
 #define __IGNORE_lstat
-#define __IGNORE_fstat
 #define __IGNORE_fcntl
 #define __IGNORE_fadvise64
 #define __IGNORE_newfstatat
@@ -253,6 +252,7 @@ cat << EOF
 #define __IGNORE_vserver
 
 /* 64-bit ports never needed these, and new 32-bit ports can use statx */
+#define __IGNORE_fstat
 #define __IGNORE_fstat64
 #define __IGNORE_fstatat64
 EOF
-- 
2.1.0

On 2022/8/30 10:50, Tiezhu Yang wrote:
> fstat is replaced by statx on the new architecture, so an exception
> is added to the checksyscalls script to silence the following build
> warning on LoongArch:
> 
>    CALL    scripts/checksyscalls.sh
> <stdin>:569:2: warning: #warning syscall fstat not implemented [-Wcpp]
> 
> Suggested-by: WANG Xuerui <kernel@xen0n.name>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> 
> Hi Xuerui and Arnd,
> 
> Thank you for your reviews and suggestions.
> 
> v2:
>    -- Change scripts/checksyscalls.sh
>    -- Modify patch subject and commit message
> 
>   scripts/checksyscalls.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checksyscalls.sh b/scripts/checksyscalls.sh
> index f33e61a..c0a093c 100755
> --- a/scripts/checksyscalls.sh
> +++ b/scripts/checksyscalls.sh
> @@ -114,7 +114,6 @@ cat << EOF
>   #define __IGNORE_truncate
>   #define __IGNORE_stat
>   #define __IGNORE_lstat
> -#define __IGNORE_fstat
>   #define __IGNORE_fcntl
>   #define __IGNORE_fadvise64
>   #define __IGNORE_newfstatat
> @@ -253,6 +252,7 @@ cat << EOF
>   #define __IGNORE_vserver
>   
>   /* 64-bit ports never needed these, and new 32-bit ports can use statx */
> +#define __IGNORE_fstat

This should not belong here, because some 64-bit ports apparently need 
fstat. Instead it should be its own block with some explanation like 
"Newer ports are not required to provide fstat in favor of statx".

>   #define __IGNORE_fstat64
>   #define __IGNORE_fstatat64
>   EOF

Otherwise LGTM, thanks!

-- 
WANG "xen0n" Xuerui

Linux/LoongArch mailing list: https://lore.kernel.org/loongarch/

Hi, Tiezhu,

On Tue, Aug 30, 2022 at 10:50 AM Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
>
> fstat is replaced by statx on the new architecture, so an exception
> is added to the checksyscalls script to silence the following build
> warning on LoongArch:
>
>   CALL    scripts/checksyscalls.sh
> <stdin>:569:2: warning: #warning syscall fstat not implemented [-Wcpp]
>
> Suggested-by: WANG Xuerui <kernel@xen0n.name>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
>
> Hi Xuerui and Arnd,
>
> Thank you for your reviews and suggestions.
>
> v2:
>   -- Change scripts/checksyscalls.sh
>   -- Modify patch subject and commit message
>
>  scripts/checksyscalls.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checksyscalls.sh b/scripts/checksyscalls.sh
> index f33e61a..c0a093c 100755
> --- a/scripts/checksyscalls.sh
> +++ b/scripts/checksyscalls.sh
> @@ -114,7 +114,6 @@ cat << EOF
>  #define __IGNORE_truncate
>  #define __IGNORE_stat
>  #define __IGNORE_lstat
> -#define __IGNORE_fstat
>  #define __IGNORE_fcntl
>  #define __IGNORE_fadvise64
>  #define __IGNORE_newfstatat
> @@ -253,6 +252,7 @@ cat << EOF
>  #define __IGNORE_vserver
>
>  /* 64-bit ports never needed these, and new 32-bit ports can use statx */
I think the comment here should be modified to reflect the new fact,
and I think all syscalls controlled by __ARCH_WANT_NEW_STAT should be
listed.

Huacai

> +#define __IGNORE_fstat
>  #define __IGNORE_fstat64
>  #define __IGNORE_fstatat64
>  EOF
> --
> 2.1.0
>
>