pm8001 driver improvements

[PATCH 0/4] pm8001 driver improvements

Posted by John Garry 3 years, 10 months ago

This small series includes the following:
- Rework how some shost values are set
- Fix a longstanding bug that the driver attempts to use tags before they
  are configured
- Stop using {set, clear}_bit()
- Expose HW queues

Any testing would be appreciated as this driver is still broken for my
arm64 system, i.e. just broken.

John Garry (4):
  scsi: pm8001: Rework shost initial values
  scsi: pm8001: Setup tags before using them
  scsi: pm8001: Use non-atomic bitmap ops for tag alloc + free
  scsi: pm8001: Expose HW queues for pm80xx hw

 drivers/scsi/pm8001/pm8001_hwi.c  |  5 +++
 drivers/scsi/pm8001/pm8001_init.c | 73 +++++++++++++++++++++----------
 drivers/scsi/pm8001/pm8001_sas.c  | 10 +++--
 drivers/scsi/pm8001/pm8001_sas.h  |  3 ++
 drivers/scsi/pm8001/pm80xx_hwi.c  | 46 +++++++++++++++----
 5 files changed, 101 insertions(+), 36 deletions(-)

-- 
2.26.2

Re: [PATCH 0/4] pm8001 driver improvements

Posted by Martin K. Petersen 3 years, 10 months ago

On Sat, 11 Jun 2022 00:46:38 +0800, John Garry wrote:

> This small series includes the following:
> - Rework how some shost values are set
> - Fix a longstanding bug that the driver attempts to use tags before they
>   are configured
> - Stop using {set, clear}_bit()
> - Expose HW queues
> 
> [...]

Applied to 5.20/scsi-queue, thanks!

[1/4] scsi: pm8001: Rework shost initial values
      https://git.kernel.org/mkp/scsi/c/35a7e9dbff9a
[2/4] scsi: pm8001: Setup tags before using them
      https://git.kernel.org/mkp/scsi/c/98132d842d4d
[3/4] scsi: pm8001: Use non-atomic bitmap ops for tag alloc + free
      https://git.kernel.org/mkp/scsi/c/940f5efa6316
[4/4] scsi: pm8001: Expose HW queues for pm80xx hw
      https://git.kernel.org/mkp/scsi/c/42f22fe36d51

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH 0/4] pm8001 driver improvements

Posted by Martin K. Petersen 3 years, 10 months ago

John,

> This small series includes the following:
> - Rework how some shost values are set
> - Fix a longstanding bug that the driver attempts to use tags before they
>   are configured
> - Stop using {set, clear}_bit()
> - Expose HW queues

Applied to 5.20/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH 0/4] pm8001 driver improvements

Posted by Damien Le Moal 3 years, 10 months ago

On 6/11/22 01:46, John Garry wrote:
> This small series includes the following:
> - Rework how some shost values are set
> - Fix a longstanding bug that the driver attempts to use tags before they
>   are configured
> - Stop using {set, clear}_bit()
> - Expose HW queues
> 
> Any testing would be appreciated as this driver is still broken for my
> arm64 system, i.e. just broken.
> 
> John Garry (4):
>   scsi: pm8001: Rework shost initial values
>   scsi: pm8001: Setup tags before using them
>   scsi: pm8001: Use non-atomic bitmap ops for tag alloc + free
>   scsi: pm8001: Expose HW queues for pm80xx hw
> 
>  drivers/scsi/pm8001/pm8001_hwi.c  |  5 +++
>  drivers/scsi/pm8001/pm8001_init.c | 73 +++++++++++++++++++++----------
>  drivers/scsi/pm8001/pm8001_sas.c  | 10 +++--
>  drivers/scsi/pm8001/pm8001_sas.h  |  3 ++
>  drivers/scsi/pm8001/pm80xx_hwi.c  | 46 +++++++++++++++----
>  5 files changed, 101 insertions(+), 36 deletions(-)
> 

Tested-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

-- 
Damien Le Moal
Western Digital Research