[PATCH net] ptp: ptp_clockmatrix: fix is_single_shot

Min Li posted 1 patch 3 years, 11 months ago
There is a newer version of this series
drivers/ptp/ptp_clockmatrix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH net] ptp: ptp_clockmatrix: fix is_single_shot
Posted by Min Li 3 years, 11 months ago
is_single_shot should return false for the power_of_2 mask

Signed-off-by: Min Li <min.li.xe@renesas.com>
---
 drivers/ptp/ptp_clockmatrix.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c
index cb258e1..c9d451b 100644
--- a/drivers/ptp/ptp_clockmatrix.c
+++ b/drivers/ptp/ptp_clockmatrix.c
@@ -267,7 +267,7 @@ static int arm_tod_read_trig_sel_refclk(struct idtcm_channel *channel, u8 ref)
 static bool is_single_shot(u8 mask)
 {
 	/* Treat single bit ToD masks as continuous trigger */
-	return mask <= 8 && is_power_of_2(mask);
+	return !(mask <= 8 && is_power_of_2(mask));
 }
 
 static int idtcm_extts_enable(struct idtcm_channel *channel,
-- 
2.7.4
Re: [PATCH net] ptp: ptp_clockmatrix: fix is_single_shot
Posted by Jakub Kicinski 3 years, 11 months ago
On Thu, 19 May 2022 15:20:59 -0400 Min Li wrote:
> Subject: [PATCH net] ptp: ptp_clockmatrix: fix is_single_shot

I put your patches in net-next, because I could not understand
whether they were a bug fix or a feature. Please resend this
with [PATCH net-next]

> is_single_shot should return false for the power_of_2 mask
> 
> Signed-off-by: Min Li <min.li.xe@renesas.com>

And since this clearly is a bug fix it'll need a Fixes: tag.