[PATCH v2 0/2] eDP/DP Phy vdda realted function

Kuogee Hsieh posted 2 patches 3 years, 11 months ago
There is a newer version of this series
drivers/gpu/drm/msm/dp/dp_parser.c  | 14 ------
drivers/gpu/drm/msm/dp/dp_parser.h  |  6 ---
drivers/gpu/drm/msm/dp/dp_power.c   | 95 +------------------------------------
drivers/phy/qualcomm/phy-qcom-edp.c | 25 ++++++++--
drivers/phy/qualcomm/phy-qcom-qmp.c | 13 +++++
5 files changed, 36 insertions(+), 117 deletions(-)
[PATCH v2 0/2] eDP/DP Phy vdda realted function
Posted by Kuogee Hsieh 3 years, 11 months ago
1) add regulator_set_load() to eDP/DP phy
2) remove vdda related function out of eDP/DP controller

Kuogee Hsieh (2):
  phy/qcom: add regulator_set_load to edp/dp phy
  drm/msm/dp: delete vdda regulator related functions from eDP/DP
    controller

 drivers/gpu/drm/msm/dp/dp_parser.c  | 14 ------
 drivers/gpu/drm/msm/dp/dp_parser.h  |  6 ---
 drivers/gpu/drm/msm/dp/dp_power.c   | 95 +------------------------------------
 drivers/phy/qualcomm/phy-qcom-edp.c | 25 ++++++++--
 drivers/phy/qualcomm/phy-qcom-qmp.c | 13 +++++
 5 files changed, 36 insertions(+), 117 deletions(-)

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
Re: [PATCH v2 0/2] eDP/DP Phy vdda realted function
Posted by Dmitry Baryshkov 3 years, 11 months ago
On Wed, 18 May 2022 at 19:43, Kuogee Hsieh <quic_khsieh@quicinc.com> wrote:
>
> 1) add regulator_set_load() to eDP/DP phy
> 2) remove vdda related function out of eDP/DP controller

These patches touch two subsystems and have a dependency between them.
How do we merge them?

>
> Kuogee Hsieh (2):
>   phy/qcom: add regulator_set_load to edp/dp phy
>   drm/msm/dp: delete vdda regulator related functions from eDP/DP
>     controller
>
>  drivers/gpu/drm/msm/dp/dp_parser.c  | 14 ------
>  drivers/gpu/drm/msm/dp/dp_parser.h  |  6 ---
>  drivers/gpu/drm/msm/dp/dp_power.c   | 95 +------------------------------------
>  drivers/phy/qualcomm/phy-qcom-edp.c | 25 ++++++++--
>  drivers/phy/qualcomm/phy-qcom-qmp.c | 13 +++++
>  5 files changed, 36 insertions(+), 117 deletions(-)
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>


-- 
With best wishes
Dmitry
Re: [PATCH v2 0/2] eDP/DP Phy vdda realted function
Posted by Kuogee Hsieh 3 years, 11 months ago
On 5/18/2022 10:16 AM, Dmitry Baryshkov wrote:
> On Wed, 18 May 2022 at 19:43, Kuogee Hsieh <quic_khsieh@quicinc.com> wrote:
>> 1) add regulator_set_load() to eDP/DP phy
>> 2) remove vdda related function out of eDP/DP controller
> These patches touch two subsystems and have a dependency between them.
> How do we merge them?

currently, both phy and controller are vote for regulator. The last vote 
will just increase count.

Therefore the dependency should be very loose.


>> Kuogee Hsieh (2):
>>    phy/qcom: add regulator_set_load to edp/dp phy
>>    drm/msm/dp: delete vdda regulator related functions from eDP/DP
>>      controller
>>
>>   drivers/gpu/drm/msm/dp/dp_parser.c  | 14 ------
>>   drivers/gpu/drm/msm/dp/dp_parser.h  |  6 ---
>>   drivers/gpu/drm/msm/dp/dp_power.c   | 95 +------------------------------------
>>   drivers/phy/qualcomm/phy-qcom-edp.c | 25 ++++++++--
>>   drivers/phy/qualcomm/phy-qcom-qmp.c | 13 +++++
>>   5 files changed, 36 insertions(+), 117 deletions(-)
>>
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>> a Linux Foundation Collaborative Project
>>
>
Re: [PATCH v2 0/2] eDP/DP Phy vdda realted function
Posted by Dmitry Baryshkov 3 years, 11 months ago
On 18/05/2022 20:29, Kuogee Hsieh wrote:
> 
> On 5/18/2022 10:16 AM, Dmitry Baryshkov wrote:
>> On Wed, 18 May 2022 at 19:43, Kuogee Hsieh <quic_khsieh@quicinc.com> 
>> wrote:
>>> 1) add regulator_set_load() to eDP/DP phy
>>> 2) remove vdda related function out of eDP/DP controller
>> These patches touch two subsystems and have a dependency between them.
>> How do we merge them?
> 
> currently, both phy and controller are vote for regulator. The last vote 
> will just increase count.
> 
> Therefore the dependency should be very loose.

So, do you propose to merge dp change a cycle after the phy changes go in?

> 
> 
>>> Kuogee Hsieh (2):
>>>    phy/qcom: add regulator_set_load to edp/dp phy
>>>    drm/msm/dp: delete vdda regulator related functions from eDP/DP
>>>      controller
>>>
>>>   drivers/gpu/drm/msm/dp/dp_parser.c  | 14 ------
>>>   drivers/gpu/drm/msm/dp/dp_parser.h  |  6 ---
>>>   drivers/gpu/drm/msm/dp/dp_power.c   | 95 
>>> +------------------------------------
>>>   drivers/phy/qualcomm/phy-qcom-edp.c | 25 ++++++++--
>>>   drivers/phy/qualcomm/phy-qcom-qmp.c | 13 +++++
>>>   5 files changed, 36 insertions(+), 117 deletions(-)
>>>
>>> -- 
>>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
>>> Forum,
>>> a Linux Foundation Collaborative Project
>>>
>>


-- 
With best wishes
Dmitry
Re: [PATCH v2 0/2] eDP/DP Phy vdda realted function
Posted by Kuogee Hsieh 3 years, 11 months ago
On 5/18/2022 10:31 AM, Dmitry Baryshkov wrote:
> On 18/05/2022 20:29, Kuogee Hsieh wrote:
>>
>> On 5/18/2022 10:16 AM, Dmitry Baryshkov wrote:
>>> On Wed, 18 May 2022 at 19:43, Kuogee Hsieh <quic_khsieh@quicinc.com> 
>>> wrote:
>>>> 1) add regulator_set_load() to eDP/DP phy
>>>> 2) remove vdda related function out of eDP/DP controller
>>> These patches touch two subsystems and have a dependency between them.
>>> How do we merge them?
>>
>> currently, both phy and controller are vote for regulator. The last 
>> vote will just increase count.
>>
>> Therefore the dependency should be very loose.
>
> So, do you propose to merge dp change a cycle after the phy changes go 
> in?
>
yes,
>>
>>
>>>> Kuogee Hsieh (2):
>>>>    phy/qcom: add regulator_set_load to edp/dp phy
>>>>    drm/msm/dp: delete vdda regulator related functions from eDP/DP
>>>>      controller
>>>>
>>>>   drivers/gpu/drm/msm/dp/dp_parser.c  | 14 ------
>>>>   drivers/gpu/drm/msm/dp/dp_parser.h  |  6 ---
>>>>   drivers/gpu/drm/msm/dp/dp_power.c   | 95 
>>>> +------------------------------------
>>>>   drivers/phy/qualcomm/phy-qcom-edp.c | 25 ++++++++--
>>>>   drivers/phy/qualcomm/phy-qcom-qmp.c | 13 +++++
>>>>   5 files changed, 36 insertions(+), 117 deletions(-)
>>>>
>>>> -- 
>>>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
>>>> Forum,
>>>> a Linux Foundation Collaborative Project
>>>>
>>>
>
>