hisi_sas: A device rescan and IT nexus reset fix

[PATCH 0/3] hisi_sas: A device rescan and IT nexus reset fix

Posted by John Garry 3 years, 12 months ago

Hi,

This series includes 2x fixes for the hisi_sas driver:
- In issuing an ATA softreset in the IT nexus handler the disk may become 
  lost as we may issue the softreset before the phy is back up.

  So export functionality from sas_ata_hard_reset() to wait for phy up to
  synchronize.

- For host rescan we issue a nexus reset to the disk which is unnecessary,
  so drop it. In addition, usage of the device status flag needs to be
  fixed.

Please consider for 5.19, thanks!

John Garry (3):
  scsi: libsas: Refactor sas_ata_hard_reset()
  scsi: hisi_sas: Use sas_ata_wait_after_reset() in IT nexus reset
  scsi: hisi_sas: Fix rescan after deleting a disk

 drivers/scsi/hisi_sas/hisi_sas_main.c | 66 ++++++++++++---------------
 drivers/scsi/libsas/sas_ata.c         | 41 +++++++++++------
 include/scsi/sas_ata.h                |  7 +++
 3 files changed, 64 insertions(+), 50 deletions(-)

-- 
2.26.2

Re: [PATCH 0/3] hisi_sas: A device rescan and IT nexus reset fix

Posted by Martin K. Petersen 3 years, 11 months ago

On Thu, 12 May 2022 19:15:31 +0800, John Garry wrote:

> This series includes 2x fixes for the hisi_sas driver:
> - In issuing an ATA softreset in the IT nexus handler the disk may become
>   lost as we may issue the softreset before the phy is back up.
> 
>   So export functionality from sas_ata_hard_reset() to wait for phy up to
>   synchronize.
> 
> [...]

Applied to 5.19/scsi-queue, thanks!

[1/3] scsi: libsas: Refactor sas_ata_hard_reset()
      https://git.kernel.org/mkp/scsi/c/057e5fc03369
[2/3] scsi: hisi_sas: Use sas_ata_wait_after_reset() in IT nexus reset
      https://git.kernel.org/mkp/scsi/c/71453bd9d1bf
[3/3] scsi: hisi_sas: Fix rescan after deleting a disk
      https://git.kernel.org/mkp/scsi/c/e9dedc13bb11

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH 0/3] hisi_sas: A device rescan and IT nexus reset fix

Posted by Martin K. Petersen 3 years, 11 months ago

John,

> This series includes 2x fixes for the hisi_sas driver:
> - In issuing an ATA softreset in the IT nexus handler the disk may become 
>   lost as we may issue the softreset before the phy is back up.
>
>   So export functionality from sas_ata_hard_reset() to wait for phy up to
>   synchronize.
>
> - For host rescan we issue a nexus reset to the disk which is unnecessary,
>   so drop it. In addition, usage of the device status flag needs to be
>   fixed.

Applied to 5.19/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering