MIPS: VR41xx: Drop redundant spinlock initialization

[PATCH] MIPS: VR41xx: Drop redundant spinlock initialization

Posted by Haowen Bai 3 years, 12 months ago

slot_errbuf_lock has declared and initialized by DEFINE_SPINLOCK,
so we don't need to spin_lock_init again, drop it.

Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
 arch/mips/vr41xx/common/cmu.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/mips/vr41xx/common/cmu.c b/arch/mips/vr41xx/common/cmu.c
index b59ee5479313..e4cbe116b26d 100644
--- a/arch/mips/vr41xx/common/cmu.c
+++ b/arch/mips/vr41xx/common/cmu.c
@@ -236,8 +236,6 @@ static int __init vr41xx_cmu_init(void)
 	if (current_cpu_type() == CPU_VR4133)
 		cmuclkmsk2 = cmu_read(CMUCLKMSK2);
 
-	spin_lock_init(&cmu_lock);
-
 	return 0;
 }
 
-- 
2.7.4

Re: [PATCH] MIPS: VR41xx: Drop redundant spinlock initialization

Posted by Thomas Bogendoerfer 3 years, 12 months ago

On Tue, May 10, 2022 at 05:55:27PM +0800, Haowen Bai wrote:
> slot_errbuf_lock has declared and initialized by DEFINE_SPINLOCK,
> so we don't need to spin_lock_init again, drop it.
> 
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
>  arch/mips/vr41xx/common/cmu.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/mips/vr41xx/common/cmu.c b/arch/mips/vr41xx/common/cmu.c
> index b59ee5479313..e4cbe116b26d 100644
> --- a/arch/mips/vr41xx/common/cmu.c
> +++ b/arch/mips/vr41xx/common/cmu.c
> @@ -236,8 +236,6 @@ static int __init vr41xx_cmu_init(void)
>  	if (current_cpu_type() == CPU_VR4133)
>  		cmuclkmsk2 = cmu_read(CMUCLKMSK2);
>  
> -	spin_lock_init(&cmu_lock);
> -
>  	return 0;
>  }
>  
> -- 
> 2.7.4

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]