arm64: dts: qcom: sc7280: Add ldo_l17b regulator node

[PATCH] arm64: dts: qcom: sc7280: Add ldo_l17b regulator node

Posted by Srinivasa Rao Mandadapu 4 years, 1 month ago

Add ldo_l17b in pm7325 regulator, which is required for
wcd codec vdd buck supply.

Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
index b833ba1..17d0c05 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
@@ -113,6 +113,11 @@
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
 		};
 
+		vreg_l17b_1p8: ldo17 {
+			regulator-min-microvolt = <1700000>;
+			regulator-max-microvolt = <1900000>;
+		};
+
 		vdd_px_wcd9385:
 		vdd_txrx:
 		vddpx_0:
-- 
2.7.4

Re: [PATCH] arm64: dts: qcom: sc7280: Add ldo_l17b regulator node

Posted by Bjorn Andersson 4 years, 1 month ago

On Thu 21 Apr 09:19 CDT 2022, Srinivasa Rao Mandadapu wrote:

> Add ldo_l17b in pm7325 regulator, which is required for
> wcd codec vdd buck supply.
> 
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
> index b833ba1..17d0c05 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
> @@ -113,6 +113,11 @@
>  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>  		};
>  
> +		vreg_l17b_1p8: ldo17 {
> +			regulator-min-microvolt = <1700000>;
> +			regulator-max-microvolt = <1900000>;

Can you confirm that this doesn't need to be in HPM mode?

Thanks,
Bjorn

> +		};
> +
>  		vdd_px_wcd9385:
>  		vdd_txrx:
>  		vddpx_0:
> -- 
> 2.7.4
>

Re: [PATCH] arm64: dts: qcom: sc7280: Add ldo_l17b regulator node

Posted by Srinivasa Rao Mandadapu 4 years, 1 month ago

On 4/23/2022 9:28 PM, Bjorn Andersson wrote:
Thanks for your time Bjorn!!
> On Thu 21 Apr 09:19 CDT 2022, Srinivasa Rao Mandadapu wrote:
>
>> Add ldo_l17b in pm7325 regulator, which is required for
>> wcd codec vdd buck supply.
>>
>> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
>> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
>> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
>> index b833ba1..17d0c05 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
>> @@ -113,6 +113,11 @@
>>   			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>>   		};
>>   
>> +		vreg_l17b_1p8: ldo17 {
>> +			regulator-min-microvolt = <1700000>;
>> +			regulator-max-microvolt = <1900000>;
> Can you confirm that this doesn't need to be in HPM mode?
HPM mode included and sent V2 patch.
>
> Thanks,
> Bjorn
>
>> +		};
>> +
>>   		vdd_px_wcd9385:
>>   		vdd_txrx:
>>   		vddpx_0:
>> -- 
>> 2.7.4
>>

Re: [PATCH] arm64: dts: qcom: sc7280: Add ldo_l17b regulator node

Posted by Doug Anderson 4 years, 1 month ago

Hi,

On Thu, Apr 21, 2022 at 7:20 AM Srinivasa Rao Mandadapu
<quic_srivasam@quicinc.com> wrote:
>
> Add ldo_l17b in pm7325 regulator, which is required for
> wcd codec vdd buck supply.
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)

The ${SUBJECT} should probably mention qcard somehow? Right now your
patch subject makes it sound like this applies to all sc7280 boards,
but this only affects those including the qcard dtsi file.


> diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
> index b833ba1..17d0c05 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
> @@ -113,6 +113,11 @@
>                         regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>                 };
>
> +               vreg_l17b_1p8: ldo17 {
> +                       regulator-min-microvolt = <1700000>;
> +                       regulator-max-microvolt = <1900000>;

All the other regulators in this file specify:

regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;

Why doesn't yours?

Re: [PATCH] arm64: dts: qcom: sc7280: Add ldo_l17b regulator node

Posted by Srinivasa Rao Mandadapu 4 years, 1 month ago

Thanks for your time Doug!!!

On 4/21/2022 9:50 PM, Doug Anderson wrote:
> Hi,
>
> On Thu, Apr 21, 2022 at 7:20 AM Srinivasa Rao Mandadapu
> <quic_srivasam@quicinc.com> wrote:
>> Add ldo_l17b in pm7325 regulator, which is required for
>> wcd codec vdd buck supply.
>>
>> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
>> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
>> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 5 +++++
>>   1 file changed, 5 insertions(+)
> The ${SUBJECT} should probably mention qcard somehow? Right now your
> patch subject makes it sound like this applies to all sc7280 boards,
> but this only affects those including the qcard dtsi file.
Okay. Will update the subject accordingly.
>
>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
>> index b833ba1..17d0c05 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
>> @@ -113,6 +113,11 @@
>>                          regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>>                  };
>>
>> +               vreg_l17b_1p8: ldo17 {
>> +                       regulator-min-microvolt = <1700000>;
>> +                       regulator-max-microvolt = <1900000>;
> All the other regulators in this file specify:
>
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>
> Why doesn't yours?
Okay. Will add initial mode.