[PATCH V2] net: mscc: ocelot: Remove useless code

Haowen Bai posted 1 patch 4 years ago
drivers/net/ethernet/mscc/ocelot_vcap.c | 4 ----
1 file changed, 4 deletions(-)
[PATCH V2] net: mscc: ocelot: Remove useless code
Posted by Haowen Bai 4 years ago
payload only memset but no use at all, so we drop them.

Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
V1->V2: change correct title

 drivers/net/ethernet/mscc/ocelot_vcap.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/ethernet/mscc/ocelot_vcap.c b/drivers/net/ethernet/mscc/ocelot_vcap.c
index c8701ac955a8..1e74bdb215ec 100644
--- a/drivers/net/ethernet/mscc/ocelot_vcap.c
+++ b/drivers/net/ethernet/mscc/ocelot_vcap.c
@@ -672,12 +672,10 @@ static void is1_entry_set(struct ocelot *ocelot, int ix,
 {
 	const struct vcap_props *vcap = &ocelot->vcap[VCAP_IS1];
 	struct ocelot_vcap_key_vlan *tag = &filter->vlan;
-	struct ocelot_vcap_u64 payload;
 	struct vcap_data data;
 	int row = ix / 2;
 	u32 type;
 
-	memset(&payload, 0, sizeof(payload));
 	memset(&data, 0, sizeof(data));
 
 	/* Read row */
@@ -813,11 +811,9 @@ static void es0_entry_set(struct ocelot *ocelot, int ix,
 {
 	const struct vcap_props *vcap = &ocelot->vcap[VCAP_ES0];
 	struct ocelot_vcap_key_vlan *tag = &filter->vlan;
-	struct ocelot_vcap_u64 payload;
 	struct vcap_data data;
 	int row = ix;
 
-	memset(&payload, 0, sizeof(payload));
 	memset(&data, 0, sizeof(data));
 
 	/* Read row */
-- 
2.7.4
Re: [PATCH V2] net: mscc: ocelot: Remove useless code
Posted by patchwork-bot+netdevbpf@kernel.org 4 years ago
Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Thu, 21 Apr 2022 18:34:41 +0800 you wrote:
> payload only memset but no use at all, so we drop them.
> 
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> V1->V2: change correct title
> 
>  drivers/net/ethernet/mscc/ocelot_vcap.c | 4 ----
>  1 file changed, 4 deletions(-)

Here is the summary with links:
  - [V2] net: mscc: ocelot: Remove useless code
    https://git.kernel.org/netdev/net-next/c/985e254c738c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html