1. Patchew
  2. linux
  3. View series

[PATCH] s390/dasd: Use kzalloc instead of kmalloc/memset

Haowen Bai posted 1 patch 4 years ago
There is a newer version of this series
drivers/s390/block/dasd_eckd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
[PATCH] s390/dasd: Use kzalloc instead of kmalloc/memset
Posted by Haowen Bai 4 years ago 
Use kzalloc rather than duplicating its implementation, which
makes code simple and easy to understand.

Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
 drivers/s390/block/dasd_eckd.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.c
index 8410a25a65c1..74a035c56c3e 100644
--- a/drivers/s390/block/dasd_eckd.c
+++ b/drivers/s390/block/dasd_eckd.c
@@ -1480,7 +1480,7 @@ static int dasd_eckd_pe_handler(struct dasd_device *device,
 {
 	struct pe_handler_work_data *data;
 
-	data = kmalloc(sizeof(*data), GFP_ATOMIC | GFP_DMA);
+	data = kzalloc(sizeof(*data), GFP_ATOMIC | GFP_DMA);
 	if (!data) {
 		if (mutex_trylock(&dasd_pe_handler_mutex)) {
 			data = pe_handler_worker;
@@ -1489,7 +1489,6 @@ static int dasd_eckd_pe_handler(struct dasd_device *device,
 			return -ENOMEM;
 		}
 	} else {
-		memset(data, 0, sizeof(*data));
 		data->isglobal = 0;
 	}
 	INIT_WORK(&data->worker, do_pe_handler_work);
-- 
2.7.4
Re: [PATCH] s390/dasd: Use kzalloc instead of kmalloc/memset
Posted by Sven Schnelle 4 years ago 
Hi,

Haowen Bai <baihaowen@meizu.com> writes:

> Use kzalloc rather than duplicating its implementation, which
> makes code simple and easy to understand.
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
>  drivers/s390/block/dasd_eckd.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.c
> index 8410a25a65c1..74a035c56c3e 100644
> --- a/drivers/s390/block/dasd_eckd.c
> +++ b/drivers/s390/block/dasd_eckd.c
> @@ -1480,7 +1480,7 @@ static int dasd_eckd_pe_handler(struct dasd_device *device,
>  {
>  	struct pe_handler_work_data *data;
>  
> -	data = kmalloc(sizeof(*data), GFP_ATOMIC | GFP_DMA);
> +	data = kzalloc(sizeof(*data), GFP_ATOMIC | GFP_DMA);
>  	if (!data) {
>  		if (mutex_trylock(&dasd_pe_handler_mutex)) {
>  			data = pe_handler_worker;
> @@ -1489,7 +1489,6 @@ static int dasd_eckd_pe_handler(struct dasd_device *device,
>  			return -ENOMEM;
>  		}
>  	} else {
> -		memset(data, 0, sizeof(*data));
>  		data->isglobal = 0;

Maybe also remove the isglobal assigment above, so the whole else block
could go away?

>  	}
>  	INIT_WORK(&data->worker, do_pe_handler_work);

Thanks,
Sven
[PATCH V2] s390/dasd: Use kzalloc instead of kmalloc/memset
Posted by Haowen Bai 4 years ago 
Use kzalloc rather than duplicating its implementation, which
makes code simple and easy to understand.

Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
V1->V2: also remove the isglobal assigment above, so the whole else block
could go away

 drivers/s390/block/dasd_eckd.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.c
index 8410a25a65c1..6b70f9dfff02 100644
--- a/drivers/s390/block/dasd_eckd.c
+++ b/drivers/s390/block/dasd_eckd.c
@@ -1480,7 +1480,7 @@ static int dasd_eckd_pe_handler(struct dasd_device *device,
 {
 	struct pe_handler_work_data *data;
 
-	data = kmalloc(sizeof(*data), GFP_ATOMIC | GFP_DMA);
+	data = kzalloc(sizeof(*data), GFP_ATOMIC | GFP_DMA);
 	if (!data) {
 		if (mutex_trylock(&dasd_pe_handler_mutex)) {
 			data = pe_handler_worker;
@@ -1488,9 +1488,6 @@ static int dasd_eckd_pe_handler(struct dasd_device *device,
 		} else {
 			return -ENOMEM;
 		}
-	} else {
-		memset(data, 0, sizeof(*data));
-		data->isglobal = 0;
 	}
 	INIT_WORK(&data->worker, do_pe_handler_work);
 	dasd_get_device(device);
-- 
2.7.4
Re: [PATCH V2] s390/dasd: Use kzalloc instead of kmalloc/memset
Posted by Stefan Haberland 4 years ago 
Am 19.04.22 um 08:05 schrieb Haowen Bai:
> Use kzalloc rather than duplicating its implementation, which
> makes code simple and easy to understand.
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> V1->V2: also remove the isglobal assigment above, so the whole else block
> could go away

thanks, applied!
Re: [PATCH V2] s390/dasd: Use kzalloc instead of kmalloc/memset
Posted by Sven Schnelle 4 years ago 
Haowen Bai <baihaowen@meizu.com> writes:

> Use kzalloc rather than duplicating its implementation, which
> makes code simple and easy to understand.
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> V1->V2: also remove the isglobal assigment above, so the whole else block
> could go away
>
>  drivers/s390/block/dasd_eckd.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.c
> index 8410a25a65c1..6b70f9dfff02 100644
> --- a/drivers/s390/block/dasd_eckd.c
> +++ b/drivers/s390/block/dasd_eckd.c
> @@ -1480,7 +1480,7 @@ static int dasd_eckd_pe_handler(struct dasd_device *device,
>  {
>  	struct pe_handler_work_data *data;
>  
> -	data = kmalloc(sizeof(*data), GFP_ATOMIC | GFP_DMA);
> +	data = kzalloc(sizeof(*data), GFP_ATOMIC | GFP_DMA);
>  	if (!data) {
>  		if (mutex_trylock(&dasd_pe_handler_mutex)) {
>  			data = pe_handler_worker;
> @@ -1488,9 +1488,6 @@ static int dasd_eckd_pe_handler(struct dasd_device *device,
>  		} else {
>  			return -ENOMEM;
>  		}
> -	} else {
> -		memset(data, 0, sizeof(*data));
> -		data->isglobal = 0;
>  	}
>  	INIT_WORK(&data->worker, do_pe_handler_work);
>  	dasd_get_device(device);

Reviewed-by: Sven Schnelle <svens@linux.ibm.com>

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.