arm64: make SCHED_CLUSTER depend on ACPI

[PATCH] arm64: make SCHED_CLUSTER depend on ACPI

Posted by Qing Wang 4 years ago

From: wangqing <11112896@bbktel.com>

cls is made up of sd through cluster_sibling, which is set by cluster_id,
cluster_id is only provided by ACPI, DT just provide package_id.

So, SCHED_CLUSTER depends on ACPI actually.

Signed-off-by: wangqing <11112896@bbktel.com>
---
 arch/arm64/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 25b33feed800..edbe035cb0e3 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -1199,6 +1199,7 @@ config SCHED_MC
 
 config SCHED_CLUSTER
 	bool "Cluster scheduler support"
+	depends on ACPI
 	help
 	  Cluster scheduler support improves the CPU scheduler's decision
 	  making when dealing with machines that have clusters of CPUs.
-- 
2.27.0.windows.1

[PATCH] arm64: make SCHED_CLUSTER depend on ACPI

Posted by 王擎 4 years ago

Hi Catalin, Will, Vincent, Dietmar:

What's your opinion on this patch, and I sent another patch 
"Add complex scheduler level for arm64" yesterday,

Can someone make some comments so things can move forward.

Thanks,
Qing

>cls is made up of sd through cluster_sibling, which is set by cluster_id,
>cluster_id is only provided by ACPI, DT just provide package_id.
>
>So, SCHED_CLUSTER depends on ACPI actually.
>
>Signed-off-by: wangqing <11112896@bbktel.com>
>---
> arch/arm64/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>index 25b33feed800..edbe035cb0e3 100644
>--- a/arch/arm64/Kconfig
>+++ b/arch/arm64/Kconfig
>@@ -1199,6 +1199,7 @@ config SCHED_MC
> 
> config SCHED_CLUSTER
>         bool "Cluster scheduler support"
>+       depends on ACPI
>         help
>           Cluster scheduler support improves the CPU scheduler's decision
>           making when dealing with machines that have clusters of CPUs.
>-- 
>2.7.4

Re: [PATCH] arm64: make SCHED_CLUSTER depend on ACPI

Posted by Will Deacon 4 years ago

On Fri, Apr 22, 2022 at 01:58:00AM +0000, 王擎 wrote:
> What's your opinion on this patch, and I sent another patch 
> "Add complex scheduler level for arm64" yesterday,
> 
> Can someone make some comments so things can move forward.
>
> >cls is made up of sd through cluster_sibling, which is set by cluster_id,
> >cluster_id is only provided by ACPI, DT just provide package_id.

I don't understand the commit message at all, I'm afraid.

Will