dt-bindings: interrrupt-controller: uniphier-aidet: Use unevaluatedProperties

[PATCH] dt-bindings: interrrupt-controller: uniphier-aidet: Use unevaluatedProperties

Posted by Kunihiko Hayashi 4 years, 2 months ago

This refers common bindings, so this is preferred for
unevaluatedProperties instead of additionalProperties.

Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
 .../bindings/interrupt-controller/socionext,uniphier-aidet.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/interrupt-controller/socionext,uniphier-aidet.yaml b/Documentation/devicetree/bindings/interrupt-controller/socionext,uniphier-aidet.yaml
index f89ebde76dab..77f2d58a9c3f 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/socionext,uniphier-aidet.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/socionext,uniphier-aidet.yaml
@@ -49,7 +49,7 @@ required:
   - interrupt-controller
   - '#interrupt-cells'
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |
-- 
2.25.1

Re: [PATCH] dt-bindings: interrrupt-controller: uniphier-aidet: Use unevaluatedProperties

Posted by Rob Herring 4 years, 2 months ago

On Thu, Apr 07, 2022 at 04:47:44PM +0900, Kunihiko Hayashi wrote:
> This refers common bindings, so this is preferred for
> unevaluatedProperties instead of additionalProperties.
> 
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
>  .../bindings/interrupt-controller/socionext,uniphier-aidet.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/socionext,uniphier-aidet.yaml b/Documentation/devicetree/bindings/interrupt-controller/socionext,uniphier-aidet.yaml
> index f89ebde76dab..77f2d58a9c3f 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/socionext,uniphier-aidet.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/socionext,uniphier-aidet.yaml
> @@ -49,7 +49,7 @@ required:
>    - interrupt-controller
>    - '#interrupt-cells'
>  
> -additionalProperties: false
> +unevaluatedProperties: false

As mentioned elsewhere, not necessary here.

Rob

Re: [PATCH] dt-bindings: interrrupt-controller: uniphier-aidet: Use unevaluatedProperties

Posted by Kunihiko Hayashi 4 years, 2 months ago

Hi Rob,

On 2022/04/14 4:09, Rob Herring wrote:
> On Thu, Apr 07, 2022 at 04:47:44PM +0900, Kunihiko Hayashi wrote:
>> This refers common bindings, so this is preferred for
>> unevaluatedProperties instead of additionalProperties.
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> ---
>>   .../bindings/interrupt-controller/socionext,uniphier-aidet.yaml | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git
> a/Documentation/devicetree/bindings/interrupt-controller/socionext,uniphie
> r-aidet.yaml
> b/Documentation/devicetree/bindings/interrupt-controller/socionext,uniphie
> r-aidet.yaml
>> index f89ebde76dab..77f2d58a9c3f 100644
>> ---
> a/Documentation/devicetree/bindings/interrupt-controller/socionext,uniphie
> r-aidet.yaml
>> +++
> b/Documentation/devicetree/bindings/interrupt-controller/socionext,uniphie
> r-aidet.yaml
>> @@ -49,7 +49,7 @@ required:
>>     - interrupt-controller
>>     - '#interrupt-cells'
>>   
>> -additionalProperties: false
>> +unevaluatedProperties: false
> 
> As mentioned elsewhere, not necessary here.

Yes, I withdraw this patch for the same reason.

Thank you,

---
Best Regards
Kunihiko Hayashi