[PATCH RESEND] net: usb: remove duplicate assignment

Qing Wang posted 1 patch 4 years, 2 months ago
drivers/net/usb/qmi_wwan.c | 1 -
1 file changed, 1 deletion(-)
[PATCH RESEND] net: usb: remove duplicate assignment
Posted by Qing Wang 4 years, 2 months ago
From: Wang Qing <wangqing@vivo.com>

netdev_alloc_skb() has assigned ssi->netdev to skb->dev if successed,
no need to repeat assignment.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/net/usb/qmi_wwan.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 3353e76..17cf0d1
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -190,7 +190,6 @@ static int qmimux_rx_fixup(struct usbnet *dev, struct sk_buff *skb)
 		skbn = netdev_alloc_skb(net, pkt_len + LL_MAX_HEADER);
 		if (!skbn)
 			return 0;
-		skbn->dev = net;
 
 		switch (skb->data[offset + qmimux_hdr_sz] & 0xf0) {
 		case 0x40:
-- 
2.7.4
Re: [PATCH RESEND] net: usb: remove duplicate assignment
Posted by patchwork-bot+netdevbpf@kernel.org 4 years, 2 months ago
Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Wed,  6 Apr 2022 02:17:03 -0700 you wrote:
> From: Wang Qing <wangqing@vivo.com>
> 
> netdev_alloc_skb() has assigned ssi->netdev to skb->dev if successed,
> no need to repeat assignment.
> 
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> 
> [...]

Here is the summary with links:
  - [RESEND] net: usb: remove duplicate assignment
    https://git.kernel.org/netdev/net-next/c/207d924dcf32

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html