[PATCH] dt-bindings: serial: uniphier: Add "resets" property as optional

Kunihiko Hayashi posted 1 patch 4 years, 2 months ago
.../devicetree/bindings/serial/socionext,uniphier-uart.yaml    | 3 +++
1 file changed, 3 insertions(+)
[PATCH] dt-bindings: serial: uniphier: Add "resets" property as optional
Posted by Kunihiko Hayashi 4 years, 2 months ago
UniPhier UART controller has a reset lines from system controller.
Add "resets" property to fix the following warning.

  uniphier-ld11-global.dtb: serial@54006800: 'resets' does not match any of the regexes: 'pinctrl-[0-9]+'
      From schema: Documentation/devicetree/bindings/serial/socionext,uniphier-uart.yaml

Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
 .../devicetree/bindings/serial/socionext,uniphier-uart.yaml    | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/serial/socionext,uniphier-uart.yaml b/Documentation/devicetree/bindings/serial/socionext,uniphier-uart.yaml
index d490c7c4b967..d14d8c9cfe4d 100644
--- a/Documentation/devicetree/bindings/serial/socionext,uniphier-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/socionext,uniphier-uart.yaml
@@ -22,6 +22,9 @@ properties:
   clocks:
     minItems: 1
 
+  resets:
+    minItems: 1
+
   auto-flow-control:
     description: enable automatic flow control support.
     $ref: /schemas/types.yaml#/definitions/flag
-- 
2.25.1
Re: [PATCH] dt-bindings: serial: uniphier: Add "resets" property as optional
Posted by Krzysztof Kozlowski 4 years, 2 months ago
On 28/03/2022 03:26, Kunihiko Hayashi wrote:
> UniPhier UART controller has a reset lines from system controller.
> Add "resets" property to fix the following warning.
> 
>   uniphier-ld11-global.dtb: serial@54006800: 'resets' does not match any of the regexes: 'pinctrl-[0-9]+'
>       From schema: Documentation/devicetree/bindings/serial/socionext,uniphier-uart.yaml
> 
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
>  .../devicetree/bindings/serial/socionext,uniphier-uart.yaml    | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/serial/socionext,uniphier-uart.yaml b/Documentation/devicetree/bindings/serial/socionext,uniphier-uart.yaml
> index d490c7c4b967..d14d8c9cfe4d 100644
> --- a/Documentation/devicetree/bindings/serial/socionext,uniphier-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/socionext,uniphier-uart.yaml
> @@ -22,6 +22,9 @@ properties:
>    clocks:
>      minItems: 1

This should be fixed to maxItems as well (separate patch).

>  
> +  resets:
> +    minItems: 1

maxItems

> +
>    auto-flow-control:
>      description: enable automatic flow control support.
>      $ref: /schemas/types.yaml#/definitions/flag


Best regards,
Krzysztof
Re: [PATCH] dt-bindings: serial: uniphier: Add "resets" property as optional
Posted by Kunihiko Hayashi 4 years, 2 months ago
Hi Krzysztof,

On 2022/03/29 4:05, Krzysztof Kozlowski wrote:
> On 28/03/2022 03:26, Kunihiko Hayashi wrote:
>> UniPhier UART controller has a reset lines from system controller.
>> Add "resets" property to fix the following warning.
>>
>>    uniphier-ld11-global.dtb: serial@54006800: 'resets' does not match any
>> of the regexes: 'pinctrl-[0-9]+'
>>        From schema:
>> Documentation/devicetree/bindings/serial/socionext,uniphier-uart.yaml
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> ---
>>   .../devicetree/bindings/serial/socionext,uniphier-uart.yaml    | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/serial/socionext,uniphier-uart.yaml
>> b/Documentation/devicetree/bindings/serial/socionext,uniphier-uart.yaml
>> index d490c7c4b967..d14d8c9cfe4d 100644
>> ---
>> a/Documentation/devicetree/bindings/serial/socionext,uniphier-uart.yaml
>> +++
>> b/Documentation/devicetree/bindings/serial/socionext,uniphier-uart.yaml
>> @@ -22,6 +22,9 @@ properties:
>>     clocks:
>>       minItems: 1
> 
> This should be fixed to maxItems as well (separate patch).

I see. In the case of one item, "maxItems" should be used.
I'll fix it in another patch.

>>
>> +  resets:
>> +    minItems: 1
> 
> maxItems

I'll fix it in this patch.

Thank you,

---
Best Regards
Kunihiko Hayashi