[v2] char: mwave: Fix assigning negative error code to unsigned variable

[PATCH V2] char: mwave: Fix assigning negative error code to unsigned variable

Haowen Bai posted 1 patch 4 years, 2 months ago

Diff against v1
Download mbox

drivers/char/mwave/smapi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH V2] char: mwave: Fix assigning negative error code to unsigned variable

Posted by Haowen Bai 4 years, 2 months ago

Fix the issue by changing the type of usSmapiOK to short, since the
negative error value is assigned to unsigned variables would be ignored.

Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
V1->V2: fix build error
 drivers/char/mwave/smapi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/char/mwave/smapi.c b/drivers/char/mwave/smapi.c
index f8d79d3..741a84d 100644
--- a/drivers/char/mwave/smapi.c
+++ b/drivers/char/mwave/smapi.c
@@ -66,10 +66,11 @@ static int smapi_request(unsigned short inBX, unsigned short inCX,
 	unsigned short myoutDX = 5, *pmyoutDX = &myoutDX;
 	unsigned short myoutDI = 6, *pmyoutDI = &myoutDI;
 	unsigned short myoutSI = 7, *pmyoutSI = &myoutSI;
-	unsigned short usSmapiOK = -EIO, *pusSmapiOK = &usSmapiOK;
 	unsigned int inBXCX = (inBX << 16) | inCX;
 	unsigned int inDISI = (inDI << 16) | inSI;
 	int retval = 0;
+	short usSmapiOK = -EIO;
+	unsigned short *pusSmapiOK = &usSmapiOK;
 
 	PRINTK_5(TRACE_SMAPI, "inBX %x inCX %x inDI %x inSI %x\n",
 		inBX, inCX, inDI, inSI);
-- 
2.7.4