[PATCH] fs: ext2: Fix duplicate included linux/dax.h

Haowen Bai posted 1 patch 4 years, 3 months ago
fs/ext2/inode.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] fs: ext2: Fix duplicate included linux/dax.h
Posted by Haowen Bai 4 years, 3 months ago
Clean up the following includecheck warning:

fs/ext2/inode.c: linux/dax.h is included more than once.

No functional change.

Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
 fs/ext2/inode.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
index 602578b..da4c301 100644
--- a/fs/ext2/inode.c
+++ b/fs/ext2/inode.c
@@ -36,7 +36,6 @@
 #include <linux/iomap.h>
 #include <linux/namei.h>
 #include <linux/uio.h>
-#include <linux/dax.h>
 #include "ext2.h"
 #include "acl.h"
 #include "xattr.h"
-- 
2.7.4
Re: [PATCH] fs: ext2: Fix duplicate included linux/dax.h
Posted by Ritesh Harjani 4 years, 3 months ago
On 22/03/23 12:02PM, Haowen Bai wrote:
> Clean up the following includecheck warning:
>
> fs/ext2/inode.c: linux/dax.h is included more than once.
>


Checked "make includecheck"
This is the only warning coming from fs/ext2/

Thanks for the cleanup. Looks good to me.
Feel free to add -

Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>



> No functional change.
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
>  fs/ext2/inode.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
> index 602578b..da4c301 100644
> --- a/fs/ext2/inode.c
> +++ b/fs/ext2/inode.c
> @@ -36,7 +36,6 @@
>  #include <linux/iomap.h>
>  #include <linux/namei.h>
>  #include <linux/uio.h>
> -#include <linux/dax.h>
>  #include "ext2.h"
>  #include "acl.h"
>  #include "xattr.h"
> --
> 2.7.4
>
Re: [PATCH] fs: ext2: Fix duplicate included linux/dax.h
Posted by Jan Kara 4 years, 2 months ago
On Wed 23-03-22 17:03:51, Ritesh Harjani wrote:
> On 22/03/23 12:02PM, Haowen Bai wrote:
> > Clean up the following includecheck warning:
> >
> > fs/ext2/inode.c: linux/dax.h is included more than once.
> >
> 
> 
> Checked "make includecheck"
> This is the only warning coming from fs/ext2/
> 
> Thanks for the cleanup. Looks good to me.
> Feel free to add -
> 
> Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>
> 

Thanks. I've added the patch to my tree.

								Honza

-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR