crypto: qat: Fix unsigned comparison with less than zero

[PATCH] crypto: qat: Fix unsigned comparison with less than zero

Posted by Haowen Bai 4 years, 3 months ago

drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c:67:5-8: WARNING: Unsigned expression compared with zero: ret < 0

Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
 drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c b/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c
index 6d10edc..0143835 100644
--- a/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c
+++ b/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c
@@ -52,7 +52,7 @@ static const char *const dev_cfg_services[] = {
 static int get_service_enabled(struct adf_accel_dev *accel_dev)
 {
 	char services[ADF_CFG_MAX_VAL_LEN_IN_BYTES] = {0};
-	u32 ret;
+	s32 ret;
 
 	ret = adf_cfg_get_param_value(accel_dev, ADF_GENERAL_SEC,
 				      ADF_SERVICES_ENABLED, services);
-- 
2.7.4

Re: [PATCH] crypto: qat: Fix unsigned comparison with less than zero

Posted by Giovanni Cabiddu 4 years, 3 months ago

On Fri, Mar 18, 2022 at 10:10:59AM +0800, Haowen Bai wrote:
> drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c:67:5-8: WARNING: Unsigned expression compared with zero: ret < 0
> 
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
>  drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c b/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c
> index 6d10edc..0143835 100644
> --- a/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c
> +++ b/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c
> @@ -52,7 +52,7 @@ static const char *const dev_cfg_services[] = {
>  static int get_service_enabled(struct adf_accel_dev *accel_dev)
>  {
>  	char services[ADF_CFG_MAX_VAL_LEN_IN_BYTES] = {0};
> -	u32 ret;
> +	s32 ret;
>  
>  	ret = adf_cfg_get_param_value(accel_dev, ADF_GENERAL_SEC,
>  				      ADF_SERVICES_ENABLED, services);
A fix for this is already in the cryptodev tree:
    844318dfd31f ("crypto: qat - fix a signedness bug in get_service_enabled()")

Thanks,

-- 
Giovanni