scsi: fnic: remove redundant NULL check

[PATCH] scsi: fnic: remove redundant NULL check

Posted by Haowen Bai 4 years, 3 months ago

Fix below warnings reported by coccicheck:
drivers/scsi/fnic/fnic_debugfs.c:90:2-7: WARNING: NULL check before some freeing functions is not needed.

Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
 drivers/scsi/fnic/fnic_debugfs.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/fnic/fnic_debugfs.c b/drivers/scsi/fnic/fnic_debugfs.c
index e732650..866b4c9 100644
--- a/drivers/scsi/fnic/fnic_debugfs.c
+++ b/drivers/scsi/fnic/fnic_debugfs.c
@@ -86,8 +86,7 @@ void fnic_debugfs_terminate(void)
 	debugfs_remove(fnic_trace_debugfs_root);
 	fnic_trace_debugfs_root = NULL;
 
-	if (fc_trc_flag)
-		vfree(fc_trc_flag);
+	vfree(fc_trc_flag);
 }
 
 /*
-- 
2.7.4

Re: [PATCH] scsi: fnic: remove redundant NULL check

Posted by Martin K. Petersen 4 years, 1 month ago

On Tue, 15 Mar 2022 09:53:39 +0800, Haowen Bai wrote:

> Fix below warnings reported by coccicheck:
> drivers/scsi/fnic/fnic_debugfs.c:90:2-7: WARNING: NULL check before some freeing functions is not needed.
> 
> 

Applied to 5.19/scsi-queue, thanks!

[1/1] scsi: fnic: remove redundant NULL check
      https://git.kernel.org/mkp/scsi/c/1dcd96c4d0b7

-- 
Martin K. Petersen	Oracle Linux Engineering