[PATCH v2 0/4] scsi: libsas and users: Factor out internal abort code

John Garry posted 4 patches 4 years, 3 months ago
drivers/scsi/hisi_sas/hisi_sas.h       |   8 +-
drivers/scsi/hisi_sas/hisi_sas_main.c  | 453 +++++++++----------------
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c |  11 +-
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c |  18 +-
drivers/scsi/libsas/sas_scsi_host.c    |  89 +++++
drivers/scsi/pm8001/pm8001_hwi.c       |  27 +-
drivers/scsi/pm8001/pm8001_hwi.h       |   5 -
drivers/scsi/pm8001/pm8001_sas.c       | 178 +++-------
drivers/scsi/pm8001/pm8001_sas.h       |   6 +-
drivers/scsi/pm8001/pm80xx_hwi.h       |   5 -
include/scsi/libsas.h                  |  24 ++
include/scsi/sas.h                     |   2 +
12 files changed, 360 insertions(+), 466 deletions(-)
[PATCH v2 0/4] scsi: libsas and users: Factor out internal abort code
Posted by John Garry 4 years, 3 months ago
This is a follow-on from the series to factor out the TMF code shared
between libsas LLDDs.

The hisi_sas and pm8001 have an internal abort feature to abort pending
commands in the host controller, prior to being sent to the target. The
driver support implementation is naturally quite similar, so factor it
out.

Again, testing and review would be appreciated.

This is based on mkp-scsi 5.18 staging queue @ commit 2bd3b6b75946

Changes since v1:
- fixup small coding issues (Damien)
- Add Tested-by tags (thanks!)

John Garry (4):
  scsi: libsas: Add sas_execute_internal_abort_single()
  scsi: libsas: Add sas_execute_internal_abort_dev()
  scsi: pm8001: Use libsas internal abort support
  scsi: hisi_sas: Use libsas internal abort support

 drivers/scsi/hisi_sas/hisi_sas.h       |   8 +-
 drivers/scsi/hisi_sas/hisi_sas_main.c  | 453 +++++++++----------------
 drivers/scsi/hisi_sas/hisi_sas_v2_hw.c |  11 +-
 drivers/scsi/hisi_sas/hisi_sas_v3_hw.c |  18 +-
 drivers/scsi/libsas/sas_scsi_host.c    |  89 +++++
 drivers/scsi/pm8001/pm8001_hwi.c       |  27 +-
 drivers/scsi/pm8001/pm8001_hwi.h       |   5 -
 drivers/scsi/pm8001/pm8001_sas.c       | 178 +++-------
 drivers/scsi/pm8001/pm8001_sas.h       |   6 +-
 drivers/scsi/pm8001/pm80xx_hwi.h       |   5 -
 include/scsi/libsas.h                  |  24 ++
 include/scsi/sas.h                     |   2 +
 12 files changed, 360 insertions(+), 466 deletions(-)

-- 
2.26.2
Re: [PATCH v2 0/4] scsi: libsas and users: Factor out internal abort code
Posted by Martin K. Petersen 4 years, 3 months ago
On Fri, 11 Mar 2022 20:23:48 +0800, John Garry wrote:

> This is a follow-on from the series to factor out the TMF code shared
> between libsas LLDDs.
> 
> The hisi_sas and pm8001 have an internal abort feature to abort pending
> commands in the host controller, prior to being sent to the target. The
> driver support implementation is naturally quite similar, so factor it
> out.
> 
> [...]

Applied to 5.18/scsi-queue, thanks!

[1/4] scsi: libsas: Add sas_execute_internal_abort_single()
      https://git.kernel.org/mkp/scsi/c/5c9bf3635b66
[2/4] scsi: libsas: Add sas_execute_internal_abort_dev()
      https://git.kernel.org/mkp/scsi/c/6a91c3e31578
[3/4] scsi: pm8001: Use libsas internal abort support
      https://git.kernel.org/mkp/scsi/c/2cbbf489778e
[4/4] scsi: hisi_sas: Use libsas internal abort support
      https://git.kernel.org/mkp/scsi/c/095478a6e5bf

-- 
Martin K. Petersen	Oracle Linux Engineering
Re: [PATCH v2 0/4] scsi: libsas and users: Factor out internal abort code
Posted by Jinpu Wang 4 years, 3 months ago
On Fri, Mar 11, 2022 at 1:29 PM John Garry <john.garry@huawei.com> wrote:
>
> This is a follow-on from the series to factor out the TMF code shared
> between libsas LLDDs.
>
> The hisi_sas and pm8001 have an internal abort feature to abort pending
> commands in the host controller, prior to being sent to the target. The
> driver support implementation is naturally quite similar, so factor it
> out.
>
> Again, testing and review would be appreciated.
>
> This is based on mkp-scsi 5.18 staging queue @ commit 2bd3b6b75946
>
> Changes since v1:
> - fixup small coding issues (Damien)
> - Add Tested-by tags (thanks!)
>
> John Garry (4):
>   scsi: libsas: Add sas_execute_internal_abort_single()
>   scsi: libsas: Add sas_execute_internal_abort_dev()
>   scsi: pm8001: Use libsas internal abort support
>   scsi: hisi_sas: Use libsas internal abort support
Looks good to me!
Acked-by: Jack Wang <jinpu.wang@ionos.com>

Thanks John for doing it!
>
>  drivers/scsi/hisi_sas/hisi_sas.h       |   8 +-
>  drivers/scsi/hisi_sas/hisi_sas_main.c  | 453 +++++++++----------------
>  drivers/scsi/hisi_sas/hisi_sas_v2_hw.c |  11 +-
>  drivers/scsi/hisi_sas/hisi_sas_v3_hw.c |  18 +-
>  drivers/scsi/libsas/sas_scsi_host.c    |  89 +++++
>  drivers/scsi/pm8001/pm8001_hwi.c       |  27 +-
>  drivers/scsi/pm8001/pm8001_hwi.h       |   5 -
>  drivers/scsi/pm8001/pm8001_sas.c       | 178 +++-------
>  drivers/scsi/pm8001/pm8001_sas.h       |   6 +-
>  drivers/scsi/pm8001/pm80xx_hwi.h       |   5 -
>  include/scsi/libsas.h                  |  24 ++
>  include/scsi/sas.h                     |   2 +
>  12 files changed, 360 insertions(+), 466 deletions(-)
>
> --
> 2.26.2
>
Re: [PATCH v2 0/4] scsi: libsas and users: Factor out internal abort code
Posted by Martin K. Petersen 4 years, 3 months ago
John,

> This is a follow-on from the series to factor out the TMF code shared
> between libsas LLDDs.
>
> The hisi_sas and pm8001 have an internal abort feature to abort
> pending commands in the host controller, prior to being sent to the
> target. The driver support implementation is naturally quite similar,
> so factor it out.

Applied to 5.18/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering