video: fbdev: fix warning comparing pointer to 0

[PATCH] video: fbdev: fix warning comparing pointer to 0

Posted by Haowen Bai 4 years, 3 months ago

Fix the following coccicheck warning:
drivers/video/fbdev/offb.c:415:13-14: WARNING comparing pointer to 0

Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
 drivers/video/fbdev/offb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c
index 4501e84..afdb6aa 100644
--- a/drivers/video/fbdev/offb.c
+++ b/drivers/video/fbdev/offb.c
@@ -412,7 +412,7 @@ static void __init offb_init_fb(const char *name,
 
 	info = framebuffer_alloc(sizeof(u32) * 16, NULL);
 
-	if (info == 0) {
+	if (!info) {
 		release_mem_region(res_start, res_size);
 		return;
 	}
-- 
2.7.4

Re: [PATCH] video: fbdev: fix warning comparing pointer to 0

Posted by Helge Deller 4 years, 3 months ago

On 3/11/22 03:56, Haowen Bai wrote:
> Fix the following coccicheck warning:
> drivers/video/fbdev/offb.c:415:13-14: WARNING comparing pointer to 0
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>

applied.

Thanks!
Helge

> ---
>  drivers/video/fbdev/offb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c
> index 4501e84..afdb6aa 100644
> --- a/drivers/video/fbdev/offb.c
> +++ b/drivers/video/fbdev/offb.c
> @@ -412,7 +412,7 @@ static void __init offb_init_fb(const char *name,
>
>  	info = framebuffer_alloc(sizeof(u32) * 16, NULL);
>
> -	if (info == 0) {
> +	if (!info) {
>  		release_mem_region(res_start, res_size);
>  		return;
>  	}