sched/core: remove unneeded semicolon

[PATCH] sched/core: remove unneeded semicolon

Posted by Haowen Bai 4 years, 3 months ago

Eliminate the following coccicheck warning:
kernel/sched/core_sched.c:210:2-3: Unneeded semicolon

Signed-off-by: Haowen Bai <baihaowen88@gmail.com>
---
 kernel/sched/core_sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/core_sched.c b/kernel/sched/core_sched.c
index c8746a9..085f188 100644
--- a/kernel/sched/core_sched.c
+++ b/kernel/sched/core_sched.c
@@ -207,7 +207,7 @@ int sched_core_share_pid(unsigned int cmd, pid_t pid, enum pid_type type,
 	default:
 		err = -EINVAL;
 		goto out;
-	};
+	}
 
 	if (type == PIDTYPE_PID) {
 		__sched_core_set(task, cookie);
-- 
2.7.4

Re: [PATCH] sched/core: remove unneeded semicolon

Posted by Josh Don 4 years, 3 months ago

On Mon, Feb 28, 2022 at 7:37 PM Haowen Bai <baihaowen88@gmail.com> wrote:
>
> Eliminate the following coccicheck warning:
> kernel/sched/core_sched.c:210:2-3: Unneeded semicolon
>
> Signed-off-by: Haowen Bai <baihaowen88@gmail.com>

Thanks,

Reviewed-by: Josh Don <joshdon@google.com>

> ---
>  kernel/sched/core_sched.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/core_sched.c b/kernel/sched/core_sched.c
> index c8746a9..085f188 100644
> --- a/kernel/sched/core_sched.c
> +++ b/kernel/sched/core_sched.c
> @@ -207,7 +207,7 @@ int sched_core_share_pid(unsigned int cmd, pid_t pid, enum pid_type type,
>         default:
>                 err = -EINVAL;
>                 goto out;
> -       };
> +       }
>
>         if (type == PIDTYPE_PID) {
>                 __sched_core_set(task, cookie);
> --
> 2.7.4
>