[PATCH] net: wireless: cw1200: use time_is_after_jiffies() instead of open coding it

Qing Wang posted 1 patch 4 years, 3 months ago
drivers/net/wireless/st/cw1200/queue.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[PATCH] net: wireless: cw1200: use time_is_after_jiffies() instead of open coding it
Posted by Qing Wang 4 years, 3 months ago
From: Wang Qing <wangqing@vivo.com>

Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/net/wireless/st/cw1200/queue.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/st/cw1200/queue.c b/drivers/net/wireless/st/cw1200/queue.c
index 12952b1..e06da4b
--- a/drivers/net/wireless/st/cw1200/queue.c
+++ b/drivers/net/wireless/st/cw1200/queue.c
@@ -8,6 +8,7 @@
 
 #include <net/mac80211.h>
 #include <linux/sched.h>
+#include <linux/jiffies.h>
 #include "queue.h"
 #include "cw1200.h"
 #include "debug.h"
@@ -94,7 +95,7 @@ static void __cw1200_queue_gc(struct cw1200_queue *queue,
 	bool wakeup_stats = false;
 
 	list_for_each_entry_safe(item, tmp, &queue->queue, head) {
-		if (jiffies - item->queue_timestamp < queue->ttl)
+		if (time_is_after_jiffies(item->queue_timestamp + queue->ttl))
 			break;
 		--queue->num_queued;
 		--queue->link_map_cache[item->txpriv.link_id];
-- 
2.7.4
Re: cw1200: use time_is_after_jiffies() instead of open coding it
Posted by Kalle Valo 4 years, 3 months ago
Qing Wang <wangqing@vivo.com> wrote:

> From: Wang Qing <wangqing@vivo.com>
> 
> Use the helper function time_is_{before,after}_jiffies() to improve
> code readability.
> 
> Signed-off-by: Wang Qing <wangqing@vivo.com>

Patch applied to wireless-next.git, thanks.

8cbc3d51b4ae cw1200: use time_is_after_jiffies() instead of open coding it

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/1646018060-61275-1-git-send-email-wangqing@vivo.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches