[PATCH v2 0/2] x86/boot: Fix setup_indirect support

Ross Philipson posted 2 patches 4 years, 3 months ago
arch/x86/kernel/e820.c     | 41 +++++++++++++++++-------
arch/x86/kernel/kdebugfs.c | 37 ++++++++++++++++------
arch/x86/kernel/ksysfs.c   | 77 ++++++++++++++++++++++++++++++++++++----------
arch/x86/kernel/setup.c    | 34 +++++++++++++++-----
arch/x86/mm/ioremap.c      | 57 ++++++++++++++++++++++++++++++----
5 files changed, 197 insertions(+), 49 deletions(-)
[PATCH v2 0/2] x86/boot: Fix setup_indirect support
Posted by Ross Philipson 4 years, 3 months ago
The setup_indirect support for x86 setup_data was added in November
of 2019. Several issues were found in the implementation and these
two patches were created to address those issues.

These patches were originally posted as part of the larger TrenchBoot
patch set but are now being posted separately since they can be merged
independently of the TrenchBoot work.

Changes in v2:
 - Add checks and failure modes for when early_memremap and memremap
   fail.
 - Fix variable declarations to use reverse fir tree format.
 - Use local indirect variable and remove all the inline casts.
 - Misc. fixes to the commit messages.

Ross Philipson (2):
  x86/boot: Fix memremap of setup_indirect structures
  x86/boot: Add setup_indirect support in early_memremap_is_setup_data

 arch/x86/kernel/e820.c     | 41 +++++++++++++++++-------
 arch/x86/kernel/kdebugfs.c | 37 ++++++++++++++++------
 arch/x86/kernel/ksysfs.c   | 77 ++++++++++++++++++++++++++++++++++++----------
 arch/x86/kernel/setup.c    | 34 +++++++++++++++-----
 arch/x86/mm/ioremap.c      | 57 ++++++++++++++++++++++++++++++----
 5 files changed, 197 insertions(+), 49 deletions(-)

-- 
1.8.3.1

Re: [PATCH v2 0/2] x86/boot: Fix setup_indirect support
Posted by Daniel Kiper 4 years, 3 months ago
On Wed, Feb 23, 2022 at 09:07:34PM -0500, Ross Philipson wrote:
> The setup_indirect support for x86 setup_data was added in November
> of 2019. Several issues were found in the implementation and these
> two patches were created to address those issues.
>
> These patches were originally posted as part of the larger TrenchBoot
> patch set but are now being posted separately since they can be merged
> independently of the TrenchBoot work.
>
> Changes in v2:
>  - Add checks and failure modes for when early_memremap and memremap
>    fail.
>  - Fix variable declarations to use reverse fir tree format.
>  - Use local indirect variable and remove all the inline casts.
>  - Misc. fixes to the commit messages.
>
> Ross Philipson (2):
>   x86/boot: Fix memremap of setup_indirect structures
>   x86/boot: Add setup_indirect support in early_memremap_is_setup_data

For both Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>...

Daniel
Re: [PATCH v2 0/2] x86/boot: Fix setup_indirect support
Posted by Ross Philipson 4 years, 3 months ago
On 2/25/22 16:17, Daniel Kiper wrote:
> On Wed, Feb 23, 2022 at 09:07:34PM -0500, Ross Philipson wrote:
>> The setup_indirect support for x86 setup_data was added in November
>> of 2019. Several issues were found in the implementation and these
>> two patches were created to address those issues.
>>
>> These patches were originally posted as part of the larger TrenchBoot
>> patch set but are now being posted separately since they can be merged
>> independently of the TrenchBoot work.
>>
>> Changes in v2:
>>  - Add checks and failure modes for when early_memremap and memremap
>>    fail.
>>  - Fix variable declarations to use reverse fir tree format.
>>  - Use local indirect variable and remove all the inline casts.
>>  - Misc. fixes to the commit messages.
>>
>> Ross Philipson (2):
>>   x86/boot: Fix memremap of setup_indirect structures
>>   x86/boot: Add setup_indirect support in early_memremap_is_setup_data
> 
> For both Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>...
> 
> Daniel

Borislav,

Sorry to bug you. I am going on vacation starting next week and I just
wanted to get an idea if v2 looks good for merging in to you? If not I
could probably get a v3 out before I leave.

Thank you,
Ross Philipson