[PATCH] perf: tools: Add missing branch_sample_type

Anshuman Khandual posted 1 patch 4 years, 4 months ago
tools/perf/util/perf_event_attr_fprintf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] perf: tools: Add missing branch_sample_type
Posted by Anshuman Khandual 4 years, 4 months ago
This updates branch sample type with missing PERF_SAMPLE_BRANCH_TYPE_SAVE.

Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: linux-perf-users@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Suggested-by: James Clark <james.clark@arm.com>
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
 tools/perf/util/perf_event_attr_fprintf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/perf_event_attr_fprintf.c b/tools/perf/util/perf_event_attr_fprintf.c
index 47b7531f51da..98af3fa4ea35 100644
--- a/tools/perf/util/perf_event_attr_fprintf.c
+++ b/tools/perf/util/perf_event_attr_fprintf.c
@@ -52,7 +52,7 @@ static void __p_branch_sample_type(char *buf, size_t size, u64 value)
 		bit_name(ABORT_TX), bit_name(IN_TX), bit_name(NO_TX),
 		bit_name(COND), bit_name(CALL_STACK), bit_name(IND_JUMP),
 		bit_name(CALL), bit_name(NO_FLAGS), bit_name(NO_CYCLES),
-		bit_name(HW_INDEX),
+		bit_name(TYPE_SAVE), bit_name(HW_INDEX),
 		{ .name = NULL, }
 	};
 #undef bit_name
-- 
2.20.1

Re: [PATCH] perf: tools: Add missing branch_sample_type
Posted by Jiri Olsa 4 years, 4 months ago
On Wed, Feb 02, 2022 at 04:27:23PM +0530, Anshuman Khandual wrote:
> This updates branch sample type with missing PERF_SAMPLE_BRANCH_TYPE_SAVE.
> 
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: linux-perf-users@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Suggested-by: James Clark <james.clark@arm.com>
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>

Acked-by: Jiri Olsa <jolsa@redhat.com>

thanks,
jirka

> ---
>  tools/perf/util/perf_event_attr_fprintf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/perf_event_attr_fprintf.c b/tools/perf/util/perf_event_attr_fprintf.c
> index 47b7531f51da..98af3fa4ea35 100644
> --- a/tools/perf/util/perf_event_attr_fprintf.c
> +++ b/tools/perf/util/perf_event_attr_fprintf.c
> @@ -52,7 +52,7 @@ static void __p_branch_sample_type(char *buf, size_t size, u64 value)
>  		bit_name(ABORT_TX), bit_name(IN_TX), bit_name(NO_TX),
>  		bit_name(COND), bit_name(CALL_STACK), bit_name(IND_JUMP),
>  		bit_name(CALL), bit_name(NO_FLAGS), bit_name(NO_CYCLES),
> -		bit_name(HW_INDEX),
> +		bit_name(TYPE_SAVE), bit_name(HW_INDEX),
>  		{ .name = NULL, }
>  	};
>  #undef bit_name
> -- 
> 2.20.1
> 

Re: [PATCH] perf: tools: Add missing branch_sample_type
Posted by Arnaldo Carvalho de Melo 4 years, 4 months ago
Em Wed, Feb 02, 2022 at 05:55:45PM +0100, Jiri Olsa escreveu:
> On Wed, Feb 02, 2022 at 04:27:23PM +0530, Anshuman Khandual wrote:
> > This updates branch sample type with missing PERF_SAMPLE_BRANCH_TYPE_SAVE.
> > 
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Ingo Molnar <mingo@redhat.com>
> > Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> > Cc: Mark Rutland <mark.rutland@arm.com>
> > Cc: linux-perf-users@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > Suggested-by: James Clark <james.clark@arm.com>
> > Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> 
> Acked-by: Jiri Olsa <jolsa@redhat.com>

Thanks, applied.

- Arnaldo

 
> thanks,
> jirka
> 
> > ---
> >  tools/perf/util/perf_event_attr_fprintf.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/perf/util/perf_event_attr_fprintf.c b/tools/perf/util/perf_event_attr_fprintf.c
> > index 47b7531f51da..98af3fa4ea35 100644
> > --- a/tools/perf/util/perf_event_attr_fprintf.c
> > +++ b/tools/perf/util/perf_event_attr_fprintf.c
> > @@ -52,7 +52,7 @@ static void __p_branch_sample_type(char *buf, size_t size, u64 value)
> >  		bit_name(ABORT_TX), bit_name(IN_TX), bit_name(NO_TX),
> >  		bit_name(COND), bit_name(CALL_STACK), bit_name(IND_JUMP),
> >  		bit_name(CALL), bit_name(NO_FLAGS), bit_name(NO_CYCLES),
> > -		bit_name(HW_INDEX),
> > +		bit_name(TYPE_SAVE), bit_name(HW_INDEX),
> >  		{ .name = NULL, }
> >  	};
> >  #undef bit_name
> > -- 
> > 2.20.1
> > 

-- 

- Arnaldo