[PATCH 0/9] Remove remaining parts of congestions tracking code.

NeilBrown posted 9 patches 4 years, 5 months ago
block/bfq-iosched.c              |  2 +-
drivers/block/drbd/drbd_int.h    |  3 --
drivers/block/drbd/drbd_req.c    |  3 +-
fs/ceph/addr.c                   | 27 ---------------
fs/ceph/super.c                  |  2 --
fs/ceph/super.h                  |  2 --
fs/ext2/ialloc.c                 |  2 --
fs/f2fs/compress.c               |  6 ++--
fs/f2fs/data.c                   |  9 +++--
fs/f2fs/segment.c                | 14 ++++----
fs/f2fs/super.c                  |  8 ++---
fs/fuse/control.c                | 17 ----------
fs/fuse/dev.c                    |  8 -----
fs/nfs/sysctl.c                  |  7 ----
fs/nfs/write.c                   | 53 +----------------------------
fs/nilfs2/segbuf.c               | 11 ------
fs/xfs/xfs_buf.c                 |  3 --
include/linux/backing-dev-defs.h |  8 -----
include/linux/backing-dev.h      | 28 ----------------
include/linux/nfs_fs.h           |  1 -
include/linux/nfs_fs_sb.h        |  1 -
include/trace/events/writeback.h | 28 ----------------
mm/backing-dev.c                 | 57 --------------------------------
mm/vmscan.c                      |  4 +--
24 files changed, 25 insertions(+), 279 deletions(-)
[PATCH 0/9] Remove remaining parts of congestions tracking code.
Posted by NeilBrown 4 years, 5 months ago
Congestion hasn't been reliably tracked for quite some time.
Most MM uses of it for guiding writeback decisions were removed in 5.16.
Some other uses were removed in 17-rc1.

This series removes the remaining places that test for congestion, and
the few places which still set it.

The second patch touches a few filesystems.  I didn't think there was
much value in splitting this out by filesystems, but if maintainers
would rather I did that, I will.

The f2fs, cephfs, fuse, NFS, and block patches can go through the
respective trees proving the final patch doesn't land until after they
all do - so maybe it should be held for 5.18-rc2 if all the rest lands
by 5.18-rc1.

Thanks,
NeilBrown

---

NeilBrown (9):
      Remove inode_congested()
      Remove bdi_congested() and wb_congested() and related functions
      f2fs: change retry waiting for f2fs_write_single_data_page()
      f2f2: replace some congestion_wait() calls with io_schedule_timeout()
      cephfs: don't set/clear bdi_congestion
      fuse: don't set/clear bdi_congested
      NFS: remove congestion control.
      block/bfq-iosched.c: use "false" rather than "BLK_RW_ASYNC"
      Remove congestion tracking framework.


 block/bfq-iosched.c              |  2 +-
 drivers/block/drbd/drbd_int.h    |  3 --
 drivers/block/drbd/drbd_req.c    |  3 +-
 fs/ceph/addr.c                   | 27 ---------------
 fs/ceph/super.c                  |  2 --
 fs/ceph/super.h                  |  2 --
 fs/ext2/ialloc.c                 |  2 --
 fs/f2fs/compress.c               |  6 ++--
 fs/f2fs/data.c                   |  9 +++--
 fs/f2fs/segment.c                | 14 ++++----
 fs/f2fs/super.c                  |  8 ++---
 fs/fuse/control.c                | 17 ----------
 fs/fuse/dev.c                    |  8 -----
 fs/nfs/sysctl.c                  |  7 ----
 fs/nfs/write.c                   | 53 +----------------------------
 fs/nilfs2/segbuf.c               | 11 ------
 fs/xfs/xfs_buf.c                 |  3 --
 include/linux/backing-dev-defs.h |  8 -----
 include/linux/backing-dev.h      | 28 ----------------
 include/linux/nfs_fs.h           |  1 -
 include/linux/nfs_fs_sb.h        |  1 -
 include/trace/events/writeback.h | 28 ----------------
 mm/backing-dev.c                 | 57 --------------------------------
 mm/vmscan.c                      |  4 +--
 24 files changed, 25 insertions(+), 279 deletions(-)

--
Signature

Re: [PATCH 0/9] Remove remaining parts of congestions tracking code.
Posted by Andrew Morton 4 years, 5 months ago
On Thu, 27 Jan 2022 13:46:29 +1100 NeilBrown <neilb@suse.de> wrote:

> Congestion hasn't been reliably tracked for quite some time.
> Most MM uses of it for guiding writeback decisions were removed in 5.16.
> Some other uses were removed in 17-rc1.
> 
> This series removes the remaining places that test for congestion, and
> the few places which still set it.
> 
> The second patch touches a few filesystems.  I didn't think there was
> much value in splitting this out by filesystems, but if maintainers
> would rather I did that, I will.
> 
> The f2fs, cephfs, fuse, NFS, and block patches can go through the
> respective trees proving the final patch doesn't land until after they
> all do - so maybe it should be held for 5.18-rc2 if all the rest lands
> by 5.18-rc1.

Plan B: I'll just take everything.  While collecting tested-bys and
acked-bys from filesystem maintainers (please).

Re: [PATCH 0/9] Remove remaining parts of congestions tracking code.
Posted by Jens Axboe 4 years, 5 months ago
On 1/26/22 7:46 PM, NeilBrown wrote:
> Congestion hasn't been reliably tracked for quite some time.
> Most MM uses of it for guiding writeback decisions were removed in 5.16.
> Some other uses were removed in 17-rc1.
> 
> This series removes the remaining places that test for congestion, and
> the few places which still set it.
> 
> The second patch touches a few filesystems.  I didn't think there was
> much value in splitting this out by filesystems, but if maintainers
> would rather I did that, I will.
> 
> The f2fs, cephfs, fuse, NFS, and block patches can go through the
> respective trees proving the final patch doesn't land until after they
> all do - so maybe it should be held for 5.18-rc2 if all the rest lands
> by 5.18-rc1.

For the series:

Acked-by: Jens Axboe <axboe@kernel.dk>

-- 
Jens Axboe