[PATCH v2 0/3] Enable named interrupt smbus-alert for ACPI

Akhil R posted 3 patches 4 years, 5 months ago
Documentation/firmware-guide/acpi/enumeration.rst | 38 +++++++++++++++++++++++
drivers/base/property.c                           | 35 +++++++++++++++++++++
drivers/i2c/i2c-core-base.c                       |  2 +-
drivers/i2c/i2c-core-smbus.c                      | 10 +++---
drivers/i2c/i2c-smbus.c                           |  2 +-
include/linux/i2c-smbus.h                         |  6 ++--
include/linux/property.h                          |  3 ++
7 files changed, 86 insertions(+), 10 deletions(-)
[PATCH v2 0/3] Enable named interrupt smbus-alert for ACPI
Posted by Akhil R 4 years, 5 months ago
I2C - SMBus core drivers use named interrupts to support smbus_alert.
As named interrupts are not available for ACPI based systems, it was
required to change the i2c bus controller driver if to use smbus alert.
These patches provide option for named interrupts in ACPI and  make the
implementation similar to DT. This will enable use of interrupt named
'smbus-alert' in ACPI as well which will be taken during i2c adapter
register.

v1->v2:
  * Added firmware guide documentation for ACPI named interrupts
  * Updates in function description comments

Akhil R (3):
  device property: Add device_irq_get_byname
  docs: firmware-guide: ACPI: Add named interrupt doc
  i2c: smbus: Use device_*() functions instead of of_*()

 Documentation/firmware-guide/acpi/enumeration.rst | 38 +++++++++++++++++++++++
 drivers/base/property.c                           | 35 +++++++++++++++++++++
 drivers/i2c/i2c-core-base.c                       |  2 +-
 drivers/i2c/i2c-core-smbus.c                      | 10 +++---
 drivers/i2c/i2c-smbus.c                           |  2 +-
 include/linux/i2c-smbus.h                         |  6 ++--
 include/linux/property.h                          |  3 ++
 7 files changed, 86 insertions(+), 10 deletions(-)

-- 
2.7.4

Re: [PATCH v2 0/3] Enable named interrupt smbus-alert for ACPI
Posted by Andy Shevchenko 4 years, 5 months ago
On Wed, Jan 12, 2022 at 4:14 PM Akhil R <akhilrajeev@nvidia.com> wrote:
>
> I2C - SMBus core drivers use named interrupts to support smbus_alert.
> As named interrupts are not available for ACPI based systems, it was
> required to change the i2c bus controller driver if to use smbus alert.
> These patches provide option for named interrupts in ACPI and  make the
> implementation similar to DT. This will enable use of interrupt named
> 'smbus-alert' in ACPI as well which will be taken during i2c adapter
> register.

Most of my comments are regarding spelling and documentation.
The code looks almost good enough. That said, if maintainers will be
okay, I'm sure the next version will be upstream-ready.

Thanks!

-- 
With Best Regards,
Andy Shevchenko