[PATCH] io_uring: remove unused para

GuoYong Zheng posted 1 patch 4 years, 5 months ago
fs/io_uring.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] io_uring: remove unused para
Posted by GuoYong Zheng 4 years, 5 months ago
Para res2 is not used in __io_complete_rw, remove it.

Signed-off-by: GuoYong Zheng <zhenggy@chinatelecom.cn>
---
 fs/io_uring.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/io_uring.c b/fs/io_uring.c
index e6fb1bb..8473f955 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -2858,7 +2858,7 @@ static inline void io_req_task_complete(struct io_kiocb *req, bool *locked)
 	}
 }
 
-static void __io_complete_rw(struct io_kiocb *req, long res, long res2,
+static void __io_complete_rw(struct io_kiocb *req, long res,
 			     unsigned int issue_flags)
 {
 	if (__io_complete_rw_common(req, res))
@@ -3108,7 +3108,7 @@ static void kiocb_done(struct io_kiocb *req, ssize_t ret,
 	if (req->flags & REQ_F_CUR_POS)
 		req->file->f_pos = req->rw.kiocb.ki_pos;
 	if (ret >= 0 && (req->rw.kiocb.ki_complete == io_complete_rw))
-		__io_complete_rw(req, ret, 0, issue_flags);
+		__io_complete_rw(req, ret, issue_flags);
 	else
 		io_rw_done(&req->rw.kiocb, ret);
 
-- 
1.8.3.1

Re: [PATCH] io_uring: remove unused para
Posted by Jens Axboe 4 years, 5 months ago
On 1/5/22 2:12 AM, GuoYong Zheng wrote:
> Para res2 is not used in __io_complete_rw, remove it.

Applied, but changed 'para' to parameter. Please just spell it out,
there's no point in being too verbose here. Also added a Fixes tag:

https://git.kernel.dk/cgit/linux-block/commit/?h=for-5.17/io_uring&id=00f6e68b8d59bf006db54e3e257684f44d26195c

Thank you!

-- 
Jens Axboe