drivers/clk/clk-renesas-pcie.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Convert the Renesas 9-series PCIe clock generator driver from
SIMPLE_DEV_PM_OPS() to DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr().
This lets us drop the __maybe_unused annotations from its suspend and
resume callbacks, and reduces kernel size in case CONFIG_PM or
CONFIG_PM_SLEEP is disabled.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/clk/clk-renesas-pcie.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/clk/clk-renesas-pcie.c b/drivers/clk/clk-renesas-pcie.c
index 6650e3440c7492cf..b9bee616afe8d4ef 100644
--- a/drivers/clk/clk-renesas-pcie.c
+++ b/drivers/clk/clk-renesas-pcie.c
@@ -359,7 +359,7 @@ static int rs9_probe(struct i2c_client *client)
return ret;
}
-static int __maybe_unused rs9_suspend(struct device *dev)
+static int rs9_suspend(struct device *dev)
{
struct rs9_driver_data *rs9 = dev_get_drvdata(dev);
@@ -369,7 +369,7 @@ static int __maybe_unused rs9_suspend(struct device *dev)
return 0;
}
-static int __maybe_unused rs9_resume(struct device *dev)
+static int rs9_resume(struct device *dev)
{
struct rs9_driver_data *rs9 = dev_get_drvdata(dev);
int ret;
@@ -415,12 +415,12 @@ static const struct of_device_id clk_rs9_of_match[] = {
};
MODULE_DEVICE_TABLE(of, clk_rs9_of_match);
-static SIMPLE_DEV_PM_OPS(rs9_pm_ops, rs9_suspend, rs9_resume);
+static DEFINE_SIMPLE_DEV_PM_OPS(rs9_pm_ops, rs9_suspend, rs9_resume);
static struct i2c_driver rs9_driver = {
.driver = {
.name = "clk-renesas-pcie-9series",
- .pm = &rs9_pm_ops,
+ .pm = pm_sleep_ptr(&rs9_pm_ops),
.of_match_table = clk_rs9_of_match,
},
.probe = rs9_probe,
--
2.43.0
Quoting Geert Uytterhoeven (2026-01-21 04:03:11) > Convert the Renesas 9-series PCIe clock generator driver from > SIMPLE_DEV_PM_OPS() to DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr(). > This lets us drop the __maybe_unused annotations from its suspend and > resume callbacks, and reduces kernel size in case CONFIG_PM or > CONFIG_PM_SLEEP is disabled. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- Applied to clk-next
On Wed, Jan 21, 2026 at 12:03:11PM +0100, Geert Uytterhoeven wrote: > Convert the Renesas 9-series PCIe clock generator driver from > SIMPLE_DEV_PM_OPS() to DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr(). > This lets us drop the __maybe_unused annotations from its suspend and > resume callbacks, and reduces kernel size in case CONFIG_PM or > CONFIG_PM_SLEEP is disabled. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Brian Masney <bmasney@redhat.com>
© 2016 - 2026 Red Hat, Inc.