ACPI: scan: Use resource_type() for resource type checking

[PATCH v1] ACPI: scan: Use resource_type() for resource type checking

Posted by Rafael J. Wysocki 1 month, 1 week ago

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

To follow a well-established existing pattern, use resource_type() for
resource type checking in acpi_scan_claim_resources().

No intentional functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---

This is a follow-up to

https://lore.kernel.org/linux-acpi/7888874.EvYhyI6sBW@rafael.j.wysocki/

which is present in linux-next.

---
 drivers/acpi/scan.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/acpi/scan.c
+++ b/drivers/acpi/scan.c
@@ -2624,7 +2624,7 @@ static void acpi_scan_claim_resources(st
 		if ((res->flags & IORESOURCE_DISABLED) || res->end < res->start)
 			continue;
 
-		if (res->flags & IORESOURCE_IO) {
+		if (resource_type(res) == IORESOURCE_IO) {
 			/*
 			 * Follow the PNP system driver and on x86 skip I/O
 			 * resources that start below 0x100 (the "standard PC
@@ -2635,7 +2635,7 @@ static void acpi_scan_claim_resources(st
 				continue;
 			}
 			r = request_region(res->start, resource_size(res), regionid);
-		} else if (res->flags & IORESOURCE_MEM) {
+		} else if (resource_type(res) == IORESOURCE_MEM) {
 			r = request_mem_region(res->start, resource_size(res), regionid);
 		} else {
 			continue;

Re: [PATCH v1] ACPI: scan: Use resource_type() for resource type checking

Posted by Jonathan Cameron 1 month ago

On Tue, 30 Dec 2025 10:57:34 +0100
"Rafael J. Wysocki" <rafael@kernel.org> wrote:

> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> To follow a well-established existing pattern, use resource_type() for
> resource type checking in acpi_scan_claim_resources().
> 
> No intentional functional impact.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>

Re: [PATCH v1] ACPI: scan: Use resource_type() for resource type checking

Posted by Ilpo Järvinen 1 month, 1 week ago

On Tue, 30 Dec 2025, Rafael J. Wysocki wrote:

> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> To follow a well-established existing pattern, use resource_type() for
> resource type checking in acpi_scan_claim_resources().
> 
> No intentional functional impact.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> 
> This is a follow-up to
> 
> https://lore.kernel.org/linux-acpi/7888874.EvYhyI6sBW@rafael.j.wysocki/
> 
> which is present in linux-next.
> 
> ---
>  drivers/acpi/scan.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/drivers/acpi/scan.c
> +++ b/drivers/acpi/scan.c
> @@ -2624,7 +2624,7 @@ static void acpi_scan_claim_resources(st
>  		if ((res->flags & IORESOURCE_DISABLED) || res->end < res->start)
>  			continue;
>  
> -		if (res->flags & IORESOURCE_IO) {
> +		if (resource_type(res) == IORESOURCE_IO) {
>  			/*
>  			 * Follow the PNP system driver and on x86 skip I/O
>  			 * resources that start below 0x100 (the "standard PC
> @@ -2635,7 +2635,7 @@ static void acpi_scan_claim_resources(st
>  				continue;
>  			}
>  			r = request_region(res->start, resource_size(res), regionid);
> -		} else if (res->flags & IORESOURCE_MEM) {
> +		} else if (resource_type(res) == IORESOURCE_MEM) {
>  			r = request_mem_region(res->start, resource_size(res), regionid);
>  		} else {
>  			continue;
> 
> 
> 

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

-- 
 i.

Re: [PATCH v1] ACPI: scan: Use resource_type() for resource type checking

Posted by Andy Shevchenko 1 month, 1 week ago

On Tue, Dec 30, 2025 at 10:57:34AM +0100, Rafael J. Wysocki wrote:

> To follow a well-established existing pattern, use resource_type() for
> resource type checking in acpi_scan_claim_resources().
> 
> No intentional functional impact.

Thanks for this!
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>


-- 
With Best Regards,
Andy Shevchenko