[PATCH v1 07/15] ACPI: button: Eliminate redundant conditional statement

Rafael J. Wysocki posted 1 patch 6 days, 11 hours ago
drivers/acpi/button.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
[PATCH v1 07/15] ACPI: button: Eliminate redundant conditional statement
Posted by Rafael J. Wysocki 6 days, 11 hours ago
From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>

Simplify do_update initialization in acpi_lid_notify_state() by
assigning the value of the condition it depends on directly to it.

No intentional functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/acpi/button.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c
index fcb2eed823c1..236eb025bb0d 100644
--- a/drivers/acpi/button.c
+++ b/drivers/acpi/button.c
@@ -217,12 +217,8 @@ static void acpi_lid_notify_state(struct acpi_button *button, bool state)
 	 * So "last_time" is only updated after a timeout or an actual
 	 * switch.
 	 */
-	if (lid_init_state != ACPI_BUTTON_LID_INIT_IGNORE ||
-	    button->last_state != state)
-		do_update = true;
-	else
-		do_update = false;
-
+	do_update = lid_init_state != ACPI_BUTTON_LID_INIT_IGNORE ||
+			button->last_state != state;
 	next_report = ktime_add(button->last_time,
 				ms_to_ktime(lid_report_interval));
 	if (button->last_state == state &&
-- 
2.51.0