platform: arm64: EC_LENOVO_YOGA_C630 should depend on ARCH_QCOM

[PATCH] platform: arm64: EC_LENOVO_YOGA_C630 should depend on ARCH_QCOM

Posted by Geert Uytterhoeven 1 year, 5 months ago

The Lenovo Yoga C630 Embedded Controller is only present on the Qualcomm
Snapdragon-based Lenovo Yoga C630 laptop.  Hence add a dependency on
ARCH_QCOM, to prevent asking the user about this driver when configuring
a kernel without Qualcomm SoC support.

Fixes: 5e5f2f92cccc29f3 ("platform: arm64: add Lenovo Yoga C630 WOS EC driver")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/platform/arm64/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/arm64/Kconfig b/drivers/platform/arm64/Kconfig
index 058a4baa216a83b8..f7539e5419cf1616 100644
--- a/drivers/platform/arm64/Kconfig
+++ b/drivers/platform/arm64/Kconfig
@@ -35,6 +35,7 @@ config EC_ACER_ASPIRE1
 
 config EC_LENOVO_YOGA_C630
 	tristate "Lenovo Yoga C630 Embedded Controller driver"
+	depends on ARCH_QCOM || COMPILE_TEST
 	depends on I2C
 	select AUXILIARY_BUS
 	help
-- 
2.34.1

Re: [PATCH] platform: arm64: EC_LENOVO_YOGA_C630 should depend on ARCH_QCOM

Posted by Dmitry Baryshkov 1 year, 5 months ago

On Thu, 11 Jul 2024 at 17:32, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> The Lenovo Yoga C630 Embedded Controller is only present on the Qualcomm
> Snapdragon-based Lenovo Yoga C630 laptop.  Hence add a dependency on
> ARCH_QCOM, to prevent asking the user about this driver when configuring
> a kernel without Qualcomm SoC support.
>
> Fixes: 5e5f2f92cccc29f3 ("platform: arm64: add Lenovo Yoga C630 WOS EC driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/platform/arm64/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Could you please add the same condition to the Acer Aspire 1 entry?

>
> diff --git a/drivers/platform/arm64/Kconfig b/drivers/platform/arm64/Kconfig
> index 058a4baa216a83b8..f7539e5419cf1616 100644
> --- a/drivers/platform/arm64/Kconfig
> +++ b/drivers/platform/arm64/Kconfig
> @@ -35,6 +35,7 @@ config EC_ACER_ASPIRE1
>
>  config EC_LENOVO_YOGA_C630
>         tristate "Lenovo Yoga C630 Embedded Controller driver"
> +       depends on ARCH_QCOM || COMPILE_TEST
>         depends on I2C
>         select AUXILIARY_BUS
>         help
> --
> 2.34.1
>


-- 
With best wishes
Dmitry

Re: [PATCH] platform: arm64: EC_LENOVO_YOGA_C630 should depend on ARCH_QCOM

Posted by Geert Uytterhoeven 1 year, 5 months ago

Hi Dmitry,

On Fri, Jul 12, 2024 at 12:24 PM Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
> On Thu, 11 Jul 2024 at 17:32, Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
> >
> > The Lenovo Yoga C630 Embedded Controller is only present on the Qualcomm
> > Snapdragon-based Lenovo Yoga C630 laptop.  Hence add a dependency on
> > ARCH_QCOM, to prevent asking the user about this driver when configuring
> > a kernel without Qualcomm SoC support.
> >
> > Fixes: 5e5f2f92cccc29f3 ("platform: arm64: add Lenovo Yoga C630 WOS EC driver")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> >  drivers/platform/arm64/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
>
> Could you please add the same condition to the Acer Aspire 1 entry?

https://lore.kernel.org/all/f5f38709c01d369ed9e375ceb2a9a12986457a1a.1720707932.git.geert+renesas@glider.be/

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] platform: arm64: EC_LENOVO_YOGA_C630 should depend on ARCH_QCOM

Posted by Ilpo Järvinen 1 year, 5 months ago

On Thu, 11 Jul 2024 16:32:35 +0200, Geert Uytterhoeven wrote:

> The Lenovo Yoga C630 Embedded Controller is only present on the Qualcomm
> Snapdragon-based Lenovo Yoga C630 laptop.  Hence add a dependency on
> ARCH_QCOM, to prevent asking the user about this driver when configuring
> a kernel without Qualcomm SoC support.
> 
> 

Thank you for your contribution, it has been applied to my local
review-ilpo branch. Note it will show up in the public
platform-drivers-x86/review-ilpo branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform: arm64: EC_LENOVO_YOGA_C630 should depend on ARCH_QCOM
      commit: 1e02e317470b1c68d5971e51e8c62967ec1bc828

--
 i.

Re: [PATCH] platform: arm64: EC_LENOVO_YOGA_C630 should depend on ARCH_QCOM

Posted by Hans de Goede 1 year, 5 months ago

Hi Geert,

On 7/11/24 4:32 PM, Geert Uytterhoeven wrote:
> The Lenovo Yoga C630 Embedded Controller is only present on the Qualcomm
> Snapdragon-based Lenovo Yoga C630 laptop.  Hence add a dependency on
> ARCH_QCOM, to prevent asking the user about this driver when configuring
> a kernel without Qualcomm SoC support.
> 
> Fixes: 5e5f2f92cccc29f3 ("platform: arm64: add Lenovo Yoga C630 WOS EC driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Not sure if this warrants a fixes tag though, anyways I'll leave that up
to Ilpo when he applies this.

Regards,

Hans





> ---
>  drivers/platform/arm64/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/arm64/Kconfig b/drivers/platform/arm64/Kconfig
> index 058a4baa216a83b8..f7539e5419cf1616 100644
> --- a/drivers/platform/arm64/Kconfig
> +++ b/drivers/platform/arm64/Kconfig
> @@ -35,6 +35,7 @@ config EC_ACER_ASPIRE1
>  
>  config EC_LENOVO_YOGA_C630
>  	tristate "Lenovo Yoga C630 Embedded Controller driver"
> +	depends on ARCH_QCOM || COMPILE_TEST
>  	depends on I2C
>  	select AUXILIARY_BUS
>  	help