ASoC: tas2781: mark dvc_tlv with __maybe_unused

[PATCH] ASoC: tas2781: mark dvc_tlv with __maybe_unused

Posted by Gergo Koteles 1 year, 10 months ago

Since we put dvc_tlv static variable to a header file it's copied to
each module that includes the header. But not all of them are actually
used it.

Fix this W=1 build warning:

include/sound/tas2781-tlv.h:18:35: warning: 'dvc_tlv' defined but not
used [-Wunused-const-variable=]

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202403290354.v0StnRpc-lkp@intel.com/
Fixes: ae065d0ce9e3 ("ALSA: hda/tas2781: remove digital gain kcontrol")
Signed-off-by: Gergo Koteles <soyer@irl.hu>
---
 include/sound/tas2781-tlv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/sound/tas2781-tlv.h b/include/sound/tas2781-tlv.h
index 4038dd421150..1dc59005d241 100644
--- a/include/sound/tas2781-tlv.h
+++ b/include/sound/tas2781-tlv.h
@@ -15,7 +15,7 @@
 #ifndef __TAS2781_TLV_H__
 #define __TAS2781_TLV_H__
 
-static const DECLARE_TLV_DB_SCALE(dvc_tlv, -10000, 100, 0);
+static const __maybe_unused DECLARE_TLV_DB_SCALE(dvc_tlv, -10000, 100, 0);
 static const DECLARE_TLV_DB_SCALE(amp_vol_tlv, 1100, 50, 0);
 
 #endif

base-commit: 2d0401ee38d43ab0e4cdd02dfc9d402befb2b5c8
-- 
2.44.0

Re: [PATCH] ASoC: tas2781: mark dvc_tlv with __maybe_unused

Posted by Takashi Iwai 1 year, 10 months ago

On Thu, 28 Mar 2024 23:47:37 +0100,
Gergo Koteles wrote:
> 
> Since we put dvc_tlv static variable to a header file it's copied to
> each module that includes the header. But not all of them are actually
> used it.
> 
> Fix this W=1 build warning:
> 
> include/sound/tas2781-tlv.h:18:35: warning: 'dvc_tlv' defined but not
> used [-Wunused-const-variable=]
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202403290354.v0StnRpc-lkp@intel.com/
> Fixes: ae065d0ce9e3 ("ALSA: hda/tas2781: remove digital gain kcontrol")
> Signed-off-by: Gergo Koteles <soyer@irl.hu>

Thanks, applied now.


Takashi