hns3: Demote load and progress messages to debug level

[PATCH] [net-next] hns3: Demote load and progress messages to debug level

Posted by Geert Uytterhoeven 6 months, 3 weeks ago

From: Geert Uytterhoeven <geert+renesas@glider.be>

No driver should spam the kernel log when merely being loaded.
The message in hclge_init() is clearly a debug message.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Alternatively, the printing in hns3_init_module() could be removed
completely, but that would make hns3_driver_string[] and
hns3_copyright[] unused, which HiSilicon legal may object against?
---
 drivers/net/ethernet/hisilicon/hns3/hns3_enet.c         | 4 ++--
 drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
index b03b8758c7774ec2..5c8c62ea6ac0429f 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
@@ -5961,8 +5961,8 @@ static int __init hns3_init_module(void)
 {
 	int ret;
 
-	pr_info("%s: %s - version\n", hns3_driver_name, hns3_driver_string);
-	pr_info("%s: %s\n", hns3_driver_name, hns3_copyright);
+	pr_debug("%s: %s - version\n", hns3_driver_name, hns3_driver_string);
+	pr_debug("%s: %s\n", hns3_driver_name, hns3_copyright);
 
 	client.type = HNAE3_CLIENT_KNIC;
 	snprintf(client.name, HNAE3_CLIENT_NAME_LENGTH, "%s",
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
index 3e28a08934abd2e1..6bfff77ea7e67e8d 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
@@ -12904,7 +12904,7 @@ static struct hnae3_ae_algo ae_algo = {
 
 static int __init hclge_init(void)
 {
-	pr_info("%s is initializing\n", HCLGE_NAME);
+	pr_debug("%s is initializing\n", HCLGE_NAME);
 
 	hclge_wq = alloc_workqueue("%s", WQ_UNBOUND, 0, HCLGE_NAME);
 	if (!hclge_wq) {
-- 
2.43.0

Re: [PATCH] [net-next] hns3: Demote load and progress messages to debug level

Posted by Paolo Abeni 6 months, 3 weeks ago

On 5/27/25 9:30 PM, Geert Uytterhoeven wrote:
> From: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> No driver should spam the kernel log when merely being loaded.
> The message in hclge_init() is clearly a debug message.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

## Form letter - net-next-closed

The merge window for v6.16 has begun and therefore net-next is closed
for new drivers, features, code refactoring and optimizations. We are
currently accepting bug fixes only.

Please repost when net-next reopens after June 8th.

RFC patches sent for review only are obviously welcome at any time.

Re: [PATCH] [net-next] hns3: Demote load and progress messages to debug level

Posted by Jijie Shao 6 months, 3 weeks ago

on 2025/5/28 3:30, Geert Uytterhoeven wrote:
> From: Geert Uytterhoeven <geert+renesas@glider.be>
>
> No driver should spam the kernel log when merely being loaded.
> The message in hclge_init() is clearly a debug message.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks,
Reviewed-by: Jijie Shao<shaojijie@huawei.com>

> ---
> Alternatively, the printing in hns3_init_module() could be removed
> completely, but that would make hns3_driver_string[] and
> hns3_copyright[] unused, which HiSilicon legal may object against?
> ---
>   drivers/net/ethernet/hisilicon/hns3/hns3_enet.c         | 4 ++--
>   drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> index b03b8758c7774ec2..5c8c62ea6ac0429f 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> @@ -5961,8 +5961,8 @@ static int __init hns3_init_module(void)
>   {
>   	int ret;
>   
> -	pr_info("%s: %s - version\n", hns3_driver_name, hns3_driver_string);
> -	pr_info("%s: %s\n", hns3_driver_name, hns3_copyright);
> +	pr_debug("%s: %s - version\n", hns3_driver_name, hns3_driver_string);
> +	pr_debug("%s: %s\n", hns3_driver_name, hns3_copyright);
>   
>   	client.type = HNAE3_CLIENT_KNIC;
>   	snprintf(client.name, HNAE3_CLIENT_NAME_LENGTH, "%s",
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
> index 3e28a08934abd2e1..6bfff77ea7e67e8d 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
> @@ -12904,7 +12904,7 @@ static struct hnae3_ae_algo ae_algo = {
>   
>   static int __init hclge_init(void)
>   {
> -	pr_info("%s is initializing\n", HCLGE_NAME);
> +	pr_debug("%s is initializing\n", HCLGE_NAME);
>   
>   	hclge_wq = alloc_workqueue("%s", WQ_UNBOUND, 0, HCLGE_NAME);
>   	if (!hclge_wq) {

Re: [PATCH] [net-next] hns3: Demote load and progress messages to debug level

Posted by Andrew Lunn 6 months, 3 weeks ago

On Tue, May 27, 2025 at 09:30:15PM +0200, Geert Uytterhoeven wrote:
> From: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> No driver should spam the kernel log when merely being loaded.
> The message in hclge_init() is clearly a debug message.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Alternatively, the printing in hns3_init_module() could be removed
> completely, but that would make hns3_driver_string[] and
> hns3_copyright[] unused, which HiSilicon legal may object against?

From a IANAL perspective, pr_debug() is O.K. for me.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew