// +Cc Greg Hi Johan, Johan Hovold <johan@kernel.org> wrote: [...] > drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c | 4 ---- > drivers/net/wireless/realtek/rtl8xxxu/core.c | 11 +++-------- > drivers/net/wireless/realtek/rtlwifi/usb.c | 4 ---- Acked to changes of these Realtek WiFi drivers. But I'd like to know why rtw88/rtw89 aren't included in this patchset? Greg sent a patch [1] to correct error path of USB probe for rtw88. In the discussion, he also mentioned the simplest way is to drop usb_get_dev()/usb_put_dev() like this patchset does. Will you share patches for rtw88/rtw89? I so, I'd drop Greg's patch and apply yours. [1] https://lore.kernel.org/linux-wireless/2026022333-periscope-unusual-f0a0@gregkh/ Ping-Ke
On Fri, Mar 06, 2026 at 01:40:31AM +0000, Ping-Ke Shih wrote: > // +Cc Greg > > Hi Johan, > > Johan Hovold <johan@kernel.org> wrote: > > [...] > > > drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c | 4 ---- > > drivers/net/wireless/realtek/rtl8xxxu/core.c | 11 +++-------- > > drivers/net/wireless/realtek/rtlwifi/usb.c | 4 ---- > > Acked to changes of these Realtek WiFi drivers. But I'd like to know why > rtw88/rtw89 aren't included in this patchset? I used a more specific grep pattern to catch driver releasing references in disconnect() and therefore missed a few that dropped the reference in helper functions (or used non-standard names for their disconnect function such as ath10k, I see now). > Greg sent a patch [1] to > correct error path of USB probe for rtw88. In the discussion, he also > mentioned the simplest way is to drop usb_get_dev()/usb_put_dev() like > this patchset does. Will you share patches for rtw88/rtw89? I so, I'd > drop Greg's patch and apply yours. > > [1] https://lore.kernel.org/linux-wireless/2026022333-periscope-unusual-f0a0@gregkh/ Sure, I can include rtw88 (and ath10k and ath6kl) in a v2. Do you really prefer replacing Greg's fix or shall I send an incremental patch on top? Johan
Johan Hovold <johan@kernel.org> wrote: > On Fri, Mar 06, 2026 at 01:40:31AM +0000, Ping-Ke Shih wrote: > > // +Cc Greg > > > > Hi Johan, > > > > Johan Hovold <johan@kernel.org> wrote: > > > > [...] > > > > > drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c | 4 ---- > > > drivers/net/wireless/realtek/rtl8xxxu/core.c | 11 +++-------- > > > drivers/net/wireless/realtek/rtlwifi/usb.c | 4 ---- > > > > Acked to changes of these Realtek WiFi drivers. But I'd like to know why > > rtw88/rtw89 aren't included in this patchset? > > I used a more specific grep pattern to catch driver releasing references > in disconnect() and therefore missed a few that dropped the reference in > helper functions (or used non-standard names for their disconnect > function such as ath10k, I see now). > > > Greg sent a patch [1] to > > correct error path of USB probe for rtw88. In the discussion, he also > > mentioned the simplest way is to drop usb_get_dev()/usb_put_dev() like > > this patchset does. Will you share patches for rtw88/rtw89? I so, I'd > > drop Greg's patch and apply yours. > > > > [1] https://lore.kernel.org/linux-wireless/2026022333-periscope-unusual-f0a0@gregkh/ > > Sure, I can include rtw88 (and ath10k and ath6kl) in a v2. Can you please also include rtw89? (I saw you have sent v2 though) > > Do you really prefer replacing Greg's fix or shall I send an incremental > patch on top? No. I'd drop Gerg's fix from my tree. Ping-Ke
On Fri, Mar 06, 2026 at 09:04:22AM +0000, Ping-Ke Shih wrote: > Johan Hovold <johan@kernel.org> wrote: > > On Fri, Mar 06, 2026 at 01:40:31AM +0000, Ping-Ke Shih wrote: > > > // +Cc Greg > > > > > > Hi Johan, > > > > > > Johan Hovold <johan@kernel.org> wrote: > > > > > > [...] > > > > > > > drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c | 4 ---- > > > > drivers/net/wireless/realtek/rtl8xxxu/core.c | 11 +++-------- > > > > drivers/net/wireless/realtek/rtlwifi/usb.c | 4 ---- > > > > > > Acked to changes of these Realtek WiFi drivers. But I'd like to know why > > > rtw88/rtw89 aren't included in this patchset? > > > > I used a more specific grep pattern to catch driver releasing references > > in disconnect() and therefore missed a few that dropped the reference in > > helper functions (or used non-standard names for their disconnect > > function such as ath10k, I see now). > > > > > Greg sent a patch [1] to > > > correct error path of USB probe for rtw88. In the discussion, he also > > > mentioned the simplest way is to drop usb_get_dev()/usb_put_dev() like > > > this patchset does. Will you share patches for rtw88/rtw89? I so, I'd > > > drop Greg's patch and apply yours. > > > > > > [1] https://lore.kernel.org/linux-wireless/2026022333-periscope-unusual-f0a0@gregkh/ > > > > Sure, I can include rtw88 (and ath10k and ath6kl) in a v2. > > Can you please also include rtw89? (I saw you have sent v2 though) > > > > > Do you really prefer replacing Greg's fix or shall I send an incremental > > patch on top? > > No. I'd drop Gerg's fix from my tree. I have no objection for my changes being dropped, thanks for making these changes. greg k-h
On Fri, Mar 06, 2026 at 09:04:22AM +0000, Ping-Ke Shih wrote: > Johan Hovold <johan@kernel.org> wrote: > > Sure, I can include rtw88 (and ath10k and ath6kl) in a v2. > > Can you please also include rtw89? (I saw you have sent v2 though) Ah, sorry about that. I was sure I had grepped for usb_get_dev in wireless before sending v2 but apparently I did not. I just sent a separate follow-up for rtw89 here: https://lore.kernel.org/r/20260306093206.21081-1-johan@kernel.org Johan
Johan Hovold <johan@kernel.org> wrote: > On Fri, Mar 06, 2026 at 09:04:22AM +0000, Ping-Ke Shih wrote: > > Johan Hovold <johan@kernel.org> wrote: > > > > Sure, I can include rtw88 (and ath10k and ath6kl) in a v2. > > > > Can you please also include rtw89? (I saw you have sent v2 though) > > Ah, sorry about that. I was sure I had grepped for usb_get_dev in > wireless before sending v2 but apparently I did not. > > I just sent a separate follow-up for rtw89 here: > > https://lore.kernel.org/r/20260306093206.21081-1-johan@kernel.org Got it & thank you. :) Ping-Ke
© 2016 - 2026 Red Hat, Inc.