[PATCH] riscv: defconfig: Remove CONFIG_SND_SOC_STARFIVE=m

Geert Uytterhoeven posted 1 patch 3 months ago
arch/riscv/configs/defconfig | 1 -
1 file changed, 1 deletion(-)
[PATCH] riscv: defconfig: Remove CONFIG_SND_SOC_STARFIVE=m
Posted by Geert Uytterhoeven 3 months ago
The SND_SOC_STARFIVE Kconfig symbol was removed, but it is still enabled
in the RISC-V defconfig.  Just remove it, as it is no longer needed.

Fixes: acc317e5254a739e ("ASoC: starfive: Standardize ASoC menu")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/riscv/configs/defconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
index 37c98c0f98ffc0ee..82be92dd70dc29a8 100644
--- a/arch/riscv/configs/defconfig
+++ b/arch/riscv/configs/defconfig
@@ -191,7 +191,6 @@ CONFIG_SOUND=y
 CONFIG_SND=y
 CONFIG_SND_SOC=y
 CONFIG_SND_DESIGNWARE_I2S=m
-CONFIG_SND_SOC_STARFIVE=m
 CONFIG_SND_SOC_JH7110_PWMDAC=m
 CONFIG_SND_SOC_JH7110_TDM=m
 CONFIG_SND_SOC_WM8978=m
-- 
2.43.0
Re: [PATCH] riscv: defconfig: Remove CONFIG_SND_SOC_STARFIVE=m
Posted by Conor Dooley 3 months ago
From: Conor Dooley <conor.dooley@microchip.com>

On Tue, 08 Jul 2025 17:36:48 +0200, Geert Uytterhoeven wrote:
> The SND_SOC_STARFIVE Kconfig symbol was removed, but it is still enabled
> in the RISC-V defconfig.  Just remove it, as it is no longer needed.
> 
> 

As I mentioned to Palmer a few mins ago, I'll grab this along with a
couple other soc-related defconfig patches I have. (Apologies if this
goes out twice, I got a warning last time about a timeout, so ending again)

[1/1] riscv: defconfig: Remove CONFIG_SND_SOC_STARFIVE=m
      https://git.kernel.org/conor/c/493e9b085299

Thanks,
Conor.
Re: [PATCH] riscv: defconfig: Remove CONFIG_SND_SOC_STARFIVE=m
Posted by Geert Uytterhoeven 3 months ago
Hi Conor,

On Tue, 8 Jul 2025 at 18:49, Conor Dooley <conor@kernel.org> wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> On Tue, 08 Jul 2025 17:36:48 +0200, Geert Uytterhoeven wrote:
> > The SND_SOC_STARFIVE Kconfig symbol was removed, but it is still enabled
> > in the RISC-V defconfig.  Just remove it, as it is no longer needed.
>
> As I mentioned to Palmer a few mins ago, I'll grab this along with a
> couple other soc-related defconfig patches I have. (Apologies if this
> goes out twice, I got a warning last time about a timeout, so ending again)
>
> [1/1] riscv: defconfig: Remove CONFIG_SND_SOC_STARFIVE=m
>       https://git.kernel.org/conor/c/493e9b085299

Sorry, I forgot to mention that the commit my patch fixes is only in
the sound tree.  One other patch in the original series did include a
defconfig update for a  MIPS platform, so it may be more appropriate
for Mark to include it. Or just wait for v6.17 ;-)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Re: [PATCH] riscv: defconfig: Remove CONFIG_SND_SOC_STARFIVE=m
Posted by Conor Dooley 2 months, 4 weeks ago
On Wed, Jul 09, 2025 at 11:29:24AM +0200, Geert Uytterhoeven wrote:
> Hi Conor,
> 
> On Tue, 8 Jul 2025 at 18:49, Conor Dooley <conor@kernel.org> wrote:
> > From: Conor Dooley <conor.dooley@microchip.com>
> >
> > On Tue, 08 Jul 2025 17:36:48 +0200, Geert Uytterhoeven wrote:
> > > The SND_SOC_STARFIVE Kconfig symbol was removed, but it is still enabled
> > > in the RISC-V defconfig.  Just remove it, as it is no longer needed.
> >
> > As I mentioned to Palmer a few mins ago, I'll grab this along with a
> > couple other soc-related defconfig patches I have. (Apologies if this
> > goes out twice, I got a warning last time about a timeout, so ending again)
> >
> > [1/1] riscv: defconfig: Remove CONFIG_SND_SOC_STARFIVE=m
> >       https://git.kernel.org/conor/c/493e9b085299
> 
> Sorry, I forgot to mention that the commit my patch fixes is only in
> the sound tree.  One other patch in the original series did include a
> defconfig update for a  MIPS platform, so it may be more appropriate
> for Mark to include it. Or just wait for v6.17 ;-)

I was going to include it in 6.17 material, with the other soc-related
defconfig bits. I'll drop it if it's problematic of course.
Re: [PATCH] riscv: defconfig: Remove CONFIG_SND_SOC_STARFIVE=m
Posted by Palmer Dabbelt 3 months ago
On Tue, 08 Jul 2025 09:48:27 PDT (-0700), Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> On Tue, 08 Jul 2025 17:36:48 +0200, Geert Uytterhoeven wrote:
>> The SND_SOC_STARFIVE Kconfig symbol was removed, but it is still enabled
>> in the RISC-V defconfig.  Just remove it, as it is no longer needed.
>>
>>
>
> As I mentioned to Palmer a few mins ago, I'll grab this along with a
> couple other soc-related defconfig patches I have. (Apologies if this
> goes out twice, I got a warning last time about a timeout, so ending again)
>
> [1/1] riscv: defconfig: Remove CONFIG_SND_SOC_STARFIVE=m
>       https://git.kernel.org/conor/c/493e9b085299
>
> Thanks,
> Conor.

Ya, I think it's easiest to just keep these together.  So

Acked-by: Palmer Dabbelt <palmer@dabbelt.com>

in case anyone cares (I don't really care if it makes it to the commit).

Thanks!