1. Patchew
  2. linux
  3. View series

[PATCH] mtd: MTD_INTEL_DG should depend on DRM_I915 or DRM_XE

Geert Uytterhoeven posted 1 patch 2 months, 1 week ago
There is a newer version of this series
drivers/mtd/devices/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] mtd: MTD_INTEL_DG should depend on DRM_I915 or DRM_XE
Posted by Geert Uytterhoeven 2 months, 1 week ago 
Intel Discrete Graphics non-volatile memory is onlt present on intel
discrete graphics devices, and its auxiliary device is instantiated by
the Intel i915 and Xe2 DRM drivers.  Hence add dependencies on DRM_I915
and DRM_XE, to prevent asking the user about this driver when
configuring a kernel without Intel graphics support.

Fixes: ceb5ab3cb6463795 ("mtd: add driver for intel graphics non-volatile memory device")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/mtd/devices/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/devices/Kconfig b/drivers/mtd/devices/Kconfig
index 46cebde79f34b0b7..f0ab74d695347117 100644
--- a/drivers/mtd/devices/Kconfig
+++ b/drivers/mtd/devices/Kconfig
@@ -185,8 +185,8 @@ config MTD_POWERNV_FLASH
 
 config MTD_INTEL_DG
 	tristate "Intel Discrete Graphics non-volatile memory driver"
-	depends on AUXILIARY_BUS
-	depends on MTD
+	depends on AUXILIARY_BUS && MTD
+	depends on DRM_I915 || DRM_XE || COMPILE_TEST
 	help
 	  This provides an MTD device to access Intel Discrete Graphics
 	  non-volatile memory.
-- 
2.43.0
Re: [PATCH] mtd: MTD_INTEL_DG should depend on DRM_I915 or DRM_XE
Posted by Raag Jadav 2 months, 1 week ago 
On Wed, Jul 30, 2025 at 12:21:49PM +0200, Geert Uytterhoeven wrote:
> Intel Discrete Graphics non-volatile memory is onlt present on intel

only
Re: [PATCH] mtd: MTD_INTEL_DG should depend on DRM_I915 or DRM_XE
Posted by Jani Nikula 2 months, 1 week ago 
On Wed, 30 Jul 2025, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> Intel Discrete Graphics non-volatile memory is onlt present on intel
> discrete graphics devices, and its auxiliary device is instantiated by
> the Intel i915 and Xe2 DRM drivers.  Hence add dependencies on DRM_I915
> and DRM_XE, to prevent asking the user about this driver when
> configuring a kernel without Intel graphics support.
>
> Fixes: ceb5ab3cb6463795 ("mtd: add driver for intel graphics non-volatile memory device")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/mtd/devices/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/devices/Kconfig b/drivers/mtd/devices/Kconfig
> index 46cebde79f34b0b7..f0ab74d695347117 100644
> --- a/drivers/mtd/devices/Kconfig
> +++ b/drivers/mtd/devices/Kconfig
> @@ -185,8 +185,8 @@ config MTD_POWERNV_FLASH
>  
>  config MTD_INTEL_DG
>  	tristate "Intel Discrete Graphics non-volatile memory driver"
> -	depends on AUXILIARY_BUS
> -	depends on MTD
> +	depends on AUXILIARY_BUS && MTD
> +	depends on DRM_I915 || DRM_XE || COMPILE_TEST

I understand the intent, but IIUC auxiliary bus usage should not require
a "depends on" relationship. Couldn't you have MTD_INTEL_DG=y and
DRM_I915=m just fine?

BR,
Jani.


>  	help
>  	  This provides an MTD device to access Intel Discrete Graphics
>  	  non-volatile memory.

-- 
Jani Nikula, Intel
Re: [PATCH] mtd: MTD_INTEL_DG should depend on DRM_I915 or DRM_XE
Posted by Geert Uytterhoeven 2 months, 1 week ago 
Hi Jani,

On Wed, 30 Jul 2025 at 12:32, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Wed, 30 Jul 2025, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> > Intel Discrete Graphics non-volatile memory is onlt present on intel
> > discrete graphics devices, and its auxiliary device is instantiated by
> > the Intel i915 and Xe2 DRM drivers.  Hence add dependencies on DRM_I915
> > and DRM_XE, to prevent asking the user about this driver when
> > configuring a kernel without Intel graphics support.
> >
> > Fixes: ceb5ab3cb6463795 ("mtd: add driver for intel graphics non-volatile memory device")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> >  drivers/mtd/devices/Kconfig | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mtd/devices/Kconfig b/drivers/mtd/devices/Kconfig
> > index 46cebde79f34b0b7..f0ab74d695347117 100644
> > --- a/drivers/mtd/devices/Kconfig
> > +++ b/drivers/mtd/devices/Kconfig
> > @@ -185,8 +185,8 @@ config MTD_POWERNV_FLASH
> >
> >  config MTD_INTEL_DG
> >       tristate "Intel Discrete Graphics non-volatile memory driver"
> > -     depends on AUXILIARY_BUS
> > -     depends on MTD
> > +     depends on AUXILIARY_BUS && MTD
> > +     depends on DRM_I915 || DRM_XE || COMPILE_TEST
>
> I understand the intent, but IIUC auxiliary bus usage should not require
> a "depends on" relationship. Couldn't you have MTD_INTEL_DG=y and
> DRM_I915=m just fine?

That is indeed a good point!

What about

    depends on DRM_I915!=n || DRM_XE!=n || COMPILE_TEST

instead?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Re: [PATCH] mtd: MTD_INTEL_DG should depend on DRM_I915 or DRM_XE
Posted by Jani Nikula 2 months ago 
On Wed, 30 Jul 2025, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> Hi Jani,
>
> On Wed, 30 Jul 2025 at 12:32, Jani Nikula <jani.nikula@linux.intel.com> wrote:
>> On Wed, 30 Jul 2025, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
>> > Intel Discrete Graphics non-volatile memory is onlt present on intel
>> > discrete graphics devices, and its auxiliary device is instantiated by
>> > the Intel i915 and Xe2 DRM drivers.  Hence add dependencies on DRM_I915
>> > and DRM_XE, to prevent asking the user about this driver when
>> > configuring a kernel without Intel graphics support.
>> >
>> > Fixes: ceb5ab3cb6463795 ("mtd: add driver for intel graphics non-volatile memory device")
>> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> > ---
>> >  drivers/mtd/devices/Kconfig | 4 ++--
>> >  1 file changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/mtd/devices/Kconfig b/drivers/mtd/devices/Kconfig
>> > index 46cebde79f34b0b7..f0ab74d695347117 100644
>> > --- a/drivers/mtd/devices/Kconfig
>> > +++ b/drivers/mtd/devices/Kconfig
>> > @@ -185,8 +185,8 @@ config MTD_POWERNV_FLASH
>> >
>> >  config MTD_INTEL_DG
>> >       tristate "Intel Discrete Graphics non-volatile memory driver"
>> > -     depends on AUXILIARY_BUS
>> > -     depends on MTD
>> > +     depends on AUXILIARY_BUS && MTD
>> > +     depends on DRM_I915 || DRM_XE || COMPILE_TEST
>>
>> I understand the intent, but IIUC auxiliary bus usage should not require
>> a "depends on" relationship. Couldn't you have MTD_INTEL_DG=y and
>> DRM_I915=m just fine?
>
> That is indeed a good point!
>
> What about
>
>     depends on DRM_I915!=n || DRM_XE!=n || COMPILE_TEST
>
> instead?

Fine by me, up to Alexander.

BR,
Jani.



-- 
Jani Nikula, Intel
RE: [PATCH] mtd: MTD_INTEL_DG should depend on DRM_I915 or DRM_XE
Posted by Usyskin, Alexander 2 months ago 
> Subject: Re: [PATCH] mtd: MTD_INTEL_DG should depend on DRM_I915 or
> DRM_XE
> 
> On Wed, 30 Jul 2025, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > Hi Jani,
> >
> > On Wed, 30 Jul 2025 at 12:32, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> >> On Wed, 30 Jul 2025, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> >> > Intel Discrete Graphics non-volatile memory is onlt present on intel
> >> > discrete graphics devices, and its auxiliary device is instantiated by
> >> > the Intel i915 and Xe2 DRM drivers.  Hence add dependencies on DRM_I915
> >> > and DRM_XE, to prevent asking the user about this driver when
> >> > configuring a kernel without Intel graphics support.
> >> >
> >> > Fixes: ceb5ab3cb6463795 ("mtd: add driver for intel graphics non-volatile
> memory device")
> >> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >> > ---
> >> >  drivers/mtd/devices/Kconfig | 4 ++--
> >> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >> >
> >> > diff --git a/drivers/mtd/devices/Kconfig b/drivers/mtd/devices/Kconfig
> >> > index 46cebde79f34b0b7..f0ab74d695347117 100644
> >> > --- a/drivers/mtd/devices/Kconfig
> >> > +++ b/drivers/mtd/devices/Kconfig
> >> > @@ -185,8 +185,8 @@ config MTD_POWERNV_FLASH
> >> >
> >> >  config MTD_INTEL_DG
> >> >       tristate "Intel Discrete Graphics non-volatile memory driver"
> >> > -     depends on AUXILIARY_BUS
> >> > -     depends on MTD
> >> > +     depends on AUXILIARY_BUS && MTD
> >> > +     depends on DRM_I915 || DRM_XE || COMPILE_TEST
> >>
> >> I understand the intent, but IIUC auxiliary bus usage should not require
> >> a "depends on" relationship. Couldn't you have MTD_INTEL_DG=y and
> >> DRM_I915=m just fine?
> >
> > That is indeed a good point!
> >
> > What about
> >
> >     depends on DRM_I915!=n || DRM_XE!=n || COMPILE_TEST
> >
> > instead?
> 
> Fine by me, up to Alexander.

This variant is good from my side.

- - 
Thanks,
Sasha


> 
> BR,
> Jani.
> 
> 
> 
> --
> Jani Nikula, Intel

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.