mailbox: Improve RISCV_SBI_MPXY_MBOX guidance

[PATCH v2] mailbox: Improve RISCV_SBI_MPXY_MBOX guidance

Posted by Geert Uytterhoeven 3 weeks, 3 days ago

RISC-V SBI Message Proxy (MPXY) Mailbox support defaults to enabled, but
the help text states "If unsure say N".

Recommend enabling this driver, as it is a very critical RISC-V driver
providing mailbox channels to other drivers such as clock, system MSIs,
etc.

Fixes: bf3022a4eb119c6b ("mailbox: Add RISC-V SBI message proxy (MPXY) based mailbox driver")
Suggested-by: Anup Patel <anup@brainfault.org>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
This is v2 of "[PATCH] mailbox: RISCV_SBI_MPXY_MBOX should be disabled
by default".

v2:
  - Change the config description instead of changing to not enabled by
    default, as requested by Anup.
---
 drivers/mailbox/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
index e47cb68989267881..c27c1097db21be27 100644
--- a/drivers/mailbox/Kconfig
+++ b/drivers/mailbox/Kconfig
@@ -387,7 +387,7 @@ config RISCV_SBI_MPXY_MBOX
 	  Mailbox driver implementation for RISC-V SBI Message Proxy (MPXY)
 	  extension. This mailbox driver is used to send messages to the
 	  remote processor through the SBI implementation (M-mode firmware
-	  or HS-mode hypervisor). Say Y here if you want to have this support.
-	  If unsure say N.
+	  or HS-mode hypervisor). Say Y here, unless you are sure you do not
+	  need this.
 
 endif
-- 
2.43.0

Re: [PATCH v2] mailbox: Improve RISCV_SBI_MPXY_MBOX guidance

Posted by Jassi Brar 3 weeks ago

On Thu, Jan 15, 2026 at 8:19 AM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> RISC-V SBI Message Proxy (MPXY) Mailbox support defaults to enabled, but
> the help text states "If unsure say N".
>
> Recommend enabling this driver, as it is a very critical RISC-V driver
> providing mailbox channels to other drivers such as clock, system MSIs,
> etc.
>
> Fixes: bf3022a4eb119c6b ("mailbox: Add RISC-V SBI message proxy (MPXY) based mailbox driver")
> Suggested-by: Anup Patel <anup@brainfault.org>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> This is v2 of "[PATCH] mailbox: RISCV_SBI_MPXY_MBOX should be disabled
> by default".
>
> v2:
>   - Change the config description instead of changing to not enabled by
>     default, as requested by Anup.
> ---
>  drivers/mailbox/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
> index e47cb68989267881..c27c1097db21be27 100644
> --- a/drivers/mailbox/Kconfig
> +++ b/drivers/mailbox/Kconfig
> @@ -387,7 +387,7 @@ config RISCV_SBI_MPXY_MBOX
>           Mailbox driver implementation for RISC-V SBI Message Proxy (MPXY)
>           extension. This mailbox driver is used to send messages to the
>           remote processor through the SBI implementation (M-mode firmware
> -         or HS-mode hypervisor). Say Y here if you want to have this support.
> -         If unsure say N.
> +         or HS-mode hypervisor). Say Y here, unless you are sure you do not
> +         need this.
>
>  endif
> --
> 2.43.0
>
Applied to mailbox/for-next.
Thanks.

Re: [PATCH v2] mailbox: Improve RISCV_SBI_MPXY_MBOX guidance

Posted by Anup Patel 3 weeks, 3 days ago

On Thu, Jan 15, 2026 at 7:49 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> RISC-V SBI Message Proxy (MPXY) Mailbox support defaults to enabled, but
> the help text states "If unsure say N".
>
> Recommend enabling this driver, as it is a very critical RISC-V driver
> providing mailbox channels to other drivers such as clock, system MSIs,
> etc.
>
> Fixes: bf3022a4eb119c6b ("mailbox: Add RISC-V SBI message proxy (MPXY) based mailbox driver")
> Suggested-by: Anup Patel <anup@brainfault.org>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

LGTM.

Reviewed-by: Anup Patel <anup@brainfault.org>

Thanks,
Anup

> ---
> This is v2 of "[PATCH] mailbox: RISCV_SBI_MPXY_MBOX should be disabled
> by default".
>
> v2:
>   - Change the config description instead of changing to not enabled by
>     default, as requested by Anup.
> ---
>  drivers/mailbox/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
> index e47cb68989267881..c27c1097db21be27 100644
> --- a/drivers/mailbox/Kconfig
> +++ b/drivers/mailbox/Kconfig
> @@ -387,7 +387,7 @@ config RISCV_SBI_MPXY_MBOX
>           Mailbox driver implementation for RISC-V SBI Message Proxy (MPXY)
>           extension. This mailbox driver is used to send messages to the
>           remote processor through the SBI implementation (M-mode firmware
> -         or HS-mode hypervisor). Say Y here if you want to have this support.
> -         If unsure say N.
> +         or HS-mode hypervisor). Say Y here, unless you are sure you do not
> +         need this.
>
>  endif
> --
> 2.43.0
>