media: synopsys: VIDEO_DW_MIPI_CSI2RX should depend on ARCH_ROCKCHIP

[PATCH] media: synopsys: VIDEO_DW_MIPI_CSI2RX should depend on ARCH_ROCKCHIP

Posted by Geert Uytterhoeven 1 week, 5 days ago

The Synopsys DesignWare MIPI CSI-2 Receiver is currently only supported
on Rockchip RK3568 SoCs.  Hence add a dependency on ARCH_ROCKCHIP, to
prevent asking the user about this driver when configuring a kernel
without Rockchip platform support.

The dependency can be relaxed later, when adding support for appropriate
SoCs from other vendors (if any).

Fixes: 355a110040665e43 ("media: synopsys: add driver for the designware mipi csi-2 receiver")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/media/platform/synopsys/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/synopsys/Kconfig b/drivers/media/platform/synopsys/Kconfig
index e798ec00b1897560..8d0f5e3e8cd58eab 100644
--- a/drivers/media/platform/synopsys/Kconfig
+++ b/drivers/media/platform/synopsys/Kconfig
@@ -4,6 +4,7 @@ source "drivers/media/platform/synopsys/hdmirx/Kconfig"
 
 config VIDEO_DW_MIPI_CSI2RX
 	tristate "Synopsys DesignWare MIPI CSI-2 Receiver"
+	depends on ARCH_ROCKCHIP || COMPILE_TEST
 	depends on VIDEO_DEV
 	depends on V4L_PLATFORM_DRIVERS
 	depends on PM && COMMON_CLK
-- 
2.43.0

Re: [PATCH] media: synopsys: VIDEO_DW_MIPI_CSI2RX should depend on ARCH_ROCKCHIP

Posted by Michael Riesch 1 week, 5 days ago

Hi Geert,

Thanks for the patch!

On 1/27/26 20:10, Geert Uytterhoeven wrote:
> The Synopsys DesignWare MIPI CSI-2 Receiver is currently only supported
> on Rockchip RK3568 SoCs.  Hence add a dependency on ARCH_ROCKCHIP, to
> prevent asking the user about this driver when configuring a kernel
> without Rockchip platform support.
> 
> The dependency can be relaxed later, when adding support for appropriate
> SoCs from other vendors (if any).

No objections from my side. I kicked out exactly this line when I moved
the driver from rockchip to synopsys, as I thought there shouldn't be
any Rockchip-specific bits.

Cc: Frank (since he aims to build upon this driver IIRC)

> 
> Fixes: 355a110040665e43 ("media: synopsys: add driver for the designware mipi csi-2 receiver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

AFAIC:

Acked-by: Michael Riesch <michael.riesch@collabora.com>

Regards,
Michael

> ---
>  drivers/media/platform/synopsys/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/synopsys/Kconfig b/drivers/media/platform/synopsys/Kconfig
> index e798ec00b1897560..8d0f5e3e8cd58eab 100644
> --- a/drivers/media/platform/synopsys/Kconfig
> +++ b/drivers/media/platform/synopsys/Kconfig
> @@ -4,6 +4,7 @@ source "drivers/media/platform/synopsys/hdmirx/Kconfig"
>  
>  config VIDEO_DW_MIPI_CSI2RX
>  	tristate "Synopsys DesignWare MIPI CSI-2 Receiver"
> +	depends on ARCH_ROCKCHIP || COMPILE_TEST
>  	depends on VIDEO_DEV
>  	depends on V4L_PLATFORM_DRIVERS
>  	depends on PM && COMMON_CLK

Re: [PATCH] media: synopsys: VIDEO_DW_MIPI_CSI2RX should depend on ARCH_ROCKCHIP

Posted by Frank Li 1 week, 4 days ago

On Tue, Jan 27, 2026 at 08:24:57PM +0100, Michael Riesch wrote:
> Hi Geert,
>
> Thanks for the patch!
>
> On 1/27/26 20:10, Geert Uytterhoeven wrote:
> > The Synopsys DesignWare MIPI CSI-2 Receiver is currently only supported
> > on Rockchip RK3568 SoCs.  Hence add a dependency on ARCH_ROCKCHIP, to
> > prevent asking the user about this driver when configuring a kernel
> > without Rockchip platform support.
> >
> > The dependency can be relaxed later, when adding support for appropriate
> > SoCs from other vendors (if any).
>
> No objections from my side. I kicked out exactly this line when I moved
> the driver from rockchip to synopsys, as I thought there shouldn't be
> any Rockchip-specific bits.

It is fine now. We can change it when more vendor use it.

I remember I already provide review tag. Anyways.

Reviewed-by: Frank Li <Frank.Li@nxp.com>

Frank
>
> Cc: Frank (since he aims to build upon this driver IIRC)
>
> >
> > Fixes: 355a110040665e43 ("media: synopsys: add driver for the designware mipi csi-2 receiver")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> AFAIC:
>
> Acked-by: Michael Riesch <michael.riesch@collabora.com>
>
> Regards,
> Michael
>
> > ---
> >  drivers/media/platform/synopsys/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/media/platform/synopsys/Kconfig b/drivers/media/platform/synopsys/Kconfig
> > index e798ec00b1897560..8d0f5e3e8cd58eab 100644
> > --- a/drivers/media/platform/synopsys/Kconfig
> > +++ b/drivers/media/platform/synopsys/Kconfig
> > @@ -4,6 +4,7 @@ source "drivers/media/platform/synopsys/hdmirx/Kconfig"
> >
> >  config VIDEO_DW_MIPI_CSI2RX
> >  	tristate "Synopsys DesignWare MIPI CSI-2 Receiver"
> > +	depends on ARCH_ROCKCHIP || COMPILE_TEST
> >  	depends on VIDEO_DEV
> >  	depends on V4L_PLATFORM_DRIVERS
> >  	depends on PM && COMMON_CLK
>