arch/m68k/mac/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
People keep on sending (incorrect) patches to remove the second
occurrence of the word "in". Reword the comment to stop the inflood.
Suggested-by: Michael Schmitz <schmitzmic@gmail.com>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
To be queued in the m68k branch for v6.2.
arch/m68k/mac/misc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/m68k/mac/misc.c b/arch/m68k/mac/misc.c
index 4fab3479175865d4..c7cb29f0ff016360 100644
--- a/arch/m68k/mac/misc.c
+++ b/arch/m68k/mac/misc.c
@@ -126,7 +126,7 @@ static void via_rtc_send(__u8 data)
reg = via1[vBufB] & ~(VIA1B_vRTCClk | VIA1B_vRTCData);
- /* The bits of the byte go in in MSB order */
+ /* The bits of the byte go into the RTC in MSB order */
for (i = 0 ; i < 8 ; i++) {
bit = data & 0x80? 1 : 0;
--
2.25.1
On Fri, Oct 28, 2022 at 10:30:26AM +0200, Geert Uytterhoeven wrote: > People keep on sending (incorrect) patches to remove the second > occurrence of the word "in". Reword the comment to stop the inflood. > Ah! People who aren't fluent in English think that duplicated "in" below isn't OK, which after stripping that become nonsense without reading the actual code. > Suggested-by: Michael Schmitz <schmitzmic@gmail.com> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > To be queued in the m68k branch for v6.2. Should this patch be Cc: stable'ed so that no more trivial patches as you mentioned? > > arch/m68k/mac/misc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/m68k/mac/misc.c b/arch/m68k/mac/misc.c > index 4fab3479175865d4..c7cb29f0ff016360 100644 > --- a/arch/m68k/mac/misc.c > +++ b/arch/m68k/mac/misc.c > @@ -126,7 +126,7 @@ static void via_rtc_send(__u8 data) > > reg = via1[vBufB] & ~(VIA1B_vRTCClk | VIA1B_vRTCData); > > - /* The bits of the byte go in in MSB order */ > + /* The bits of the byte go into the RTC in MSB order */ > LGTM, thanks. Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com> -- An old man doll... just what I always wanted! - Clara
Hi Bagas,
On Fri, Oct 28, 2022 at 3:01 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
> On Fri, Oct 28, 2022 at 10:30:26AM +0200, Geert Uytterhoeven wrote:
> > People keep on sending (incorrect) patches to remove the second
> > occurrence of the word "in". Reword the comment to stop the inflood.
>
> Ah! People who aren't fluent in English think that duplicated "in" below
> isn't OK, which after stripping that become nonsense without reading the
> actual code.
>
> > Suggested-by: Michael Schmitz <schmitzmic@gmail.com>
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > ---
> > To be queued in the m68k branch for v6.2.
>
> Should this patch be Cc: stable'ed so that no more trivial patches as
> you mentioned?
People should not be sending patches against stable in the first place.
Once this makes it upstream, the inflow should stop (hopefully ;-)
> Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
© 2016 - 2026 Red Hat, Inc.