RE: [PATCH v1 00/14] extcon: Core cleanups and documentation fixes

Bumwoo Lee posted 14 patches 2 years, 10 months ago
Only 0 patches received!
There is a newer version of this series
RE: [PATCH v1 00/14] extcon: Core cleanups and documentation fixes
Posted by Bumwoo Lee 2 years, 10 months ago
Hi Andy Shevchenko
> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Thursday, March 30, 2023 7:12 PM
> To: Bumwoo Lee <bw365.lee@samsung.com>; linux-kernel@vger.kernel.org
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>; Chanwoo Choi
> <cw00.choi@samsung.com>
> Subject: Re: [PATCH v1 00/14] extcon: Core cleanups and documentation
> fixes
> 
> On Wed, Mar 22, 2023 at 04:39:51PM +0200, Andy Shevchenko wrote:
> > A few fixes to the documentation and some cleanups against extcon core
> > module.
> 
> Anything I should do with the series?
> Any comments on it?
> 
> --
> With Best Regards,
> Andy Shevchenko
> 

Looks fine to me.

Acked-by: Bumwoo Lee <bw365.lee@samsung.com>

MR. Chanwoo, Would you please take a look at this patch series.
Re: [PATCH v1 00/14] extcon: Core cleanups and documentation fixes
Posted by Chanwoo Choi 2 years, 10 months ago
Hi,

On 23. 3. 31. 09:48, Bumwoo Lee wrote:
> Hi Andy Shevchenko
>> -----Original Message-----
>> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> Sent: Thursday, March 30, 2023 7:12 PM
>> To: Bumwoo Lee <bw365.lee@samsung.com>; linux-kernel@vger.kernel.org
>> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>; Chanwoo Choi
>> <cw00.choi@samsung.com>
>> Subject: Re: [PATCH v1 00/14] extcon: Core cleanups and documentation
>> fixes
>>
>> On Wed, Mar 22, 2023 at 04:39:51PM +0200, Andy Shevchenko wrote:
>>> A few fixes to the documentation and some cleanups against extcon core
>>> module.
>>
>> Anything I should do with the series?
>> Any comments on it?
>>
>> --
>> With Best Regards,
>> Andy Shevchenko
>>
> 
> Looks fine to me.
> 
> Acked-by: Bumwoo Lee <bw365.lee@samsung.com>
> 
> MR. Chanwoo, Would you please take a look at this patch series.
> 

Actually, Acked tag will be replied by Maintainer or the driver owner.
If you want to review the mailing list patch, I think that Reviewed-by tag is proper.

Unfortunately, I could not see the any review comment from you even if this patchset
have the some review contents. Also you didn't review the any patches of extcon before.

I'm always welcome for many reviewers in order to improve the linux kernel.
But, in this case, I'm not sure that you are reviewing this patchset.

So that I'm sorry that I cannot take your acked-tag. 

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi
Re: [PATCH v1 00/14] extcon: Core cleanups and documentation fixes
Posted by 'Andy Shevchenko' 2 years, 10 months ago
On Thu, Apr 06, 2023 at 08:17:19AM +0900, Chanwoo Choi wrote:
> On 23. 3. 31. 09:48, Bumwoo Lee wrote:

...

> > Looks fine to me.
> > 
> > Acked-by: Bumwoo Lee <bw365.lee@samsung.com>
> > 
> > MR. Chanwoo, Would you please take a look at this patch series.
> 
> Actually, Acked tag will be replied by Maintainer or the driver owner.  If
> you want to review the mailing list patch, I think that Reviewed-by tag is
> proper.
> 
> Unfortunately, I could not see the any review comment from you even if this
> patchset have the some review contents. Also you didn't review the any
> patches of extcon before.
> 
> I'm always welcome for many reviewers in order to improve the linux kernel.
> But, in this case, I'm not sure that you are reviewing this patchset.
> 
> So that I'm sorry that I cannot take your acked-tag. 

I probably need to update this in the v3 of the rest of the patches I have sent
as v2. Btw, can you review those before, so if any comments I can address in
v3?

-- 
With Best Regards,
Andy Shevchenko
RE: [PATCH v1 00/14] extcon: Core cleanups and documentation fixes
Posted by Bumwoo Lee 2 years, 10 months ago
Hi

> -----Original Message-----
> From: Chanwoo Choi <cwchoi00@gmail.com>
> Sent: Thursday, April 6, 2023 8:17 AM
> To: Bumwoo Lee <bw365.lee@samsung.com>; 'Andy Shevchenko'
> <andriy.shevchenko@linux.intel.com>; linux-kernel@vger.kernel.org
> Cc: 'MyungJoo Ham' <myungjoo.ham@samsung.com>; 'Chanwoo Choi'
> <cw00.choi@samsung.com>
> Subject: Re: [PATCH v1 00/14] extcon: Core cleanups and documentation
> fixes
> 
> Hi,
> 
> On 23. 3. 31. 09:48, Bumwoo Lee wrote:
> > Hi Andy Shevchenko
> >> -----Original Message-----
> >> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >> Sent: Thursday, March 30, 2023 7:12 PM
> >> To: Bumwoo Lee <bw365.lee@samsung.com>; linux-kernel@vger.kernel.org
> >> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>; Chanwoo Choi
> >> <cw00.choi@samsung.com>
> >> Subject: Re: [PATCH v1 00/14] extcon: Core cleanups and documentation
> >> fixes
> >>
> >> On Wed, Mar 22, 2023 at 04:39:51PM +0200, Andy Shevchenko wrote:
> >>> A few fixes to the documentation and some cleanups against extcon
> >>> core module.
> >>
> >> Anything I should do with the series?
> >> Any comments on it?
> >>
> >> --
> >> With Best Regards,
> >> Andy Shevchenko
> >>
> >
> > Looks fine to me.
> >
> > Acked-by: Bumwoo Lee <bw365.lee@samsung.com>
> >
> > MR. Chanwoo, Would you please take a look at this patch series.
> >
> 
> Actually, Acked tag will be replied by Maintainer or the driver owner.
> If you want to review the mailing list patch, I think that Reviewed-by tag
> is proper.
> 

OK.
Thank you for your detail guidance. I will follow this guidance on next time.

> Unfortunately, I could not see the any review comment from you even if
> this patchset have the some review contents. Also you didn't review the
> any patches of extcon before.
> 
> I'm always welcome for many reviewers in order to improve the linux kernel.
> But, in this case, I'm not sure that you are reviewing this patchset.
> 
> So that I'm sorry that I cannot take your acked-tag.
> 

I agree your comment.
Thank you~

> --
> Best Regards,
> Samsung Electronics
> Chanwoo Choi