[PATCH v8 00/10] Add support for TI TPS65224 PMIC

Bhargav Raviprakash posted 10 patches 2 weeks, 2 days ago
.../devicetree/bindings/mfd/ti,tps6594.yaml   |   1 +
arch/arm64/boot/dts/ti/k3-am62p5-sk.dts       |  95 +++++
drivers/mfd/tps6594-core.c                    | 253 +++++++++++--
drivers/mfd/tps6594-i2c.c                     |  20 +-
drivers/mfd/tps6594-spi.c                     |  20 +-
drivers/misc/tps6594-pfsm.c                   |  48 ++-
drivers/pinctrl/pinctrl-tps6594.c             | 277 +++++++++++---
drivers/regulator/Kconfig                     |   4 +-
drivers/regulator/tps6594-regulator.c         | 334 +++++++++++++----
include/linux/mfd/tps6594.h                   | 351 +++++++++++++++++-
10 files changed, 1215 insertions(+), 188 deletions(-)
[PATCH v8 00/10] Add support for TI TPS65224 PMIC
Posted by Bhargav Raviprakash 2 weeks, 2 days ago
This series modifies the existing TPS6594 drivers to add support for the
TPS65224 PMIC device that is a derivative of TPS6594. TPS65224 has a
similar register map to TPS6594 with a few differences. SPI, I2C, ESM,
PFSM, Regulators and GPIO features overlap between the two devices.

TPS65224 is a Power Management IC (PMIC) which provides regulators and
other features like GPIOs, Watchdog, Error Signal Monitor (ESM) and
Pre-configurable Finite State Machine (PFSM). The SoC and the PMIC can
communicate through the I2C or SPI interfaces. The PMIC TPS65224
additionally has a 12-bit ADC.
Data Sheet for TPS65224: https://www.ti.com/product/TPS65224-Q1

Driver re-use is applied following the advice of the following series:
https://lore.kernel.org/lkml/2f467b0a-1d11-4ec7-8ca6-6c4ba66e5887@baylibre.com/

The features implemented in this series are:
- TPS65224 Register definitions
- Core (MFD I2C and SPI entry points)
- PFSM	
- Regulators
- Pinctrl

TPS65224 Register definitions:
This patch adds macros for register field definitions of TPS65224
to the existing TPS6594 driver.  

Core description:
I2C and SPI interface protocols are implemented, with and without
the bit-integrity error detection feature (CRC mode).

PFSM description:
Strictly speaking, PFSM is not hardware. It is a piece of code.
PMIC integrates a state machine which manages operational modes.
Depending on the current operational mode, some voltage domains
remain energized while others can be off.
PFSM driver can be used to trigger transitions between configured
states.

Regulators description:
4 BUCKs and 3 LDOs.
BUCK12 can be used in dual-phase mode.

Pinctrl description:
TPS65224 family has 6 GPIOs. Those GPIOs can also serve different
functions such as I2C or SPI interface or watchdog disable functions.
The driver provides both pinmuxing for the functions and GPIO capability.

This series was tested on linux-next tag: next-20240118

Test logs can be found here:
https://gist.github.com/LeonardMH/58ec135921fb1062ffd4a8b384831eb0

Changelog v7 -> v8:
- Refactoring regulator driver

Bhargav Raviprakash (7):
  mfd: tps6594: use volatile_table instead of volatile_reg
  dt-bindings: mfd: ti,tps6594: Add TI TPS65224 PMIC
  mfd: tps6594-i2c: Add TI TPS65224 PMIC I2C
  mfd: tps6594-spi: Add TI TPS65224 PMIC SPI
  mfd: tps6594-core: Add TI TPS65224 PMIC core
  misc: tps6594-pfsm: Add TI TPS65224 PMIC PFSM
  arch: arm64: dts: ti: k3-am62p5-sk: Add TPS65224 PMIC support in AM62P
    dts

Nirmala Devi Mal Nadar (3):
  mfd: tps6594: Add register definitions for TI TPS65224 PMIC
  regulator: tps6594-regulator: Add TI TPS65224 PMIC regulators
  pinctrl: pinctrl-tps6594: Add TPS65224 PMIC pinctrl and GPIO

 .../devicetree/bindings/mfd/ti,tps6594.yaml   |   1 +
 arch/arm64/boot/dts/ti/k3-am62p5-sk.dts       |  95 +++++
 drivers/mfd/tps6594-core.c                    | 253 +++++++++++--
 drivers/mfd/tps6594-i2c.c                     |  20 +-
 drivers/mfd/tps6594-spi.c                     |  20 +-
 drivers/misc/tps6594-pfsm.c                   |  48 ++-
 drivers/pinctrl/pinctrl-tps6594.c             | 277 +++++++++++---
 drivers/regulator/Kconfig                     |   4 +-
 drivers/regulator/tps6594-regulator.c         | 334 +++++++++++++----
 include/linux/mfd/tps6594.h                   | 351 +++++++++++++++++-
 10 files changed, 1215 insertions(+), 188 deletions(-)


base-commit: 2863b714f3ad0a9686f2de1b779228ad8c7a8052
-- 
2.25.1
Re: (subset) [PATCH v8 00/10] Add support for TI TPS65224 PMIC
Posted by Lee Jones 1 week, 6 days ago
On Tue, 30 Apr 2024 13:14:49 +0000, Bhargav Raviprakash wrote:
> This series modifies the existing TPS6594 drivers to add support for the
> TPS65224 PMIC device that is a derivative of TPS6594. TPS65224 has a
> similar register map to TPS6594 with a few differences. SPI, I2C, ESM,
> PFSM, Regulators and GPIO features overlap between the two devices.
> 
> TPS65224 is a Power Management IC (PMIC) which provides regulators and
> other features like GPIOs, Watchdog, Error Signal Monitor (ESM) and
> Pre-configurable Finite State Machine (PFSM). The SoC and the PMIC can
> communicate through the I2C or SPI interfaces. The PMIC TPS65224
> additionally has a 12-bit ADC.
> Data Sheet for TPS65224: https://www.ti.com/product/TPS65224-Q1
> 
> [...]

Applied, thanks!

[01/10] mfd: tps6594: Add register definitions for TI TPS65224 PMIC
        commit: 84ccfaee29fe46e305244a69c4471e83629ad5d1
[02/10] mfd: tps6594: use volatile_table instead of volatile_reg
        commit: 436250638b6d8e6cf8dceed82cdbbfc90ce3a775
[03/10] dt-bindings: mfd: ti,tps6594: Add TI TPS65224 PMIC
        commit: 91fbd800649f62bcc6a002ae9e0c0b6b5bb3f0d0
[04/10] mfd: tps6594-i2c: Add TI TPS65224 PMIC I2C
        commit: f8e5fc60e6666b46ce113b6b6de221ebba88668f
[05/10] mfd: tps6594-spi: Add TI TPS65224 PMIC SPI
        commit: 02716864fd5a53e057dcecdb36c807be6494120c
[06/10] mfd: tps6594-core: Add TI TPS65224 PMIC core
        commit: 9d855b8144e6016357eecdd9b3fe7cf8c61a1de3
[07/10] misc: tps6594-pfsm: Add TI TPS65224 PMIC PFSM
        commit: 91020aecc8136174429d41a6dae3de7cf39f8000
[08/10] regulator: tps6594-regulator: Add TI TPS65224 PMIC regulators
        commit: 00c826525fbae0230f6c3e9879e56d50267deb42
[09/10] pinctrl: pinctrl-tps6594: Add TPS65224 PMIC pinctrl and GPIO
        commit: 2088297159178ffc7c695fa34a7a88707371927d

--
Lee Jones [李琼斯]

[GIT PULL] Immutable branch between MFD, Misc, Pinctrl and Regulator due for the v6.10 merge window
Posted by Lee Jones 6 days, 14 hours ago
Enjoy!

The following changes since commit 4cece764965020c22cff7665b18a012006359095:

  Linux 6.9-rc1 (2024-03-24 14:10:05 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-misc-pinctrl-regulator-v6.10

for you to fetch changes up to 2088297159178ffc7c695fa34a7a88707371927d:

  pinctrl: pinctrl-tps6594: Add TPS65224 PMIC pinctrl and GPIO (2024-05-03 10:07:11 +0100)

----------------------------------------------------------------
Immutable branch between MFD, Misc, Pinctrl and Regulator due for the v6.10 merge window

----------------------------------------------------------------
Bhargav Raviprakash (6):
      mfd: tps6594: Use volatile_table instead of volatile_reg
      dt-bindings: mfd: ti,tps6594: Add TI TPS65224 PMIC
      mfd: tps6594-i2c: Add TI TPS65224 PMIC I2C
      mfd: tps6594-spi: Add TI TPS65224 PMIC SPI
      mfd: tps6594-core: Add TI TPS65224 PMIC core
      misc: tps6594-pfsm: Add TI TPS65224 PMIC PFSM

Nirmala Devi Mal Nadar (3):
      mfd: tps6594: Add register definitions for TI TPS65224 PMIC
      regulator: tps6594-regulator: Add TI TPS65224 PMIC regulators
      pinctrl: pinctrl-tps6594: Add TPS65224 PMIC pinctrl and GPIO

 .../devicetree/bindings/mfd/ti,tps6594.yaml        |   1 +
 drivers/mfd/tps6594-core.c                         | 253 +++++++++++++--
 drivers/mfd/tps6594-i2c.c                          |  20 +-
 drivers/mfd/tps6594-spi.c                          |  20 +-
 drivers/misc/tps6594-pfsm.c                        |  48 ++-
 drivers/pinctrl/pinctrl-tps6594.c                  | 277 +++++++++++++---
 drivers/regulator/Kconfig                          |   4 +-
 drivers/regulator/tps6594-regulator.c              | 334 ++++++++++++++++----
 include/linux/mfd/tps6594.h                        | 351 ++++++++++++++++++++-
 9 files changed, 1120 insertions(+), 188 deletions(-)

-- 
Lee Jones [李琼斯]
Re: (subset) [PATCH v8 00/10] Add support for TI TPS65224 PMIC
Posted by Lee Jones 1 week, 6 days ago
On Fri, 03 May 2024, Lee Jones wrote:

> On Tue, 30 Apr 2024 13:14:49 +0000, Bhargav Raviprakash wrote:
> > This series modifies the existing TPS6594 drivers to add support for the
> > TPS65224 PMIC device that is a derivative of TPS6594. TPS65224 has a
> > similar register map to TPS6594 with a few differences. SPI, I2C, ESM,
> > PFSM, Regulators and GPIO features overlap between the two devices.
> > 
> > TPS65224 is a Power Management IC (PMIC) which provides regulators and
> > other features like GPIOs, Watchdog, Error Signal Monitor (ESM) and
> > Pre-configurable Finite State Machine (PFSM). The SoC and the PMIC can
> > communicate through the I2C or SPI interfaces. The PMIC TPS65224
> > additionally has a 12-bit ADC.
> > Data Sheet for TPS65224: https://www.ti.com/product/TPS65224-Q1
> > 
> > [...]
> 
> Applied, thanks!
> 
> [01/10] mfd: tps6594: Add register definitions for TI TPS65224 PMIC
>         commit: 84ccfaee29fe46e305244a69c4471e83629ad5d1
> [02/10] mfd: tps6594: use volatile_table instead of volatile_reg
>         commit: 436250638b6d8e6cf8dceed82cdbbfc90ce3a775
> [03/10] dt-bindings: mfd: ti,tps6594: Add TI TPS65224 PMIC
>         commit: 91fbd800649f62bcc6a002ae9e0c0b6b5bb3f0d0
> [04/10] mfd: tps6594-i2c: Add TI TPS65224 PMIC I2C
>         commit: f8e5fc60e6666b46ce113b6b6de221ebba88668f
> [05/10] mfd: tps6594-spi: Add TI TPS65224 PMIC SPI
>         commit: 02716864fd5a53e057dcecdb36c807be6494120c
> [06/10] mfd: tps6594-core: Add TI TPS65224 PMIC core
>         commit: 9d855b8144e6016357eecdd9b3fe7cf8c61a1de3
> [07/10] misc: tps6594-pfsm: Add TI TPS65224 PMIC PFSM
>         commit: 91020aecc8136174429d41a6dae3de7cf39f8000
> [08/10] regulator: tps6594-regulator: Add TI TPS65224 PMIC regulators
>         commit: 00c826525fbae0230f6c3e9879e56d50267deb42
> [09/10] pinctrl: pinctrl-tps6594: Add TPS65224 PMIC pinctrl and GPIO
>         commit: 2088297159178ffc7c695fa34a7a88707371927d

Submitted for build testing.

If it passes, I'll send out a PR for other maintainers to pull from.

-- 
Lee Jones [李琼斯]