RE: [PATCH 0/3] Add and enable USB nodes for ExynosAutov920 SoC

Pritam Manohar Sutar posted 3 patches 2 weeks, 2 days ago
Only 0 patches received!
There is a newer version of this series
RE: [PATCH 0/3] Add and enable USB nodes for ExynosAutov920 SoC
Posted by Pritam Manohar Sutar 2 weeks, 2 days ago
Hi All, 

> -----Original Message-----
> From: Pritam Manohar Sutar <pritam.sutar@samsung.com>
> Sent: 24 October 2025 05:19 PM
> To: robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org;
> alim.akhtar@samsung.com
> Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org;
> rosa.pila@samsung.com; dev.tailor@samsung.com; faraz.ata@samsung.com;
> muhammed.ali@samsung.com; selvarasu.g@samsung.com;
> pritam.sutar@samsung.com
> Subject: [PATCH 0/3] Add and enable USB nodes for ExynosAutov920 SoC
> 
> This SoC has 2 USB typeC and 2 typeA ports those are DWC3 DRD controllers and
> amoung them, one is USB3.1 DRD combo phy and three
> USB2.0 phy controllers. This patchset adds and enables USB and USB-PHY nodes
> in dts.
> 
> PMIC driver is not implmented yet, we rely on USB LDOs being enabled by the
> bootloader and used dummy regulators for now.
> 
> To drive vbus for host mode, it needs GPIO pin to enable vbus regulator.
> GPIO expander is present in the dts, we used it to enable the vbus regulator
> using GPIO.
> 
> USB ports are configured as OTG, and default mode is configured as peripheral.
> These configurations might be changed based on requirements.
> 
> This patchset has dependancy on schema and driver implementation[1] and role
> switch control from userspace[2] patches.
> [1]: https://lore.kernel.org/linux-phy/20251010070912.3758334-1-
> pritam.sutar@samsung.com/
> [2]: https://lore.kernel.org/linux-usb/20251024085455.789555-1-
> pritam.sutar@samsung.com/

Above dependent patches are merged, can you please review the patchset? 

> 
> Pritam Manohar Sutar (3):
>   arm64: dts: exynos: ExynosAutov920: Add USB and USB-phy nodes
>   arm64: dts: exynos: ExynosAutov920: Add regulators for the USB
>   arm64: dts: exynos: ExynosAutov920: Enable USB nodes
> 
>  .../boot/dts/exynos/exynosautov920-sadk.dts   | 160 +++++++++++++++++
>  .../arm64/boot/dts/exynos/exynosautov920.dtsi | 162 ++++++++++++++++++
>  2 files changed, 322 insertions(+)
> 
> --
> 2.34.1

Thank you, 

Regards,
Pritam 
Re: [PATCH 0/3] Add and enable USB nodes for ExynosAutov920 SoC
Posted by Krzysztof Kozlowski 2 weeks, 2 days ago
On 22/01/2026 11:31, Pritam Manohar Sutar wrote:
> Hi All, 
> 
>> -----Original Message-----
>> From: Pritam Manohar Sutar <pritam.sutar@samsung.com>
>> Sent: 24 October 2025 05:19 PM
>> To: robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org;
>> alim.akhtar@samsung.com
>> Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
>> samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org;
>> rosa.pila@samsung.com; dev.tailor@samsung.com; faraz.ata@samsung.com;
>> muhammed.ali@samsung.com; selvarasu.g@samsung.com;
>> pritam.sutar@samsung.com
>> Subject: [PATCH 0/3] Add and enable USB nodes for ExynosAutov920 SoC
>>
>> This SoC has 2 USB typeC and 2 typeA ports those are DWC3 DRD controllers and
>> amoung them, one is USB3.1 DRD combo phy and three
>> USB2.0 phy controllers. This patchset adds and enables USB and USB-PHY nodes
>> in dts.
>>
>> PMIC driver is not implmented yet, we rely on USB LDOs being enabled by the
>> bootloader and used dummy regulators for now.
>>
>> To drive vbus for host mode, it needs GPIO pin to enable vbus regulator.
>> GPIO expander is present in the dts, we used it to enable the vbus regulator
>> using GPIO.
>>
>> USB ports are configured as OTG, and default mode is configured as peripheral.
>> These configurations might be changed based on requirements.
>>
>> This patchset has dependancy on schema and driver implementation[1] and role
>> switch control from userspace[2] patches.
>> [1]: https://lore.kernel.org/linux-phy/20251010070912.3758334-1-
>> pritam.sutar@samsung.com/
>> [2]: https://lore.kernel.org/linux-usb/20251024085455.789555-1-
>> pritam.sutar@samsung.com/

This wasn't even a dependency...

> 
> Above dependent patches are merged, can you please review the patchset? 

I closed my tree few days ago, so next cycle, but please resend, because
this is three months old now. I dropped it from my queue long time ago.

Best regards,
Krzysztof
RE: [PATCH 0/3] Add and enable USB nodes for ExynosAutov920 SoC
Posted by Pritam Manohar Sutar 2 weeks, 2 days ago
Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 22 January 2026 04:10 PM
> To: Pritam Manohar Sutar <pritam.sutar@samsung.com>; robh@kernel.org;
> krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com
> Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org;
> rosa.pila@samsung.com; dev.tailor@samsung.com; faraz.ata@samsung.com;
> muhammed.ali@samsung.com; selvarasu.g@samsung.com
> Subject: Re: [PATCH 0/3] Add and enable USB nodes for ExynosAutov920 SoC
> 
> On 22/01/2026 11:31, Pritam Manohar Sutar wrote:
> > Hi All,
> >
> >> -----Original Message-----
> >> From: Pritam Manohar Sutar <pritam.sutar@samsung.com>
> >> Sent: 24 October 2025 05:19 PM
> >> To: robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org;
> >> alim.akhtar@samsung.com
> >> Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> >> linux- samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org;
> >> rosa.pila@samsung.com; dev.tailor@samsung.com;
> faraz.ata@samsung.com;
> >> muhammed.ali@samsung.com; selvarasu.g@samsung.com;
> >> pritam.sutar@samsung.com
> >> Subject: [PATCH 0/3] Add and enable USB nodes for ExynosAutov920 SoC
> >>
> >> This SoC has 2 USB typeC and 2 typeA ports those are DWC3 DRD
> >> controllers and amoung them, one is USB3.1 DRD combo phy and three
> >> USB2.0 phy controllers. This patchset adds and enables USB and
> >> USB-PHY nodes in dts.
> >>
> >> PMIC driver is not implmented yet, we rely on USB LDOs being enabled
> >> by the bootloader and used dummy regulators for now.
> >>
> >> To drive vbus for host mode, it needs GPIO pin to enable vbus regulator.
> >> GPIO expander is present in the dts, we used it to enable the vbus
> >> regulator using GPIO.
> >>
> >> USB ports are configured as OTG, and default mode is configured as
> peripheral.
> >> These configurations might be changed based on requirements.
> >>
> >> This patchset has dependancy on schema and driver implementation[1]
> >> and role switch control from userspace[2] patches.
> >> [1]: https://lore.kernel.org/linux-phy/20251010070912.3758334-1-
> >> pritam.sutar@samsung.com/
> >> [2]: https://lore.kernel.org/linux-usb/20251024085455.789555-1-
> >> pritam.sutar@samsung.com/
> 
> This wasn't even a dependency...
> 
> >
> > Above dependent patches are merged, can you please review the patchset?
> 
> I closed my tree few days ago, so next cycle, but please resend, because this is
> three months old now. I dropped it from my queue long time ago.

Noted and resent same patch series as v2 patchset. 
Link for v2: https://lore.kernel.org/linux-devicetree/20260122130721.205664-1-pritam.sutar@samsung.com/

> 
> Best regards,
> Krzysztof

Thank you.

Regards,
Pritam