[PATCH 0/3] tools: address recently reported Coverity issues

Jan Beulich posted 3 patches 1 year, 8 months ago
Failed in applying to current master (apply log)
[PATCH 0/3] tools: address recently reported Coverity issues
Posted by Jan Beulich 1 year, 8 months ago
Three of the four reported issues a pretty clear how to take care
of, which is done in this series. The 4th, CID 1509375, isn't as
obvious, mainly because I don't know enough about Coverity to be
able to tell whether adding a cast there might help; the issue
reported for xenbaked suggests it wouldn't. The alternative I can
see would be an arch-independent piece of inline assembly, hiding
the transformation from time_t to int from the analysis tool. But
I'm not convinced such would be liked. Nor am I sure the can be
fully arch-ignorant, as time_t potentially being a 64-bit type
might not be possible to match with an "r" constraint on all 32-
bit architectures. So maybe what's left is memcpy() from a
"time_t" variable to an "int" one ...

1: xenbaked: properly use time_t in dump_stats()
2: console/client: properly use time_t in get_pty_fd()
3: libxl: use time_t for qmp_synchronous_send()'s last parameter

Jan