From nobody Fri May 17 18:38:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1660831569; cv=pass; d=zohomail.com; s=zohoarc; b=APEm5p8c3pzXQ0SnpUyRuKYaVfT5ZtHjD+W7iNOmuP7rbnMDBb6EAyAk2gjwYtOdwve2YuMWRRKkfldxirYj94Q+0FmysPiFzGiH0xjUVPEWu/KW+g27nmx5FmYARDhXWzTiQTNO6SXasoi78HVBgfXZcfTFAXvfTii5HxLv6Ck= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660831569; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ikzkcZ37zHqRA4Dqg0pshN1gxxIDaS6qACe6NnbT6Qk=; b=M/BOzue7t5MmIK3lD9R0P+CpkraI4QS50n89uRfwJcalKyb1jFdl/MjPH2kDJc9LfK+Z/PLETY897pBfdIUOrbeGQp3yfLUNniRCF9YgXaFMSVvVYTQK2Hp/YmkJ/C97EayhEByJjH9snkcMPZhmo966p5j/uzOKLH9zbwkWwHw= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1660831569449791.6795803148359; Thu, 18 Aug 2022 07:06:09 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.389569.626578 (Exim 4.92) (envelope-from ) id 1oOg9X-000199-4y; Thu, 18 Aug 2022 14:05:43 +0000 Received: by outflank-mailman (output) from mailman id 389569.626578; Thu, 18 Aug 2022 14:05:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oOg9X-000192-1D; Thu, 18 Aug 2022 14:05:43 +0000 Received: by outflank-mailman (input) for mailman id 389569; Thu, 18 Aug 2022 14:05:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oOg9W-000100-EC for xen-devel@lists.xenproject.org; Thu, 18 Aug 2022 14:05:42 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00077.outbound.protection.outlook.com [40.107.0.77]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d80d2d95-1efe-11ed-bd2e-47488cf2e6aa; Thu, 18 Aug 2022 16:05:41 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5604.eurprd04.prod.outlook.com (2603:10a6:208:134::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.16; Thu, 18 Aug 2022 14:05:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad%4]) with mapi id 15.20.5525.010; Thu, 18 Aug 2022 14:05:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d80d2d95-1efe-11ed-bd2e-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ja7fNlj6APz6aoc3bsYXpBkJccaGpTRFgpUx7arLTOFFHrTSi2pnmy2/9Fvmzaak7qA1wai7gE5/69SxsfzCVrI0rxKm3PBAo+SRIIK97Mx6wJxM5tghgh4v9VSPtPSy2LXbDxA/EmAMeLDYxari4TDDC7a3/4HUvkbo1j0io2Y9ZJ+/NGIxvok3KoknGWtNJ74gGfaDZoYao5kKtYJOuDZU05x/k4tTurW/jZfzi5V4rYu9cnctO+j617kvpEunnIIvRXxO3CbGp59hwX4IW44Il7dOtyYqwyc20wxfkXXp7ScBMFzxMeXYpn28/apUF989YCXd4aqvnDmI8dNhsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ikzkcZ37zHqRA4Dqg0pshN1gxxIDaS6qACe6NnbT6Qk=; b=AIN7gmgZOpPgJUq94pOgGKuqkUmbKz0clooKrCLSNQuRhxZLKTTJv8IQENxuC6vSIDfrnzbCMIwBInLmSJi4gux1XeQe9I5kD8FObyW8f70OkJD9+P85Ye2/QHGRINKELk2jJpxySTZqBiz19U7Q/rOQnicLPWaYqLdR+wE/cUC+63Mik530t7sUga/kzKPQQE6BDfyUZE+ILMVPN+XYBBTSM2XuLQbiaqI482Vdl8fO6zeJM2bUiqeCbvlb+FuRxc4Dq9XHFnZD8seAL1U0Ua/8E7uOBtulBtiz9/JoMwsO98CDRHN6MLb1J6ur+9vU2DSJfk8TUUIrGltxGc422g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ikzkcZ37zHqRA4Dqg0pshN1gxxIDaS6qACe6NnbT6Qk=; b=0t3wKKetX/kuq9fcERq5F8KTAVPsHbn1SWFX1442HVQCaSGTbKa3cFFRcY9bgdh7PVSXpC8horB0Rg5KRsAcTMy2LrHDp9Bi9SmTyAunEp4CUn9k6EGgyZ5wCpWSTEAi9EmPWLcIPsBojgdYDgN/ywrAl/P9ZkGv4WzT0pMIJt+Mh+Cg0qlEIorwZL86K+4CL0cscP07/8BK4HsDvv9IJNClGVDBDfXNQTH0eYlp/NAHbMRqLLGEkoNkIr0QS/X1sRajfKgxIWwPnOWqwyMRTYybZNPAqbVhM+jOmf1dodJEJnbO/JlhVVRmjvWSuM3Vv4sYfScj+5m65R9j9URRXw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 18 Aug 2022 16:05:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: [PATCH 1/3] xenbaked: properly use time_t in dump_stats() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Wei Liu References: <68e71e3b-19a7-e062-9ebe-2e6f6aae0549@suse.com> In-Reply-To: <68e71e3b-19a7-e062-9ebe-2e6f6aae0549@suse.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR3P281CA0160.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8aedc4d8-1299-4787-a838-08da8122bb11 X-MS-TrafficTypeDiagnostic: AM0PR04MB5604:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mzAYTQScDSjo5k/IOVn3WJgRyAe0W8q7jw6b7ouD3ALBcegZRiwNOraNghH6lPUwNJLVvGESVQHnDD5E18ky9f+/+ECaiCdrkDNIozlS+jl7XWNKOH6kmqTJvfN3qTPPIdnkYbvwVOl/754O8px876KNLkT6vrth6HeqwVqfk5dCvmIVbTwVtESimTKz8SIHkqIszJY84tTjXc+99gyBC0Fz//wKqzx4E0QJ/xvdxkNXb9+kSoXBh9AlMni5BE7BvG5v2+SbOtcsYRJDFHh6p9ECWnHBsa9y9eobtkLYfHqdyhsrMIys9/7ByuXlpSccBnDz1acTJNA7JU3AqrwFW/dW/w7JYPQWLAc1dHBXAJ9fGPZrjDDL24oUcTy+5QmfY5PdGp7euFDSjtRpZWirfIPUYruMfoHxnLs8C1RXWDcwjbVF5tlyZ4FHD0D7bJOn7vSteCbTPA3nA9/fKO0HOiSqVimnL4r3sIoAJWR5uIpvvMoRwgZRPZfdRMj/I7+hQSFV0CMH2AxskBVvn1qVOKR60clPfendF1I0X9AyZ9fx/yZsMEYkeOXqYD2tiP/Q+LvoLJv3JyrlDVQCMnm/B1WrQihiwY6uCbLUYYD3wGpPJFbWtTpV32EuRdRKN8kHudb3C1uFk4101ogFo61nwBtiGf6jT4aAEY/hJGyJkfLoQa1fXM+gQnRkt+3Tut/xDV31T+VBgFWd2ScU9btzGW8+SWz4BlCjdQgM750BomifYjjn5qD1CsgsLOvKUYMD1oqTwQcdwFQRggpho6Jb+rbYCpsy2vgHItXoxZlFYK16mmlUbS6RG6zDfFTKFMjuFj5TGaxmZ5ffrEPYBCIUWg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(366004)(346002)(39860400002)(396003)(376002)(6512007)(186003)(6506007)(2616005)(26005)(31686004)(84970400001)(2906002)(5660300002)(8936002)(36756003)(38100700002)(478600001)(66556008)(316002)(4326008)(8676002)(41300700001)(31696002)(86362001)(6916009)(54906003)(66946007)(6486002)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U3FJeTExNS9vbHJVQnRobzQyUjRoME03QWFaYWFiMVhMUXlXNXczcXNOenlG?= =?utf-8?B?b3dVSm91U0Fvc25nNlhjUGxrbWdXWkppbHg2VGlBRitLRUNYbzIzeDl4YUhi?= =?utf-8?B?eFcvTzZyYnpGZTh5TGtlWHd4LzkwOE5BVzcwRUVHblc5bjB2ZGN3SjBRU0hO?= =?utf-8?B?WmYwM1hsU21iekkvNy81akVUcnFiMlhyaXZNUmZzSzl5Umg0UmxZTllScGdi?= =?utf-8?B?WkdvM1VHRGhlRmxKZFlBNDdub2puVHFUMVZZQjVXN2RNZHRlUTM1eGd2WXU0?= =?utf-8?B?TUJhTTVOTTBZUEEyREE3aFpTQklrUnhCdTdDa1ViMDIvWEZ1MGNwRHYxZXA1?= =?utf-8?B?b1dsRUJJU01EUFFCdklnLzVZZGNYeTQyZzZqQ1prU2Y0NnJNWHIrYUI3YTRS?= =?utf-8?B?eFBJUDNraS9uSEJpM3JvT2R1NzRBNmJ0K1V4dmVKVWpzZ0lKRzlVYmtIb1FL?= =?utf-8?B?MkErZldFYXV6NGJjUWI3WVFHelpscDdZUndFZ2RwVmwwOHQ4dW50NmFrcHZZ?= =?utf-8?B?bUttbWVmNWlLdGlsbGh4M1V5Vm11eFR4SDlKWXhaWER3eXQvTlhGQ0dOUFdQ?= =?utf-8?B?RUFIMS9IL2g0WDdxU0Z2Ym9mNEFxZExZUUJzNEwxOCtMVmxYR3Z6UWFDL2NU?= =?utf-8?B?T2FsbjljNjZwa1ErSDhrSWJVZkFBN3hzYnRSUW4vYTloWU84a2RPTU0wcWxH?= =?utf-8?B?NjhDVTAzV1dDdXpJUzYwS3FVcmRBUjNsWG9rWE0wek9kTXlSbmM5Wk5HbjZh?= =?utf-8?B?ZWt3YnpGQTFUSjZ3TlZGaXFObXZFdjRxQktkNEJvaHZhVzI1dzNUTWtWU0JI?= =?utf-8?B?UXFYSHRaeUxTeDFyVmNmRDZPdWpLZ0ppdHNKQ2tqYTlvWTBlcmNSUEtIQ3Fm?= =?utf-8?B?QXQ2VkRRSGM0NVA2UnZSUWRqQldIdktBckVuakJrZ2RaMDVIdFFxajBJb29n?= =?utf-8?B?dlhuSjdnWURpTEUxQ3B3SXZyMlp3K0tERHVYajhBb0FMblpnVURQSDhwYlZN?= =?utf-8?B?NVBlMG5FZGp1ZG9pTnZjbS9Ockc4R09kR3NRMmJDd21oTmIyRm5xRndLNTR4?= =?utf-8?B?SXpEWWd5RU5XUm1BSGtSM3ZwYmdBWmp2OWhOcVd0SGFpZmM2UnZYRmFsb2sz?= =?utf-8?B?WUVOcTFpZ1I0VEpQcUZBS0tnREEwaVgwa2VyenZwSGRnTWtEM3dZZko1VmlP?= =?utf-8?B?UndGSkphdmUyT0lwWURoeVRRWUZaeFVLTTF5bG1mcm8xeVNsT0J6ZnA1VDhF?= =?utf-8?B?TVEyOHhPN0tFZUprZW1mSmk5bUVGNnc3MmhoaWpIbkVQWVZmZVFUODFKTXpt?= =?utf-8?B?K2Mxa2lWc3plRTRFWUMzVGFnemVCdDJnY0VIRGFkSWlTRThDc3dlMEJqUzBz?= =?utf-8?B?Zzh5L1pTYWl4OHZLTmZ6UWpaWSswWUtQSk1RS0RlT2p3OEFHYmJ3dkdRcW9J?= =?utf-8?B?T2toUmVrSXE1bk4wWWswT0tkbHNMSFB1TENKVFo1NlVBRnhGMGd4VXVCUDZw?= =?utf-8?B?M2xXNUZ2NlFDbUhDbThqOGtPSWJhQ1E3VW5nWWdBSlhvOFlwZjlSWnIrV1B4?= =?utf-8?B?dGEyQXRBUUdaQk5HdWhPYXExSFNVaWRRb1lOTGsycUQwYVBDSnllemRDZjA0?= =?utf-8?B?a2xEQUhsalEvdTdUdEtKUi9HaHdVK2pJVFZjb2NUeU1zYzZNaXRLdnRDMFlO?= =?utf-8?B?NHNUczFxRWZ4L1lwVlJDTFByRzR2a0dmZFlPTStTdFplR0Jvd3ZKQ2doNU5Q?= =?utf-8?B?YUxsN0RwMFE2eUx5MGp5Sk5qcnlKQ0Zzd2FjeVFPSmhQUE10QjkyQUtpWjlM?= =?utf-8?B?cFVveERZRTVXSEJFTUhYck1tR0ltVTVmMkNHUGJnNnFDdnVKWjYrTXErMjhV?= =?utf-8?B?NVo3MWt3bi9MVC9uQnFpakZOZVpyeXNqV3BBdkp3ZWN3NDZsd0FDV05jSVdt?= =?utf-8?B?NkQ4ZHdmbjF4T09GdmR4L3JOcXBSSlpOVkxMWWJFV25ES0EvZHFDR00zVzRX?= =?utf-8?B?ejhGZUxXYzJrY2hUWGx4QjNFdnZZYy9XMTYzNk00WTlENnh4cWxuQnQ1dWN6?= =?utf-8?B?bVRSemc2RkpMbzBiM1F3QTVNN1FjSlBGMnJBdXNmZ2pkeFQrb0pIOWRpSnpO?= =?utf-8?Q?vGztwLKcGgzwo1j8E0ADR+K51?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8aedc4d8-1299-4787-a838-08da8122bb11 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2022 14:05:39.4651 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JDS0cu7CoVchXfr5Fa7Ecmk3DQAos0qguWUb14ZhUuxGqF2RBcyDt7PwFYuQFlcCg02TikIRY+7o8ELAXChjPg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5604 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1660831571608100001 Content-Type: text/plain; charset="utf-8" "int" is not a suitable type to convert time()'s return value to. Avoid casts and other extra fiddling by using difftime(), on the assumption that the overhead of using "double" doesn't matter here. Coverity ID: 1509374 Signed-off-by: Jan Beulich --- unstable.orig/tools/xenmon/xenbaked.c 2022-01-06 16:12:39.000000000 +01= 00 +++ unstable/tools/xenmon/xenbaked.c 2022-08-18 15:36:39.918706853 +0200 @@ -230,11 +230,7 @@ static void check_gotten_sum(void) static void dump_stats(void)=20 { stat_map_t *smt =3D stat_map; - time_t end_time, run_time; - - time(&end_time); - - run_time =3D end_time - start_time; + double run_time =3D difftime(time(NULL), start_time); =20 printf("Event counts:\n"); while (smt->text !=3D NULL) { @@ -242,13 +238,11 @@ static void dump_stats(void) smt++; } =20 - printf("processed %d total records in %d seconds (%ld per second)\n", - rec_count, (int)run_time, - run_time ? (long)(rec_count/run_time) : 0L); + printf("processed %d total records in %0f seconds (%0f per second)\n", + rec_count, run_time, run_time ? rec_count / run_time : 0); =20 - printf("woke up %d times in %d seconds (%ld per second)\n", - wakeups, (int) run_time, - run_time ? (long)(wakeups/run_time) : 0L); + printf("woke up %d times in %0f seconds (%0f per second)\n", + wakeups, run_time, run_time ? wakeups / run_time : 0); =20 check_gotten_sum(); } From nobody Fri May 17 18:38:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1660831613; cv=pass; d=zohomail.com; s=zohoarc; b=di/cdgTcZK4CL6okqu7+K38XbP7BJfKG7j7IDMVeky4Vs7OA7oK+1D6h9y0ZvAswlHDfJuYGuiU1L60mTMo772GHPY+Qb6HvDsXexwnkxvxGCXe+hgxar6Kz6ZxmWUyU3urByAEKDEeen6JZMcC7Otkmajg//dpyAPq2eTWX2ug= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660831613; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=EnR5qRwNw6zZzjgoQj3V3iV07Z5cVrIBB47eHQXTWkU=; b=R+0ZFJq1xV89/o75+objgI8DOgvv75S8Aopy7GxMndKVEDzAxXnw4V473R6YPBqsoyqM1GoE0xSEMuB8qWKoLMzaPcZy54Xg54jTjr7WWZdHA8+aPWgpYZ0ZTcc/N0XfjesQVUiNMeHcFzgiaelIM+U/17BG8YYFtatTKYluOB0= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1660831613743707.8488819213206; Thu, 18 Aug 2022 07:06:53 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.389576.626588 (Exim 4.92) (envelope-from ) id 1oOgAE-0001lv-DK; Thu, 18 Aug 2022 14:06:26 +0000 Received: by outflank-mailman (output) from mailman id 389576.626588; Thu, 18 Aug 2022 14:06:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oOgAE-0001ln-Ai; Thu, 18 Aug 2022 14:06:26 +0000 Received: by outflank-mailman (input) for mailman id 389576; Thu, 18 Aug 2022 14:06:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oOgAD-0001lc-Fk for xen-devel@lists.xenproject.org; Thu, 18 Aug 2022 14:06:25 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60074.outbound.protection.outlook.com [40.107.6.74]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eff4ba3a-1efe-11ed-9250-1f966e50362f; Thu, 18 Aug 2022 16:06:21 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5604.eurprd04.prod.outlook.com (2603:10a6:208:134::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.16; Thu, 18 Aug 2022 14:06:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad%4]) with mapi id 15.20.5525.010; Thu, 18 Aug 2022 14:06:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eff4ba3a-1efe-11ed-9250-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H2p1AK7EF62m8OJjrKodptIBCsWiU411uRWnpl/PTpbOJbc1OosTgr4aDUH5s/a/Lf7095k2wusu9Z3ww1OK4PzKrMn2mWmJBQItyGPV3shhQVKmwAZOMaRS9SKwmB5xN8tTfYMVxIJtRoj1trE35qaS6OgbBoDZdzIrtzx2hbezVRzgSPdjhNvfMVGnjhjo09tdeBAHFRY7S5rFaaBGsGayHrna3D3K55Sw/aOCF3nR7d6akCZDedktp94pKWtZYZdKIi36HT/S1Mysp2Kw+Q2Csq4MSh5s6WHb9ebbT2Rbhu3RqHvkDULJPmyXwL5tPlStbETAnyUNyCJzQ6z5Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EnR5qRwNw6zZzjgoQj3V3iV07Z5cVrIBB47eHQXTWkU=; b=VTtEtFfHQBc5dqoXlhMemFEzz0Iy88kt6qAZoAPiO+BGMvABRKUG8YAfOVjknYlQUT+qZwxv1bTfcBHpWUscyjYc9thBIlkZ/WzX8ArjdCo7s2iWb0PaUXNguFX53WMTGBMfbAHyj1VcZ5iYVrG/ruvaYpcqXOzjtjT1CQw2UTfc+6qENYfj7pAfQaR+I+/9YPbBXYkj4xZXeLjmj3STNKY31TdBnj0KQoZgnyvFOmhnnVQ7K6c5aNlA/ByvFBdp7iKWots4y9r7VQugzdx61t6q1LDg49OgNilQrIcyQ/c1GKmdtS9+EFMT4QgG7kZ+5ZpcO6CfFhiSdq6bTYuthw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EnR5qRwNw6zZzjgoQj3V3iV07Z5cVrIBB47eHQXTWkU=; b=v2rzIDZr4RkND+gkZC+p2G241WSDDWQBQWZgO0V9W2Ox7tdg6Wt/S2BBMJiU7gjqWRn7tuaNuDzvsfnOaKjP3bdxJLur8PLVjO7w4SOlc4L2kC2ZhMSeE/0qQL3Bs5zHaNd7c0TqYfLqAEY0lMGkK+ytQ+a4Qlr4VMi6qUDdnez9HECfhXwXwj1k3DMAo9f3Y3c24x5B0sWanfG1Lt749D/zCSQhXRyCLDkLhZF30xWritiI1y9lmL9OSyBPAT3aKlUURgAKtp3f5sr/zTMY32g9D7KjQbftUY+CnQZRrwtbFrSoVogc7U0QVdf3jHk5kHrk2UPMgeYRYHfXuGQc6Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <990f432f-1f40-04e4-dfb9-97c8db679f36@suse.com> Date: Thu, 18 Aug 2022 16:06:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: [PATCH 2/3] console/client: properly use time_t in get_pty_fd() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Wei Liu References: <68e71e3b-19a7-e062-9ebe-2e6f6aae0549@suse.com> In-Reply-To: <68e71e3b-19a7-e062-9ebe-2e6f6aae0549@suse.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR3P281CA0164.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a469f71f-93d2-46d8-39b9-08da8122d485 X-MS-TrafficTypeDiagnostic: AM0PR04MB5604:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m9QSYUQqqNRmtH2JT/1cHGM45G7Vc3qyzEZdiHkJLBSJbah9HRrwllFAY9iOXpPFCAUsfNBU05LMWWabzsXteTnL0r5o2ikYrjhnjFGDoh8WZqzRYXG5/K6/UlKc+DKkxOUDf6NgUV7c28y4xlmOSLmomeZsVjRfZMLl6rzL4O/0yuX3Q6Lc3LORssIrTaatzFSHbDYnk2cJS8GernNviRJBvYSAW8IQwF2mSsi1nJm8UV+E3/ps41qiRXaNwokKBrg9ZVzn4uwswyAxpcsCV5dTCVfjRpkbtudUF3zApV8gUCMFBM3WZ0sYvCqLKpU988GimiSHQOTOPUcU+OZmK5ck4kRF9JGeITPaSUgnHxv4NNL5MUgQo2cT2G1Xxnzd6fB2LJp4UldUTz5eWrICRJ6YVWUh8rQWH2UyQJ0K/pnLBRF8AqN9qNL4NoWVyYwkO/PNcMe9+Jd3HWBmOx3+npekAEYK4852nFcPvlGKHIPkYhHs16TQsKTmGp6N8CQWtlVW5Gxh3CIML69OrURdMEYdR7mdDpP4qU85x7XcRwD+YpB8Z6g79oZV7VNNLWPk9fE+Il44Njq6LAYiuPB45W7crNz58hx04FRGw4deT6Raht4ATtK843a33czBg9lAj6rSlA3xltbMqeL2eDWHbOVOua90Eh7HyqZqTbUngL1AKjFUoE5YPjgp4gZ4Z6wPXNmxN435wZiWYFceo12preE5A65LqeJ555bn6UwO2LGDWWWAwq0xvRcJYE6tbYpFW2TMdofIsEWnhs6PBDFXixCVdawRLZpvnWXNmMC8r84= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(366004)(346002)(39860400002)(396003)(376002)(6512007)(4744005)(186003)(6506007)(2616005)(26005)(31686004)(2906002)(5660300002)(8936002)(36756003)(38100700002)(478600001)(66556008)(316002)(4326008)(8676002)(41300700001)(31696002)(86362001)(6916009)(54906003)(66946007)(6486002)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0hvYkRtR1Rtdm94Q3dIMHlmQUk2WGJmTzdvZjRYSWVibTVJWWROUXZRbGl5?= =?utf-8?B?aFVaNW9HSHNLb0JKTHpHbU0xK0lvTU92eFV4NEdmcjVQSjdka1BlTk9wbFJp?= =?utf-8?B?WGRGYTI0dzIxTlhGcnRRYUhydnJiaXE5dmpHOUZpSTQ5WkhxZGhVSjY2di9h?= =?utf-8?B?cEhDY1c2N2NFOFBiRnFGUG9DS3lTL3lGNXR0VWg2YkRCYmpWVVBzbklDb0hF?= =?utf-8?B?R3ZCWVkvb04yTDNtbUhXZ25WY1dKdnFmSmxkK1FWZVErTTk3YW1wM2NzUjFC?= =?utf-8?B?YS81aVg2SGVyVkdHN01YbkZkUDA5YXVwVlA0eU95eUY4T3M5OXFXU3M5MDZF?= =?utf-8?B?ZzRjOUdtUFhKT1lGb09OdC8xY25wSExoYjBoOHJpTU5HZHdNU3FqTVJkclVa?= =?utf-8?B?MUtOV3VucjhlT1NtcS8vd2Y2V1NhbGdQalFmQmN3MHpxZ2RoV0s0OGh0ZWUy?= =?utf-8?B?eFRIL0RtQ1NmekRwZW55NklZeW15VmdXWnpaSWxCRjRsV1R3dWdOSzZOOXdO?= =?utf-8?B?Mk5VQ1JwdHh3MURjRFNUY2U1VFdodVZvcVhXTzMwZS9YeVR0QUN6emhpSC9j?= =?utf-8?B?UHB1RHJtODdZVnY1YXJwZ2w4bnRNSFlyQmJCTXVJL3J2eUdYKzNjU0VGT3Rz?= =?utf-8?B?T0VuSmgraXFqRzZxUHhVbDJKRXg1RE1TYVZXMnl0bFNkbTd1UzBra3VRRTRC?= =?utf-8?B?U1RDalU4emsxSVZ2eUVwVXFndk1Hd2N6S1EvNU5pSDFyUnorTTBFOFNlMDlh?= =?utf-8?B?ZXNzWUtFenZFaUd1WDA2eXZScTF5NkpkcWp6NElObTZ5UVpReVhCNjhqUEhz?= =?utf-8?B?ajhYWUJMb29ORXlkVWFaMTNlZVZMRHNHY3FTWFBTYUhmUU16aEtqbUk5YlUw?= =?utf-8?B?eFI2Rzg2Vi9Ba1E5OXlQd2V4b3p0WVVoeDhqMXRtTC9qWCtOcHZuOVhRakNV?= =?utf-8?B?QnFuK29QZVJWcVJYQWMwT1BUb0R2NVZZNE1HMUdPZGNUTDF0UzVIZW9kb0Zr?= =?utf-8?B?ZlF2Q0ZiQm5KWlhOcGxCWGxZRlFnN3RvN0JsdHFTbitzbzYvemlNZWx5ZkxD?= =?utf-8?B?WW9QSmU1RHNXaFJURmw5QTg1azIrZGR3bGliam0reC9WdTNLa3FMS0s4UTFE?= =?utf-8?B?M0g1VXEvVVllNWExVFljODhCU0s4bG5sVlFOTG9XLytpSTQxMGtXejdJMXh1?= =?utf-8?B?b1hEU1RPN2tIaUZXN1c4dWd1WHlKWDBGYU5nMXNTV21adXg1eDg1V1ROc1hQ?= =?utf-8?B?T0RjVGJxTDBTbjRRTVVYNDdlQTIrOFBWb1dHcHAza2JtR0hsMStkNFpJN3ZD?= =?utf-8?B?Kzl5ZWtheG1ObE53TXdWR3RFZklFWi8wODJSdStyRHViM0s4dXFqNE4zSG9z?= =?utf-8?B?Nm9Gc0x1d3RvUktzcDhhSXhWcENrMGhNbXZLWHpmV0VCMjJWeDBWV0VyaFdq?= =?utf-8?B?SVgycHU3cGxiemZDQW8yc1krd1pwMEZBU3Q5ZlJaTC9FdGUwdUpDRWVPb0N0?= =?utf-8?B?NDRPMEowVE1xdDYzK1VHaFkrMFRsOWE5eVA3SENUbHNCTE9WWmFKMElUUXVy?= =?utf-8?B?Qkl5blViMkN2ZkRSc1B2Q0tlWEhDU0IycmlRQXAzSGRrRWpmT054YUtRYWdv?= =?utf-8?B?ajlrWWJ0YzNTeWFaQVdWeHJGaGprejFJWUh2M0ZWWTJpakFjbmp2dHZjbFlO?= =?utf-8?B?RXVZWlRTemhIWDJ0V0JmMW9reTNtMDNHQzJ6bkNpRHgxZloreC92NnlTbnFI?= =?utf-8?B?aCt4OVZ3cVpJelMxT2xWZXQvYTN0WFBQY244UXNCakhmKzc0VnhQQkExd0M0?= =?utf-8?B?M0RDRFd1SkNKOVltTmhSQWFLVTI1MTdUUFpxQ1hRTmp2R2RQMWN6THordVdP?= =?utf-8?B?K2hJanZhUzMrZDNsbkduS2d2S2JxdzB3N0pTUmgwUWllSU5Cc0RmVFYycll4?= =?utf-8?B?LzRobHBzcG14L0piVFRaejF0QkhaWHgyNlJTZGtaZDlPR2pqMmVoRmFjUVdt?= =?utf-8?B?b1JWMmwrWFVBb2JBWXFKT2RtcWVhQTV6NitrNWFHNlJiZkN3bjZNajBZUFBS?= =?utf-8?B?cHUwR05nRUZYZmFXenl6U1FsNTRRWjRCNk5nUmQxUVlzclFwUHhDTzVYQmw1?= =?utf-8?Q?/+kPZUlafCm8IH0LmZmwBrA2b?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a469f71f-93d2-46d8-39b9-08da8122d485 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2022 14:06:22.2124 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9lu3Djgy/iOsxgcPAfaCQ0Ohm9QBFJlEbeGmCz05x24uexNV5VJhkni7eAtcIKLAPCMXZ2Yj0uv57YILaI1OwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5604 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1660831615701100001 Content-Type: text/plain; charset="utf-8" "int" is not a suitable type to hold time()'s return value. Coverity ID: 1509376 Signed-off-by: Jan Beulich Acked-by: Anthony PERARD --- I was on the edge of switching to using difftime() at this occasion as well. This would then also allow switching "seconds" to unsigned int (or any other suitable unsigned type). --- a/tools/console/client/main.c +++ b/tools/console/client/main.c @@ -102,7 +102,7 @@ static int get_pty_fd(struct xs_handle * struct timeval tv; fd_set watch_fdset; int xs_fd =3D xs_fileno(xs), pty_fd =3D -1; - int start, now; + time_t start, now; unsigned int len =3D 0; char *pty_path, **watch_paths; From nobody Fri May 17 18:38:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1660831672; cv=pass; d=zohomail.com; s=zohoarc; b=MJUKQs+q2XOWyJnVK0jL55rYxKvBHkuaZecQaAKGd2vVUXl2WV54pC7esFAojX86k/9vM6S+KWhyyQYozj5+CJcYXvR5cmR45CuTvgkg7uasUFHIzklKEAGGoh+QPb51l0M0ZomkTHDn2B+z0buNQSIZt3iDFlMtscljmWtcip0= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660831672; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=SRRfVD7hJnZdH1IsdEus/1cIXqBM1/ZFOBeK1CyDYjc=; b=EWVDk6+y9qABBWNYuKoWdFPmJOi7boi9edw68gp3mRdy0u8y5foWclfNilQMw2vC/tU72/pJX1E6+48g3ao7a7hmyG7BVD5cuxuXuJD1shLgbwSxfnyH5nLhzf3mO1IOE/cO50Rt8BbgzSNlhAFBJzHSK2znvttB6OOz1RvjEVc= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1660831672305180.69593763735224; Thu, 18 Aug 2022 07:07:52 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.389586.626611 (Exim 4.92) (envelope-from ) id 1oOgBA-0002v6-2B; Thu, 18 Aug 2022 14:07:24 +0000 Received: by outflank-mailman (output) from mailman id 389586.626611; Thu, 18 Aug 2022 14:07:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oOgB9-0002uz-Un; Thu, 18 Aug 2022 14:07:23 +0000 Received: by outflank-mailman (input) for mailman id 389586; Thu, 18 Aug 2022 14:07:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oOgB8-0002G0-JP for xen-devel@lists.xenproject.org; Thu, 18 Aug 2022 14:07:22 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80085.outbound.protection.outlook.com [40.107.8.85]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 13a4dcd6-1eff-11ed-bd2e-47488cf2e6aa; Thu, 18 Aug 2022 16:07:21 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7397.eurprd04.prod.outlook.com (2603:10a6:10:1a9::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.19; Thu, 18 Aug 2022 14:07:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad%4]) with mapi id 15.20.5525.010; Thu, 18 Aug 2022 14:07:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13a4dcd6-1eff-11ed-bd2e-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c0H0K8AJEsaOM9LaBIhohbEImCb/aJMC2QQxLFNUNiFnvcte31VYYr9kYGW6uYSj7jUDpYFxJlLprOCMZ+q/uPoSLV5aKFMksl2izWytHwM0z9jbQarMZhbUCwEbPIZ1vecwk9YSKZS/grRx+QbgyR0IcqsbKQykpBZZdaI1fr1kuML6PQKZFlOWFinxU1O2CGfioF1Rej2YwuK+fozwP2WfG9BGkJivHXWNGxL+PNABbztnvzHvK5+8z6nqYAoLSgbr3m7sm5M5SZqk+MKvxJQz8BvqUX3szEtAwjPoM3oRgG/HhYaRyMC2nT4EAgh7V3nP3HRhmZIT8jOVh7tp4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SRRfVD7hJnZdH1IsdEus/1cIXqBM1/ZFOBeK1CyDYjc=; b=Lxg71w/8OMYtKCd+H7vc2uLIZQubjU8Xka1xmagMy+nHpLUw+h4RaF6eX+XgewbvPcDCKReYA/ZFRe3Qrc/ttRCS2u5wTz9rfQV7pUBGe4/4ApEUQz+lowuNa6LrkAlrp/HjNBSZSG+ICHrIPYaz5WXP5HTp7stGso+zTMlTgVbNMO0GJUlBaYD8wZ6PXF1MqGsbfs5gNsCcwpzHw+kkKEQo7zF8L5mDUdfi+77HUeVmpwnM0gNpxFJ+SqDzCjAAx8TsGLRrfpTGV02DXe6S/2bdB3t4wxspuB5if+Ngv+hWTqtv00njEnB5qmwWOyLrH9JNDTPvHUtNnIJRwgGWXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SRRfVD7hJnZdH1IsdEus/1cIXqBM1/ZFOBeK1CyDYjc=; b=BQWcMGhcrvB7ZbdMM+VmgYhtIY93a1RXbgtZ7etfUGrKB4IVe33Pym8m5rLjdrekA1PPwgNFPdVgB/UfdDUdPtkRMRraGUHtPaBJXiY/pDvqYzKFtrqhDtbqoSivPX58BR4xnCdSgbkQrYLWkcLxmbKMlITx8tykeM11Szud/aAVF1PI9E6PLf447ABCC+Xy/TbN3TVoujNLa5XxsH1XMheAUGWyqgBVTPlJyO2nAirO7X03ARAFrFU9ArZsZI56Wh++Ixeprdhl5tygemetPDmStrDqJoFtqrHW4JbG8gRF4qriALT/4zqT5huHWFxPovWCxZ/V6aHzLcpAp/LWOQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9ac207d1-8a20-b880-e564-57494bc5b551@suse.com> Date: Thu, 18 Aug 2022 16:07:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: [PATCH 3/3] libxl: use time_t for qmp_synchronous_send()'s last parameter Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Wei Liu , Juergen Gross References: <68e71e3b-19a7-e062-9ebe-2e6f6aae0549@suse.com> In-Reply-To: <68e71e3b-19a7-e062-9ebe-2e6f6aae0549@suse.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR0P281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6deceb2d-493f-456c-4d98-08da8122f5d7 X-MS-TrafficTypeDiagnostic: DBAPR04MB7397:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z/1i19NyxH0QUSyKzjxumTO4SGYWkAH2sEOq96Pi922zNnMZU6lH3n0D7dEBlCRyefhyQIxx7Gr49NJR6ohJw8rbhEIYNqlVPt6vTBwHon3+WLrEgg7RgX5q4KuXQWoWgW6PS+4rjyVT0slpmDevF59tB4ZFIQcpMdaxdAFrSwRyzLja3YcLneyCTraxJZpfa2QCGLR7/rKBRhwyw2hry2MmHGad/NW/8zQqmNVvIp8+6FNN/wBifd+UgpRlFBKOArcfOs5q2u389QP8BR9cU+2CYZvl3vyyB5AGcsjhqwM/jifD+56CdZ89vc+F6Xyuof8NBJtBiZVHsn5USYIL6xWpVDz5LRaGuHF2xq+l0ZwoEkn5YAwDlPj3lxK5GAHH2gwBvxqc/vMU08CmeOgHVEhBxtBLPTy8mVwt9Fw17GUFxiMIuAOXaq30c3ZBpajrNmjvUd84saPRKgmtUYjo5dPRoYewaLyBto7rqVfKBiq8dF/DtUCGX5M/C1HrsOM8yo/XgmChCXSfavfhn8mSOTxCZ5OmdTtDGiNoLZmdCKrHY0rr2iVdfQADIMNLGWLbxXYHhhQDZQOgPyMF/OhFznkfKZVIfprts4/RuUtHu4bthcv7ZajUJ2dPwYfzgr4T/RrxrQF8okDxg9qZJKWX2Z9PHhp1U0sIh2kcyxvj7hLXzwhcqioXX+h5zEXLAfiRTDVotdQj38nXDZJ8rw8/bnhN255wKyLTBbhm+0ot//9vzcRnAAffy4xIZAeGlNgxpmQafeifOk+W7xYc8ws4r9czfcgn4Fq1hLp52Er12fE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(376002)(366004)(346002)(39860400002)(136003)(8936002)(36756003)(6916009)(31686004)(38100700002)(316002)(54906003)(86362001)(6486002)(4326008)(66946007)(66556008)(478600001)(186003)(41300700001)(6506007)(2616005)(107886003)(26005)(5660300002)(8676002)(6512007)(4744005)(2906002)(66476007)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVJrbXkxckRoNDhLQkhmSFcvWGNmdHZCWnRCQ0FFQk5yNVVvWUJLU1hvMTJ3?= =?utf-8?B?ZUs2T2RlbDE3RzdSeVJCNkF2TnpqVHVCNnZjbW9KSXZMSHliSDVvbWMwVHB6?= =?utf-8?B?OVEwVkxTZ2pqUGdocEE2bGtaQUVTeDFXelF3L0NsZE1IZnlpOU9HTVFvSW82?= =?utf-8?B?RFMrOGZxQW12VTJHL2RFc2k5VHlwNVMwVG5oa2FnVUM1RzRXNVhtazlReVZV?= =?utf-8?B?U3VLeXNjRXF6NXEzSTYyQ2Jkck5TdDB1WVZDN0hETklqSzVVSndqQU9UeDF0?= =?utf-8?B?Zjl5aU1wRnlLUzlHOU9QUDBXQjlWNzdHenlLWXdrTXRpZVdtSXlrbWVxdWhk?= =?utf-8?B?SEZxR082VGlnMEh3RzhIVG9tSWx4N2VQQkFhZElxMGhpZmtJdXRNY0VpS1JH?= =?utf-8?B?QWIxbjVMRktrTHlDTmhuU0JOQXlKMDNjMlFhT21SWU5rQUVHbXhzRklYR1lK?= =?utf-8?B?NWpINVY5RlBxVmpONHc0OFZ3L241dmpUbFpwVnpGRm1YY3NTNU45YVFmQnps?= =?utf-8?B?ZFMrZFkzOXlYR1hOMFRNaytQUDhmOXRKaS8yVFJ1T0RhSko4QXorSjRrK0Ja?= =?utf-8?B?OFFYQzYxTGxQc2UzWnV0Wm1oTDhwTC8wMGZDb2FqaHRhc2xxNldVcmdtSk5t?= =?utf-8?B?QWRjNG9jSktQTkp0RTdiTGo3TytWNkxlU1djalFHRnVmRjIvVTlTNVp2SHhm?= =?utf-8?B?dC9YVDAxTC8yZS9HSUVGQlBjSjZ6a2FMaEVvejJwU0swcEFMOFBvbTZBcDdm?= =?utf-8?B?dXZzMGdhNlptZHFTbmFBM01RM2Q2ek1NWEJmZ3lkc3BubjhLd25sZVZteVJr?= =?utf-8?B?NGl4RkF0QlVuK1h6SUN4T2JudFJlRDh5Z28wcFc4dTNDNDdHR3VvZlFPWEY4?= =?utf-8?B?OU41aHdsbUp2ZGZNYWpqUEtqdjRPRFBFSjZIUCtMTW9rejZ3WG1Qd2ZwYm12?= =?utf-8?B?NTBkMUZHeTFyOWZLMVVCU3NRQVAvaWZyRklTQXFQbFJMY2h3SXExVzNkdWs2?= =?utf-8?B?WkpIL281a2QzM2MyOVlkWDJNd0c5TU9jb3piY2s3Rk5TZU9sM0VkOGpSNTE0?= =?utf-8?B?YlZma28vU09Pa2I4YlVDcXBjbWVwbUlaazNIRW9CR3lyN3NpT0hUWWlTbHg4?= =?utf-8?B?d2NxdkQ3WFNDdHZEVFhRaVNnc282VEc2MmdXMDhKdHczZlVYWVZDNllOWmpD?= =?utf-8?B?eFRBM1V4T2VqZkx0Y1BPazVUTEczZDduejc3TVdvcHRFbUR2blovSVA2VXdE?= =?utf-8?B?K1hVRlRpYmlickZzeUM4REpRZzBOTDkwazg4cVJvbTFBV2haaUxaZmlESkdK?= =?utf-8?B?eUxLNThZdCtVRjc4NENsVkgrd1VOdEpCcW8yL2ZINm9FSy9WZWpQK1ZMQW1C?= =?utf-8?B?ZS8rSlp0aVB1QkFWQStrd3RDT0MzelhOeExuWmFNTXh6Z3VydVRuV2FZRkhX?= =?utf-8?B?SXEvYlBDbFZQMVZxTEVtMHJ0K0FOdU8zWXlXbVI1VHIyRWJwb3VmdmM5UldZ?= =?utf-8?B?YWk1SDJoZThyZ0FYbDNwM25iTFhoblh5eHZrQ3kySndGSk5HU0ljVlNFUFRm?= =?utf-8?B?VGVWTE5vcmxGYkdPSXljZHNjS1o1TEticXZNVHp3RDZ6VUh2VW1IK1ErYUhS?= =?utf-8?B?cWxIYWZoNGJzV1NkREx2cU43UTh5TlRPZDk5djBEUnZQc2pFVllmbVN0Tmxm?= =?utf-8?B?TTI1Qlprc21LTHlZblVGaTA4cjVtYUs0NmE2MDRuS3B3OXkwbHdaV1Flb0cw?= =?utf-8?B?eTQyK1JJN1o1cW1MbjdrdzRMM2loU3ZCa1hXZTFJZXpzSUJCNkd5b2RQWlBr?= =?utf-8?B?eFMwMlJ4Qjd4aU1xVGtCQmIxMEhGZm8xRWxSWWI2TXNVWi9meUlTeDFqdWJu?= =?utf-8?B?NVRlUVQrNU80L0YzNDVhRXVMa1VaNWRlc2xobDRRUTNkczRaVHYyRVBpNHlw?= =?utf-8?B?M042N2RSZWQyTFYxR1RqSFZtei84WXlLS0FOcEN0dkZ2eVZvMkp2eWxwWkZI?= =?utf-8?B?bktCT21vZWxJTlFCK1pBVVE1QWVTb1B1WnhUZG15YklEN083OE9KcGRFMEJC?= =?utf-8?B?L0tTdE5jb2E2MkVpby9TQkh2Y0JvcTRBaVY3ZlB6YXIvcHRsMWZubm5iRndM?= =?utf-8?Q?zUIHeoAyWCNhZxYIaVrYrjgxM?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6deceb2d-493f-456c-4d98-08da8122f5d7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2022 14:07:18.0839 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gCmozC9cDK5H8PzmJGK9Ac5Pg/arxCiGhMrjripoCkBB5NKTWIrzGApAdJfobZUH1Xzohw8tsPIxH2/KumR9aA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7397 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1660831673713100001 Content-Type: text/plain; charset="utf-8" "int" is not a suitable type to hold / receive "time_t" values. The parameter is presently unused, so no functional change. Coverity ID: 1509377 Signed-off-by: Jan Beulich Acked-by: Anthony PERARD Reviewed-by: Juergen Gross --- An obvious alternative would be to drop the parameter for being unused, but I assume there were plans to use it in some way. --- a/tools/libs/light/libxl_qmp.c +++ b/tools/libs/light/libxl_qmp.c @@ -582,7 +582,7 @@ out: static int qmp_synchronous_send(libxl__qmp_handler *qmp, const char *cmd, libxl__json_object *args, qmp_callback_t callback, void *opaque, - int ask_timeout) + time_t ask_timeout) { int id =3D 0; int ret =3D 0; From nobody Fri May 17 18:38:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1660895994; cv=pass; d=zohomail.com; s=zohoarc; b=SboztkrCgI6Oj6VRl0D5nOHELOYXkEotmzmH4ROmsTmOZ0DTH6RriOiLuGWflDTCL4LcJxG2w+FIUgF/agQPkUfVMg+PaMm5XPd2uYLdeuZLRlrWc8b9A88lxIIeSbT4fveM6i07GIGJg9/GnDqgcFK8c5/RBbdqph80zzKxcU4= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660895994; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5Ve5o4lLxkQ+Thb31feEDXDXRKgB/+dn8OOmJlU4ZWY=; b=V2XuNNOZiq8kgB1IFB6LbaoZIx3ES6s06IpDL/iNVjz1jWZqHLcGy9wDPj6bOWmRxi6hc1cM25sFXLikdORoLj6Au8eCNUn6vSWoOUF+EqlYrX+owxEi46JZxAAprUEzEhZ4tK5DILf1bBXJwgXEZUpl680kamTlPnrItwFdq5s= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1660895994516597.1443804035998; Fri, 19 Aug 2022 00:59:54 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.390081.627291 (Exim 4.92) (envelope-from ) id 1oOwuj-0003KR-UG; Fri, 19 Aug 2022 07:59:33 +0000 Received: by outflank-mailman (output) from mailman id 390081.627291; Fri, 19 Aug 2022 07:59:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oOwuj-0003KK-Rf; Fri, 19 Aug 2022 07:59:33 +0000 Received: by outflank-mailman (input) for mailman id 390081; Fri, 19 Aug 2022 07:59:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oOwuh-0003K0-Tv for xen-devel@lists.xenproject.org; Fri, 19 Aug 2022 07:59:31 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130058.outbound.protection.outlook.com [40.107.13.58]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id daf8eab9-1f94-11ed-bd2e-47488cf2e6aa; Fri, 19 Aug 2022 09:59:31 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6864.eurprd04.prod.outlook.com (2603:10a6:803:138::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.18; Fri, 19 Aug 2022 07:59:28 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad%4]) with mapi id 15.20.5525.010; Fri, 19 Aug 2022 07:59:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: daf8eab9-1f94-11ed-bd2e-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MWbfvqxR/1iF7uhxjRX/rKzI21okdRgmYeDotACwkgRDunBaQ4K2Ha6A9wDeTVwn/8aiU/C469yWVxe2AJehGNlY4FuCRUIN6EwVbJHVNstypGm/vYAkgaKD6wsyTxAk/wWRK3Hml40gc77zWvNn9IYUrHLTShmV9kyq96C5MDZ3IkDjWlcBiK0k1qIMENt99y9ph0UldL4nCzRWi/e0tGPUAJqpMQsG01ktHCvMYNX1Pdh68p0owKWNj4oCsQK882eSI2MckJ9dS+ZCs7zuDAZvIhMLx7S7oiRVsC2aIpf2Wb/FV4Oo8IJ5vsni9f7FjD5oU1AbshfqD1MTIwnlTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5Ve5o4lLxkQ+Thb31feEDXDXRKgB/+dn8OOmJlU4ZWY=; b=CAyKl6wxzNLUranOyf0Ar1STx3aZItAMkjKkiprz9qf8Uyl78krTPZX4e6BlhwrpA1JQyzU5STyIzV5d1FQxWH/qVGE2H1vU5pQnVyxmJRaDOOgbeApE2B4oji2IcFsPqiYOY8wedwOaR1mNC0P+kZ2sJ5YliLP5GQ+XEITXDZibseVsI2KBbimGFYKQbGcuEzJVbpDgT/IAa0UIqYi0ciSetmptHGqPzNgRb4PYuje6JRsMN3Fvf+OhG3RUQoMw6apwdqjh8Oiwis9Du1w6sJZkTwza56xdHXpjvvIedqaSYYq6u5RtSllHEGTTCMYZrsrBVAYFaDgFSDuXKF7H9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Ve5o4lLxkQ+Thb31feEDXDXRKgB/+dn8OOmJlU4ZWY=; b=VXOtlrB1XQOD3QFYy0Ea3bgYY7755oetWDmDZyneJXrUCttcvmFHxvfsLei9af210pC5FokhsUswnjLjkkdf4f4CZGbTGK/7YipOCkEYCh8kdTBVdtD+r25/rr+GV/+EPcEiqfFZ4BV67+YrCdNDbXNdtDa3u7pUAUcG6TBN+X5ohhqhwq/UETnJiqMlZ+LlOJksL9y8XRzGkRyJXDLL/uOO3l9xXtjgt0gSHS7e6AEQ8gh68TW4U+21WDKsrng1EEpfM2uLaXWHDYzfJXofC9gw4B8sUhLXfbsvdxxD5c5F3GZHUdwpyLBUJCV51m8jzpXCPhAdX4ORQHZVuXVR3Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 19 Aug 2022 09:59:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 From: Jan Beulich Subject: [PATCH v2] xenbaked: properly use time_t in dump_stats() To: "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Wei Liu References: <68e71e3b-19a7-e062-9ebe-2e6f6aae0549@suse.com> Content-Language: en-US In-Reply-To: <68e71e3b-19a7-e062-9ebe-2e6f6aae0549@suse.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR3P281CA0167.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6349b19d-1b86-4d85-5cd6-08da81b8bde5 X-MS-TrafficTypeDiagnostic: VI1PR04MB6864:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KOEyULXbOIIMQGcAPjo/QE1o1BJQ2oezr7z1VN3ETjeWuTNzSYjv9gWxm0C67jw+XoXAfUcFeL37JqvuR6nNnqw4OKD71aJYNwj8LPORZBizbgM3bruM0QT49kJGNVIuiTewVRKosiXYA+dn0QU0GDbhYB+NAnTjaI2DHuk5mY2pOEoNKSS/ZBU9tLafoYOautOHgoVHg4bgQgS9s0aYxM03lAUp8NfHg1NU90hJanxv4cCV4KX3zKtaMstZ4q3F97YMt5Oma8cwoTZ55chHJQdPXb4WZkmqzJKE1Egm8AJmwgcUHLG5psZ9NkHi2Q3rEOqxWE5ylSY06tvSkXMZ54anbwtyTjszYp1i1dTj8tdTqj6ecItdEx1Sq99hUFzEhwBHwt/P0x30FUpt/Rm2AVMu/yWN4rW8hUq4VD0hTf6HwhxVJVxs28ZTRB+CEwILJw7KudFJhpZkfETofp65ZP4Y4t0EDRHerJzhL3SU9tno3v1UiCC0QOU0TVrvzlW6mV3aBYGaSe9zujQUnWe0gqs5l8tluB3jJAwin9izPPYicnpmBmEvDGHXVKe0F+14Ll16bpCmxcEYAiPm5w4G/HOELIR0Ogr9U5WczBY9E+W1YnYyHeGO5i2IAXQK1ehkMpJpB4hDK+iDi7qingva1zkq8dJOrNHpZqg6XmAF0yavkKOQXioc24KUkNi8LqBW1oiNLyQJlezoAr7Wg99cPiEhwGxeNXNfq04IG8ahsFqGJKQBUXglkGr4T5/1I6k6BH5o2/EcKyrtacHErPrrrRdtPJU7SVkqNzFwHYnP5CA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(39860400002)(366004)(136003)(376002)(346002)(478600001)(41300700001)(6506007)(86362001)(31696002)(36756003)(26005)(6512007)(31686004)(2616005)(6486002)(186003)(66946007)(66556008)(8676002)(4326008)(54906003)(6916009)(66476007)(316002)(5660300002)(8936002)(38100700002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZHlWNFp0SDF6Y3gwNURFTnNWc3JkYlZLUmY3YndWQnNpOWJHK28rOVlVeWpp?= =?utf-8?B?aFB0Rk1aQ28rUzVuQVFmb0s2aDd0TUwwZENaZ1Q3amNVd0VZa3JPZWpCdm41?= =?utf-8?B?SDZ5ZWgrWHNCR0l0WWZOS2IrU1dOR0IwdU9ld1ptUXB2Yk5INlFPK0Q4bHNF?= =?utf-8?B?aktBcm9ld2RaMnVLWWh6Mm91Tms1eFpOclNFbGVLMVBwNUlENG9hOGZJSWhw?= =?utf-8?B?bElnZ3VibXJSdGo1VmRhUkRxRk9qNmZTdWRmU0h4SnFqeWowV2hoSUFmdi84?= =?utf-8?B?cXRLSk1teW9vWE53c3BTOGRVR0tERkxKQ0tXTDRxTmVKNkVZbEdWT0JNS2Nz?= =?utf-8?B?RitidmhwQ2wreFpLMlh3bmhlSnJ5Z1VuUUhybVd1ZVNOak5LVElLV3JwRGVZ?= =?utf-8?B?QTNWQzBQbm1keHdmMjQzL1VIbmxkb2Ftc2RxUmdSOGQ0VWxucW1KOWdTMlN2?= =?utf-8?B?NHZvNFBvTFhqb3RlWkRzSE43UUpYcHZYckw3OTZtbFFiUHVNbmFtMnllSGtC?= =?utf-8?B?NUJIVUs3Ny9mNEVFeStuUi9IY3JIS0ZYY240MWRaaUQ1L0JENXN3aWtqRGNy?= =?utf-8?B?eEpIcUdtc24vTzRLNE5mUlRVSk9YRUpTdFVQYjZ5RkFCRUk1bGVJTDNUQjBG?= =?utf-8?B?UWF0VjQzaTlOVG5aa2cyMFlCOVZXMTBDTWw0SFJUR1JtcFMxdjJDUVZZWkE2?= =?utf-8?B?UmlYVXZhcEY4bkdMUmpTQVNYWkZ6WFJYN09nQTZNVE1MTXlTRSt2N2NjN1Ey?= =?utf-8?B?aGJNcGh3RDlkb2JWcXlEVjdqWGlvREsrdTZNTDVrRCtVTnRjRVVlbmZIeHZD?= =?utf-8?B?Q0Z0czU5enJiSEZBZjd4cTg5d3VHR3VoL202OGNPUVp4Wnc2bmkzRVBxNFdW?= =?utf-8?B?bXNDUVBDYUc5Rm4vbnFmYkVQY0MzY0dHaXliSVY5OHpjYllxZTNZWnVlZ0NZ?= =?utf-8?B?MGlkTzVkdE1jV3RmcGw2ZkVPN1BEUTlmNFFwQWRabkZiSDNqSDArOUZpZmNS?= =?utf-8?B?dHpaK1pyaDA3UVRhZUpGSHViejN0Y3FSd0RzdXNIZUtxNFl3MGkxZE5sQnA5?= =?utf-8?B?MUVhWFJkN1h3L0xyM2oxUXM5NXRkem5aOVlkajlUWEFZNHJFUWJ0YTFyeUdR?= =?utf-8?B?SnhoZzB0V0IzOTZ2RkZtUERpTjVGTWcwRm5STG9adDBnWW9kSVJXaXV4QzNB?= =?utf-8?B?WERTeTVhM1M2eHhsWUJkSkNoV3lHK1FKcVpybW1Ycjc1RldhN3dzV1NqNXRS?= =?utf-8?B?c01wOVlZdjJHZW5IUVZXcTZtQjZJWmVjQjJoUnA2VDJ4TUxJbGVIN3hWUHJM?= =?utf-8?B?RTZYRHFKMGhvNk8wU0FvOWlPTHNLWHJuMzEyMlF0dXp3VEdjZGRwTjNmLy9s?= =?utf-8?B?QXFsQ2VmcitYWHdVai9lRDA2RHd3MHU0YUJNWkNOV2ovVGt6RWZ0WGpXc3k2?= =?utf-8?B?NDhxMFhUbTBpZnRmelBVeEV6Tk5sZHJDZE5pRTRFUDBoMXhJZFI0dVRrc2VX?= =?utf-8?B?R0ZUSVlIWVBaL3Jpd3hLVk80cVpZRWJiZ3BmOHBoeHBTV3E1cmJPRld5R0Y3?= =?utf-8?B?ZmgzbkdKZWRzQm9mWDhZbFBJWUxGRnd3WmdHNHd4V2tnMERWaWxkU1FoZmE0?= =?utf-8?B?QzhHZDRNRjVwVmVhUlBDZkR1d0VLdXBPajVXczdtbnBtUStIdzR3S1lGZ0hy?= =?utf-8?B?VGdkT0dNc2xYbVp4OURYQXloVW1OMUtNU0I1R0loTXh1STZOTCtSVzFPWGJD?= =?utf-8?B?QjU1RGxKMlhJVmxnenpmN1FWYnExY2p5R3dDanBGQnA4Ukk4RWNvdmE0KzVs?= =?utf-8?B?OEQ0U2hENTExam1LMXlib1ZzSWt3QkY5YlVRcThnTk1rTEkyVEd6cVhVSm9D?= =?utf-8?B?bnVTdVhITFpQMVlVd0VISWFRNk92dFhRY1NUa1pjdHNVVlNPR0J5M29uOVUz?= =?utf-8?B?SSt1U3hBZkVxc3JOZmQrSi9KYTRSVjZVeHhyRlkwYjIyNFpmenZXTkt0N2Ez?= =?utf-8?B?RUZRSDFRYm4yRnJiVTRlWW5aZ3U4SjVDWE1uRXJKbm9jSEpPazc4Q0RQNnBV?= =?utf-8?B?VTkrSXVUUlBEN0xFdlJ0OTQ1STA2SFhSQ2pWa2RzdG1MeGErdXVXenBZM2kz?= =?utf-8?Q?NsxpSEkQRIq9rPxSNhjgJhv65?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6349b19d-1b86-4d85-5cd6-08da81b8bde5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2022 07:59:28.7331 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WvaFI2gEqVbijgzUa9uCwnSi7CcSqknjmVtiVvFKpsrUJSl12kPRQxheJ/gTqvoAS21s5lpDWvD5M2AQEiXVqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6864 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1660895996915100001 Content-Type: text/plain; charset="utf-8" "int" is not a suitable type to convert time()'s return value to. Avoid casts and other extra fiddling by using difftime(), on the assumption that the overhead of using "double" doesn't matter here. Coverity ID: 1509374 Signed-off-by: Jan Beulich Reviewed-by: Anthony PERARD --- v2: Properly use %.0f everywhere. --- a/tools/xenmon/xenbaked.c +++ b/tools/xenmon/xenbaked.c @@ -230,11 +230,7 @@ static void check_gotten_sum(void) static void dump_stats(void)=20 { stat_map_t *smt =3D stat_map; - time_t end_time, run_time; - - time(&end_time); - - run_time =3D end_time - start_time; + double run_time =3D difftime(time(NULL), start_time); =20 printf("Event counts:\n"); while (smt->text !=3D NULL) { @@ -242,13 +238,11 @@ static void dump_stats(void) smt++; } =20 - printf("processed %d total records in %d seconds (%ld per second)\n", - rec_count, (int)run_time, - run_time ? (long)(rec_count/run_time) : 0L); + printf("processed %d total records in %.0f seconds (%.0f per second)\n= ", + rec_count, run_time, run_time ? rec_count / run_time : 0); =20 - printf("woke up %d times in %d seconds (%ld per second)\n", - wakeups, (int) run_time, - run_time ? (long)(wakeups/run_time) : 0L); + printf("woke up %d times in %.0f seconds (%.0f per second)\n", + wakeups, run_time, run_time ? wakeups / run_time : 0); =20 check_gotten_sum(); }