[PATCH] xen-netback: use local var in xenvif_tx_check_gop() instead of re-calculating

Jan Beulich posted 1 patch 3 years, 2 months ago
Failed in applying to current master (apply log)
[PATCH] xen-netback: use local var in xenvif_tx_check_gop() instead of re-calculating
Posted by Jan Beulich 3 years, 2 months ago
shinfo already holds the result of skb_shinfo(skb) at this point - no
need to re-invoke the construct even twice.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -557,8 +557,8 @@ check_frags:
 	}
 
 	if (skb_has_frag_list(skb) && !first_shinfo) {
-		first_shinfo = skb_shinfo(skb);
-		shinfo = skb_shinfo(skb_shinfo(skb)->frag_list);
+		first_shinfo = shinfo;
+		shinfo = skb_shinfo(shinfo->frag_list);
 		nr_frags = shinfo->nr_frags;
 
 		goto check_frags;

Re: [PATCH] xen-netback: use local var in xenvif_tx_check_gop() instead of re-calculating
Posted by patchwork-bot+netdevbpf@kernel.org 3 years, 1 month ago
Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Thu, 25 Feb 2021 16:39:01 +0100 you wrote:
> shinfo already holds the result of skb_shinfo(skb) at this point - no
> need to re-invoke the construct even twice.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Here is the summary with links:
  - xen-netback: use local var in xenvif_tx_check_gop() instead of re-calculating
    https://git.kernel.org/netdev/net/c/826d82170b53

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html