From nobody Tue May 7 21:00:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1614267564; cv=none; d=zohomail.com; s=zohoarc; b=M7EZA6rr2ICCy8DgKhq1z68rN91F2zAWnH/kefOVXwFsJAPrdoAUfZh+OqDfC2VK5JUGmapuq+V1fmC+ZEifxEfjrJXshlMvWEr4xbm77h208lfxOt+bIvmevlSmh7xuyZBSBZnWFkFc4/8RUFJwPY/rRloQAJEQoSs1//6P/DI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614267564; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=NFd034RDEJYXcq9r3tELC5CypWrYDcd0d0knOZGlyxM=; b=QFuA2JlDlncLFIerATTfCOaeF1zxd72dQrdTyq8MIb4PlZ8ofnXgCehek/7kdcrYea1NMY/55Cu6wmBFnzLMBXdtsmYZzCk4bBRRxNqNQloAjfrAnDjqsqx8jtrvN3ug+mr4/kRCEgep3wpjmRpkhwchd+iDcxGzvug4c+5mCr8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1614267564943658.4849043264278; Thu, 25 Feb 2021 07:39:24 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.89834.169607 (Exim 4.92) (envelope-from ) id 1lFIjI-0008Ck-QR; Thu, 25 Feb 2021 15:39:04 +0000 Received: by outflank-mailman (output) from mailman id 89834.169607; Thu, 25 Feb 2021 15:39:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lFIjI-0008Cd-NR; Thu, 25 Feb 2021 15:39:04 +0000 Received: by outflank-mailman (input) for mailman id 89834; Thu, 25 Feb 2021 15:39:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lFIjH-0008CY-6O for xen-devel@lists.xenproject.org; Thu, 25 Feb 2021 15:39:03 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 914c8315-89fc-43ad-b121-3e50c5700f24; Thu, 25 Feb 2021 15:39:02 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 20A1BB10B; Thu, 25 Feb 2021 15:39:01 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 914c8315-89fc-43ad-b121-3e50c5700f24 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614267541; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NFd034RDEJYXcq9r3tELC5CypWrYDcd0d0knOZGlyxM=; b=XgbQ5MYSf2y5OQAreaPj8wbV/1arB81ci6OiZNQSw0iecmcn9PeJAz3pxsL+lARSo7YFil FFLJYih+iUjnSrwCloncsniCXHAee0dIo8SgjzscYwdffwufiCiPBmbI5y8vuQWuYLhWUl +WdMBDaNIfKT8sciziRQSdpj+YQekDk= From: Jan Beulich Subject: [PATCH] xen-netback: use local var in xenvif_tx_check_gop() instead of re-calculating To: Wei Liu , Paul Durrant Cc: "xen-devel@lists.xenproject.org" , "netdev@vger.kernel.org" Message-ID: <6604dec2-4460-3339-f797-e5f8a7df848f@suse.com> Date: Thu, 25 Feb 2021 16:39:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) Content-Type: text/plain; charset="utf-8" shinfo already holds the result of skb_shinfo(skb) at this point - no need to re-invoke the construct even twice. Signed-off-by: Jan Beulich --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -557,8 +557,8 @@ check_frags: } =20 if (skb_has_frag_list(skb) && !first_shinfo) { - first_shinfo =3D skb_shinfo(skb); - shinfo =3D skb_shinfo(skb_shinfo(skb)->frag_list); + first_shinfo =3D shinfo; + shinfo =3D skb_shinfo(shinfo->frag_list); nr_frags =3D shinfo->nr_frags; =20 goto check_frags;