These patches have (as a single, monolithic one) been living in
the XenServer patch queue for quite some time. While preparing for
this upstream submission, I've left the code largely as is (only a
few cosmetic adjustments, but no functional changes), so the series
can be assumed to have been properly tested. What I did fully alter
though are the descriptions.

1: correctly ignore empty onlining requests
2: correct ballooning up for compat guests
3: correct ballooning down for compat guests

Jan

On 28/10/2022 08:20, Jan Beulich wrote:
> These patches have (as a single, monolithic one) been living in
> the XenServer patch queue for quite some time. While preparing for
> this upstream submission, I've left the code largely as is (only a
> few cosmetic adjustments, but no functional changes), so the series
> can be assumed to have been properly tested. What I did fully alter
> though are the descriptions.
>
> 1: correctly ignore empty onlining requests
> 2: correct ballooning up for compat guests
> 3: correct ballooning down for compat guests

Thanks for doing this.  From our side, they all came from testing where
we took our existing PV guest tests and ran the guests shimmed.

I'm reasonably sure there are more issues lurking, but this is
definitely an improvement on its own.

They want backporting (in due course), so should be considered for 4.17
seeing as they're ready now.

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

Hi Andrew and Jan,

Sorry for top posting, I don't really want to block this series so I am answering this on my phone.

I saw Andrew provided his ack, since this series is ported from XenServer and should be included in 4.17.

Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Kind regards,
Henry

获取 Outlook for iOS<https://aka.ms/o0ukef>
________________________________
发件人: Andrew Cooper <Andrew.Cooper3@citrix.com>
发送时间: 星期五, 十月 28, 2022 19:11
收件人: Jan Beulich <jbeulich@suse.com>; xen-devel@lists.xenproject.org <xen-devel@lists.xenproject.org>
抄送: Wei Liu <wl@xen.org>; Roger Pau Monne <roger.pau@citrix.com>; Henry Wang <Henry.Wang@arm.com>; George Dunlap <George.Dunlap@citrix.com>
主题: Re: [PATCH 0/3][4.17?] x86/pv-shim: ballooning fixes

On 28/10/2022 08:20, Jan Beulich wrote:
> These patches have (as a single, monolithic one) been living in
> the XenServer patch queue for quite some time. While preparing for
> this upstream submission, I've left the code largely as is (only a
> few cosmetic adjustments, but no functional changes), so the series
> can be assumed to have been properly tested. What I did fully alter
> though are the descriptions.
>
> 1: correctly ignore empty onlining requests
> 2: correct ballooning up for compat guests
> 3: correct ballooning down for compat guests

Thanks for doing this.  From our side, they all came from testing where
we took our existing PV guest tests and ran the guests shimmed.

I'm reasonably sure there are more issues lurking, but this is
definitely an improvement on its own.

They want backporting (in due course), so should be considered for 4.17
seeing as they're ready now.

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>