From nobody Fri May 17 04:49:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1666941735; cv=pass; d=zohomail.com; s=zohoarc; b=WORtJZ49EnhM/yClivcIMXxD3Ukb43l+NvRarU9pw4dn06o+fL3tgflI8ORDkUxAmNKeKCRsNYbtBu9Br1UQKscZbvCXHr4IXE+0rS4UcV+uI9+36sjUFdET/clyTjJVG2stwFviPVY/q54g9Re6R7DZaoqruMr/RBRQutNWxOw= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1666941735; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=YIhWJYPncYb8h4kWhPCveJpPZuHkPif4kdTPxSU2Ykg=; b=dEnJ8O5hqQSnfQejtGp0ho+EgHUMY3+SFgGrs3eDKhDT3pEZQ1aE+9Ej/Sq2XFY5iijmOH+W6CEsyxCZ5NjcTbjzWBw2wv4jCjrKcTlei1PffDTUItLZFRq42zle0I2I91GErfzH+F13Yq/Pu9miNpu/tMPy0NRIdqYXb9Y5FCg= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 166694173545635.48969629809051; Fri, 28 Oct 2022 00:22:15 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.431433.684326 (Exim 4.92) (envelope-from ) id 1ooJgk-00028a-Ev; Fri, 28 Oct 2022 07:21:58 +0000 Received: by outflank-mailman (output) from mailman id 431433.684326; Fri, 28 Oct 2022 07:21:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ooJgk-00028T-Bv; Fri, 28 Oct 2022 07:21:58 +0000 Received: by outflank-mailman (input) for mailman id 431433; Fri, 28 Oct 2022 07:21:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ooJgj-00028L-8O for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 07:21:57 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2075.outbound.protection.outlook.com [40.107.104.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 33c60a38-5691-11ed-8fd0-01056ac49cbb; Fri, 28 Oct 2022 09:21:56 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9264.eurprd04.prod.outlook.com (2603:10a6:20b:4c4::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct 2022 07:21:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Fri, 28 Oct 2022 07:21:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 33c60a38-5691-11ed-8fd0-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MV5erz9oEQdMcoEAm3htOgDfSAXy6K5nmnLq48x7fXdZcRS8i63DziepT2Mkuw8hl2Tk9lPlsAybmptrLfOodvkQxo7RE5lQeHbqXP6j/w/m5lJt9uvG6fXQKBYvFJJeHPX4YouAOE6MbCwvpjZN5pvkzJiuPSJ1ZSG18aM7L+vlU4Z6GWboPpGOeZdev4yCD+9N/Lk87fwMj9ipPMRJkyy7gpIxQ5ViqbitBeTtxggMIUCP+VdGSArUyXyMycz1yrvJH1uF3k98vJtNxgavBadg3lBmijL1bUOZx6oR1Xs89Y47DMUvo9+INis98XILfZocLFXbXCh7v295FmKg7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YIhWJYPncYb8h4kWhPCveJpPZuHkPif4kdTPxSU2Ykg=; b=QZUyx5uiObIxM1V5G7249iHsNDqtsQYm6a5rdV8d8GVpkHVs7GVxb7+gWsKSpOLtp0NIelOGr51z0BwfMeOsvI0VrthesU1CGrtZffxTehIfIXq2w44zFpseSuPoTkdW9NRywalD6FLStgFT8fCwj0QSS2VagPs/lMKl5GUzIrdMz3aHHcUFM1EB8iak4yimRqPR6/VR7rO1siAv+5tMvEz7x9gvvisBx6W8EkAt8N2CTo3/+ki9/XqZxaB7AtYAD6mulhXvjJz5JWdqMRPlVX5u0T2ayU5wWw7k1xYO7mvz2TPrPLL6e2r8d4HB4UjxZP07x0tREaoDxlepV8zP2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YIhWJYPncYb8h4kWhPCveJpPZuHkPif4kdTPxSU2Ykg=; b=wbUyDYfI11shxrh2N9Z8wo0Vm5eMMWZMfjyHWvxBWW2yqjnkNHrPqxhyIlALufhum8/xSlxY+TM45JPKGZbv4Z5uPIl4jSjbzF69gg2nLO9fJsc+1qRLRuIQoJT+yl3xVSeFDkaJ6Bbl2phXurPlV1nSJaSrRjLwCaunVxaWM+yJJqsFU1R/IYslQyTz5VdTpcgSK/bwrPZOe9WvDUpfkvA6wWtD1MQYYSmB5vKLcr1KGhbZQAgCRr2iFGGkVRVnoC1CHzu/H96x8uQ8YvCmwlNusep7DnmlF5+DRhLPuYUydrBcAx3v0PdrlK+Jc3nSZLdGWdjOnvxLd1jJhvIl5A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2678ded5-f3d1-12de-91b4-ef2ac14cd5d9@suse.com> Date: Fri, 28 Oct 2022 09:21:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: [PATCH 1/3][4.17?] x86/pv-shim: correctly ignore empty onlining requests Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Henry Wang , George Dunlap References: <2398b0e8-ea5f-dc8e-46d8-2d3994a98b34@suse.com> In-Reply-To: <2398b0e8-ea5f-dc8e-46d8-2d3994a98b34@suse.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR04CA0037.eurprd04.prod.outlook.com (2603:10a6:20b:46a::28) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9264:EE_ X-MS-Office365-Filtering-Correlation-Id: f9cd2d88-69a6-40bc-b50e-08dab8b51675 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NMW+S6LP+vkSEiRuif0795HAyFavCXKTAcvuAViytGUm/D4uP5BhCN8e7y3/3gUv31DQniY7q6F9CCfcM/84tTulwuEQ5ThVFHykeBLbkwtqYjJu6c7qbdpFQy7uNnyHfsftezIBuPzj5qEJ/dizm0jJN6UJ3f6Ty2CBphM8MCoudg5Lq0NqP2abfd+AILV1jxfppkqY5+V1UKMeAi9FrZFIxFZd5bM4WxR4W4COvwCUTtO4DLepC7NBYjUuXlBmB08VwLSJuj14FlfczQ4arTCboZZGfyjh4QXRPsyNwtjPRuWPN3mr18d6VyFCIHNgHCcBZRG9c85m7lzouW6YSgeAdC8FWZhl3BP/gAWqgb6tPChVX5MB9J8QUnX09Jfgy3R3MApvAxPmVxHHFwyuW0UX62f7zkQLXq4o39VMt4Or9X1eyJ0ANsyNmGUtaBIZl+Vjgg8ktIgP4EvNyrPEVtoFO6oj5EmoaJAYllcNABdOEXGgEF342LLAMDYW2tUPYx9UcCQYnCDI+AVbjRWQTauTqU1OXUxiQUjxxJyy5GAWvW3GoIwcsX2eXlaOBMDhR9TpQqxeipDvjMeAPGAGnP54yvGWVKlojYr2rxBBvPihHkCaFWvrQtosU2IBih6Unut/wKYUQ9TKNoexA4+XaaeJa0gGHqktTOZ0J+d3UPiyBfTCbm5V+uKfXYluwkM/SJtvM9UwXUuOBQuNvNqiisN9ExcpMDvweCXAZbJ+v8mgJoXUIbnKbewMlRa6MiUrWSDXnsTW+DZy1I8gyyXmtqQJ501AIHuViaq9QRh9iEE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(346002)(39860400002)(376002)(396003)(451199015)(316002)(54906003)(6916009)(8936002)(5660300002)(2616005)(186003)(4326008)(4744005)(36756003)(8676002)(6506007)(66476007)(66946007)(66556008)(26005)(6512007)(41300700001)(2906002)(83380400001)(86362001)(31696002)(38100700002)(6486002)(478600001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2Z3VTVoNVRGMDRnc2YzMnBkdFdRRW5MSUJiM0pHSC9qQXhVNkNHY29YODBR?= =?utf-8?B?QVIzTDZkek9Ycms5b2FUUlA5STJ3bXZJTjc3N0s3cEtPT0FKbGFxWS9oKzhD?= =?utf-8?B?eVZ6YXcxbWNpeXB2c1ZhWHp4MjVtUHZvdFBXUHVxU1JYL2tTcDhNMFV0dW1q?= =?utf-8?B?Z3RhNHRhUjNhTGpjWTFCUGQybkRqcXVZOU1WSkdWUm1VVDIxdnJOcXpvQ01K?= =?utf-8?B?Z3BHcjA1SGg3aGJSclVNRkpacGM4TVJwN1Q5djB2OWFZMzZLRnNJWkdIaXBI?= =?utf-8?B?TkVScHNGaEhFNnhudFVGemF6RjZlR0NPNjcyU3dtYXE1cUUzNUp3MGFnR1ln?= =?utf-8?B?c0w5WXk4dkpNekxPYTJoN0ZqK3VpeFlHclRVRkQ0WnBJYTBQQXBmekhEVE9m?= =?utf-8?B?OE5GQXZLb1VKSlRraFZmUzB3RjRMbXdXUGg5Y0NNVkZoYmMzRUxFRGFXMDJK?= =?utf-8?B?MU5iUjNkRUVpZHBLcjBnV0k5TkZWWFVrSzhTTG9tY2RxSWwzc1lKcEtYUVE0?= =?utf-8?B?KzdJL3U3Q3RGbEFpYlQ1ZjJMQXo5aC9XZXZIZGtEZ1RxdVVTelZua1pkaDB6?= =?utf-8?B?VzBoYVBQUS9XdWpoMzJWajVPNjdTcGY1dEpyd0tPVzZmVkc5ejJvTW0zUWJU?= =?utf-8?B?dnRZTW1CL0RoSTJPcUlnYzE1bzBiT2tpVkZtVTNDbElTSS94TDJtVXNaeTZZ?= =?utf-8?B?Ums0YVRGUVVEeEtWcTFYb3ltbHA1aGwwUkM1QkV0N3pNZ0NWbkxQZ3VubVRS?= =?utf-8?B?dk5SamhwWEFQMDlUUk04VkJNOXlzMEsxS3ZWVkY2c2Y1OVI3TmdPZUJxSFo2?= =?utf-8?B?bllKOWExMm5UV1Bmc21SZU1oZTdTTlVMWFlLckZNL3hoTmU5aXV6bS82TmVx?= =?utf-8?B?MGxLcmV0NXNEdllUWDAycVg3czVMT1V1dmVBY2htWTE3YWw4QkM3WEhsTTlG?= =?utf-8?B?c3Rwc29PalBZU2VQZFV5UEtUMnJqQzRDbTRibDlmdTY4RFF4emtGeVhHdm5a?= =?utf-8?B?VXRvTTJpbDU5WXJ0MEZ0QVFxVXJOMFA5eTgvSTh3NlVheDJVcXF0Q1E3T0dS?= =?utf-8?B?UHgxRnB1TGdrYXgvWVoxYlF5bFNFRUNyTzcxMnlCUHVWMHo5S1hUZHJKTnpj?= =?utf-8?B?eXFGTXdYdjZKbXdxRFljajQ5UHpOQlJrWkhGVjFHTGE3Zzl3a1FPdGdmRWpP?= =?utf-8?B?ZC9mVlV2aHBBZVVYWis0eEhlMllzUEE5Y1ROOVZWOEpIZllnc0Z5Um9uNVFT?= =?utf-8?B?WU55dUNmeGQycnduTXZ1L1ZLRVlHcFZGMDlwYVZ5SWtwNXpGbE1xaHJFTFor?= =?utf-8?B?aDBWNHpPL0I3a0dWM2sxMTh3ZUg1QlFRUVZ4OU50ZnZCT2FIcmF1OVB0Q2FF?= =?utf-8?B?eUVORXBBSHlld1F2NGtrWU5jU0NSbk54NXhPWTRRUHJmdkY4NlM2cFNvL1kr?= =?utf-8?B?U29mMlUxWFJWUkFXT2duZzF6QkdySnIvblV3Tmg3V1JvbjhQcEoveW02VHQz?= =?utf-8?B?eWtkUUxITTRZRHArYlB0Sk5VakdPZyt2aGpVdjFSelRWOGtJa3NRN0R6NkM2?= =?utf-8?B?NjZvYlQzeFlRcmdpdlJnWHZxLzJ5QTZMdkl0Nm1ZcFYwU2JjUUMzbFZ4YmRW?= =?utf-8?B?NHk1ZXFmRndvVXhiNDNsUUlLWHFnNUl5RjhLdm1tTTY0dldjTTA1QkhUM2Jw?= =?utf-8?B?NWlzdDU0RWFoeWJEMGFLV3QxSWtOMHdiQWlPNFZtNTVoQnhNSjl6YmRWSEQz?= =?utf-8?B?eTJUcDNuRjlOOGl1aXlYazJEaG1UZE94dlE5Mks2RWxxTWtyRDRIWWRrRUkv?= =?utf-8?B?VUxHM2NJeWxBVmNCaVlWOVF0YkFhL2xOaEZmaGtrUUppcCtwK3FFb2EwS0tK?= =?utf-8?B?WVMxSnVGZ25FYW43NGFXa1BJZlNRMndYQ3VveDRjUU81TWJmYnQ2OTRxUS8v?= =?utf-8?B?ZnVxbWNIeW5YTU1ubDR2NlRJS1MwT0lsbFNlK0h5RkZ3UGRMNEIwY2RFRnU2?= =?utf-8?B?Z2dpYm1OYTNxQkl5REh3WVdMbnhPNWUyYVZYSDNUTWQrTllHZU5MOGtkM0h1?= =?utf-8?B?TnVuUjZ3TlJzUDRMTGJvMGw3VTFsc2N0QWhncUtqVk1Nbmc5MkdJcUxBUlF1?= =?utf-8?Q?yQTLt4DA9qTfxmWDoRDhxn1IA?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f9cd2d88-69a6-40bc-b50e-08dab8b51675 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 07:21:53.4406 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: inOAM9FkWk89zo1JOAA6NBvm8v+tLfJsrV33oAJqFnj9dcqjl+vl1YkEYDWNaOM8ZHgOAGC+1RmqZY8lVKOEww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9264 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1666941737500100001 From: Igor Druzhinin Mem-op requests may have zero extents. Such requests need treating as no-ops. pv_shim_online_memory(), however, would have tried to take 2=C2=B3= =C2=B2-1 order-sized pages from its balloon list (to then populate them), typically ending when the entire set of ballooned pages of this order was consumed. Note that pv_shim_offline_memory() does not have such an issue. Fixes: b2245acc60c3 ("xen/pvshim: memory hotplug") Signed-off-by: Igor Druzhinin Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- a/xen/arch/x86/pv/shim.c +++ b/xen/arch/x86/pv/shim.c @@ -944,6 +944,9 @@ void pv_shim_online_memory(unsigned int struct page_info *page, *tmp; PAGE_LIST_HEAD(list); =20 + if ( !nr ) + return; + spin_lock(&balloon_lock); page_list_for_each_safe ( page, tmp, &balloon ) { From nobody Fri May 17 04:49:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1666941769; cv=pass; d=zohomail.com; s=zohoarc; b=T5gd6jmIkNvW2UehtkmAAH/gt+xQdBpObMl0Aw5VSb/1ZdzpqQldaXhP6WiNhDwH/fLGAPaQIStKHCIUcWnn23rwEsjH6g+eFPxko3a0oqLb4cxLRa6V4EOiW7KL5urAQc+M64Kt8JH2Rpsor6fooAh0HbHpCengfWB0IDJxetI= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1666941769; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=z+zkDWf3de9+bRGdDawZnuvAUtR92dpvUXja9wCTUW8=; b=K717PfoZwGi4jkhXZkczDRENATPTYgigubiFmRizYR85zeRTRfYXa5ahKGKF6HAERXd8fjpPVThkpa2KBM9EWtCoE1H2V/8THZwSj8imsRJmak57vPM/zEPNEPMhGF4GXxa6cZSNIxpXcPCLbfzyxou130loVvjhOYrsA3tb59M= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1666941769203324.0262888326097; Fri, 28 Oct 2022 00:22:49 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.431436.684337 (Exim 4.92) (envelope-from ) id 1ooJhJ-0002iM-TI; Fri, 28 Oct 2022 07:22:33 +0000 Received: by outflank-mailman (output) from mailman id 431436.684337; Fri, 28 Oct 2022 07:22:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ooJhJ-0002iF-Q3; Fri, 28 Oct 2022 07:22:33 +0000 Received: by outflank-mailman (input) for mailman id 431436; Fri, 28 Oct 2022 07:22:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ooJhI-0002i0-Lh for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 07:22:32 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2089.outbound.protection.outlook.com [40.107.104.89]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4902870b-5691-11ed-91b5-6bf2151ebd3b; Fri, 28 Oct 2022 09:22:31 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9264.eurprd04.prod.outlook.com (2603:10a6:20b:4c4::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct 2022 07:22:30 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Fri, 28 Oct 2022 07:22:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4902870b-5691-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gSAw//2uDBvNDvCJ4BvfD2gDBZuxtf8ZJuYTaPp/ic7C6qCZgNlZQmcxTaKCuEvQ/1qNOnTKWarTVJ5z25G+zrhhE7TIyiL4iPrk1m66ERRhwPrHqiI5lKW0XyuknNVg4UrbUMytxUn+XWcE1Y1qX96MqK3knqSZFL3yP/2xW5MyjZ1B7qnhR+aaszO1EOGDu+qKHliq3eM/kgv1xzNqeG0jdEOWE3+dojI22tmb91vrRzh7v+5/3vzeB5/hV4awsbHFWuaz10ovgrCwXuNNkTH2WT4Moo5Me6OuAVOLHBrlvH3DNsxG+F1pkf6fFLyexlvWLXrDxLROWUc5k2Ck0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z+zkDWf3de9+bRGdDawZnuvAUtR92dpvUXja9wCTUW8=; b=Sv74S8fykyVhVcgrsoWjdX3KKe1qoEs8wwyGGZPURZVlRBeTlgjKymayqL1Ii7zNdYdOYm5Ck7Wyy02bzm7XC0v/D0kN+7y2u8uthHeytlX9eej/D/WQLlUSaiJi/UQIrTIporFS9R+GVYbhDXTrnWUIlFYZW3YQ/ch5+wU6sZjaeTstQ7y0fvvs5vPsJ5+tWYhvBdQYVpHiHmTJxF/qa8SsGtOQHKPo2ectnqn6RWZOkOYGYVYV89VHsX62qSA6MNCcxlWEhk6REvMK3cHej9R60vABkF2SpUe1A3NN18vzQuuQGQh/11k6goDbVP63eysAvbp/GSXtHpykHIVIwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z+zkDWf3de9+bRGdDawZnuvAUtR92dpvUXja9wCTUW8=; b=H3clkn4Ehg5x8XmUIcvkp4R7no48XoBv7qXbtB9g1miVWEWOb2gSgf84q6Dd5JjilQP4CUczMBnTStrLiTDdteu4ys2+YNNRsF434C9hFXCgmWk90AqGOQURmDmG/UNKhA/s3VwX3dUSCRMosDgrmI2gNsmgUSq+rfYw+VVR3AaiYrLE4hixelSxymqdXcu+1ECzst6lTz8GK6pg2gx//DTkhhqJFvfWVMhRe1r3wn2bamc1xXfnXHqX3NKkgVzX0PbSd7fI+7se3bEaBO4c3EqBeoNkDw3b38fZ6jjIcEGraw6TlMy3kTBPL8NX4pNkzgzfjI06El2QccsB93/U6w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <07ecca86-97e3-555b-78fa-d9cda765805d@suse.com> Date: Fri, 28 Oct 2022 09:22:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: [PATCH 2/3][4.17?] x86/pv-shim: correct ballooning up for compat guests Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Henry Wang , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu References: <2398b0e8-ea5f-dc8e-46d8-2d3994a98b34@suse.com> In-Reply-To: <2398b0e8-ea5f-dc8e-46d8-2d3994a98b34@suse.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR04CA0048.eurprd04.prod.outlook.com (2603:10a6:20b:46a::27) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9264:EE_ X-MS-Office365-Filtering-Correlation-Id: 8a3dcbc5-1abf-4607-b990-08dab8b52c61 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a/KueU2czSe9Ewp7R27kEH0LqYxxXuKwcub+w+dTvp8tImgbGyqCFLvPLOFCKK1X/4mL73DRBSpOB2qr92TxFxrlCSjiRquzzG9RoX8nrjfRFl/3S9qKHkovKQIAH/2l6Rhaq1Sy4/TI+x3pc47V4cgN3rL8PJL9YAbImiTaUhN6BVFw+hwOSbiJ7CxSOPzCh483aOgnr125O8hjJoKs6Rl975sLRiE3u4U7VkLr3Ej4pQiDAoXGV/Ho+usMTsEo+J1HBo3GxjEzI7nxdY2ZYvjYTPOoWbgxi0Txl16TIxujYaZWt/wXK3eteqppBuR9Cohh0kFq5xf8LPlz6/GeS0pqGI8+np6XOq/Zd/pb3xqxnOdgjIgRS9Qc+rzVVvdTFvbz3qHWQXxt85X7uqcRzJXmVk+0DB5yt3T/doeBe92ZP09peGz+ctvd280pgroXIRmi5v4ErPuqchIyQnKSakGHTWj9RjNhieI/CzRmtwwxkTIL2lSVIXtErHnGXvcNbxVOLw/uUkbMhqzQrmheShwIFW7zBVH4OVbwfbJbKvRRGXktsL5dCerI834YobsdTDpt1uQuGtLdddHnpWE2bcUn0HGx70IWFcYRObYPauHXW+n+E+cVBwqA1tWlvNFT4hAFhZsdOeXc6wgHufZ84V/X6W0ozBcFcapZzOEN1gqXyVOD0g7Xc9EzPbDcHq4wLpX8an50+l4SxB1giHIlorAELbb3d+1W55pxAXgnLFrKHlmMdw8uJ2Yg+VkJeMQcKBY0Dep8v7VeMa8P40TjiKO10+dNaUmw9qtuw/pfqLI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(346002)(39860400002)(376002)(396003)(451199015)(316002)(54906003)(6916009)(8936002)(5660300002)(2616005)(186003)(4326008)(36756003)(8676002)(6506007)(66476007)(66946007)(66556008)(26005)(6512007)(41300700001)(2906002)(83380400001)(86362001)(31696002)(38100700002)(6486002)(478600001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1NzU3hGYXlrZnNwOURrWmFZQUNlQXk5S0Vlb3V6RlJKdGNaenBTMTRwRHpZ?= =?utf-8?B?azZRN3FvendVU1VVNUVUTXRSeWZmUG9SWW8rNG5kZFNnUWNEZWFFSWNoelNZ?= =?utf-8?B?TVd5enBQMHhpa292Ni9nZUxHaXFVcW9OZWs4ZXlDSk11RHVkbWFEK3hsWWJq?= =?utf-8?B?cWcxb0d0TE8vNkNPT1Fqc29ON1I4bXErMGhGU010TWNDeG9PSlJaaWhHcmJX?= =?utf-8?B?Qm5GenkrUlhNZUdUZFpBNG9JMW5UMHp1QTdoU1lqZk16Z2pWaUdsdDhNVmQz?= =?utf-8?B?WGxoSXpESVFqMFdoaE5zSGlWUEg4YXBBN0NvWERsSDc3SzVkZElmbE9kbTEz?= =?utf-8?B?WVFnVm0yMFBoY0dsd0JQUC9sSUp1UFJ4ME1ZdGMyQVJkMUxKdXpKS2hKZ3RI?= =?utf-8?B?THAvU2NCRDBLeFAxOURuZ0ZWN3RMc2JpOGRvbVV3b1Fyd3ZMZTlDZ0Y3N3dn?= =?utf-8?B?TlV1TDIwSndMeWhkblorWXEyNEtCbGtVempZZytmcEhBaEIwQk1Zayt1Sko3?= =?utf-8?B?eTBvUFVRRzVkelpocGsvMk9YdDJkRFJqZlZEeUZhbWFuMmkxNHdReGhaOHFl?= =?utf-8?B?SzRyTlhRSUkwYWo1MWZ4QUZjVUNHUFhOeHJ5eXN3SW0rczhGbWJtS2hBbytW?= =?utf-8?B?b3VXS2U5RzU4TmtDbHQzMlA5dFBydGNaV29MK0w3d2gyc05kWFpkS0lMdnVF?= =?utf-8?B?Z2NjdWU5UWhwRm5YZlJ3NGpXb0s3UXUza2FhYVNOeFk1N3FhdzYzUHhQMW5x?= =?utf-8?B?YkgzN2liMytHQVd4dVh5cnZXNnpRZmVoWWwrbEkzMWpMNDdLOVBxeWovWlYy?= =?utf-8?B?KzJBSW9LRW5Pc1gwSDhnakhzVHRKR2l1WkVvMDErZFc4WFRuWHZaMThySlNZ?= =?utf-8?B?U1NLTWdtZFZkK0JuVExjbDE2dVRseDI0TjFLekU1Wlo5Tk1oa3ppTWl1ZTRI?= =?utf-8?B?SS9vcHFJejU2NDR5OWRsN1ljN2VWK2ZwYlZ3OVhPWGZ6QjJnRU5Zblpvbk1R?= =?utf-8?B?eXpNVWMxb1J0VnluVXNpa2RpNjNnbURmaVJnYmJtYWNyQWFEZXJqd05nbzZX?= =?utf-8?B?aUhTWWFuVVJXZThDL2dYSEcxSHUzb1E4WldRcUpIQzNuVEQ5Nnh6ZzJaNTBS?= =?utf-8?B?d3FjWkxNVU4vUWhZcWZBcGkwdm94NndVd2NiaGF4SzhmemU1dC9ITFdFK1Bs?= =?utf-8?B?TW1ZWmFoQVFGTE11a21wdWthdmE3RnNRdEhaRkdhMml6TE9ER3RDRjBlVi9T?= =?utf-8?B?Vng5VXlGY1pzVUdYR1hVSkhGSEhpTk1talFENCtSZlBMajh1NlQ2ajBOa21w?= =?utf-8?B?ZXNOODdramd4Ynh2S1FabEhiTDd6VkErSitOa3NtL1NNSjNPMi9ySkxmeEp6?= =?utf-8?B?NzBIQmcxQ3JOamVhWTFtTTY3S0FTSWp4cmNBclFoN2NoaXpaNU5pWjMyQngx?= =?utf-8?B?eDRPZGVwdzg0djdSSGFhYnlTTnpFM0Jnc1FsTEV0UzN2L3Jjall3UHBndVFq?= =?utf-8?B?bHVxZDBsMGJIZDJ2ZEhCTXd1LzJaVnBhamlDMnlSdmdHMS9RMy9KY3FZMHN3?= =?utf-8?B?MkZleWpnc0dOMkNmSWpzaUU1VGlqQ2lPbjhsdXBrc1pwRGluTVB2ZDYzRVJa?= =?utf-8?B?a2d4dyt2N3lWeGE1REVvNG9LRjhPTmdDeUlDZlFBemF6MzVUL3RxSVFLS2dI?= =?utf-8?B?c05CSHIyMEhPVFhDMkVockZnczN1cnIrcXU0NDdudFVRNHVZM1BQT2NKNnda?= =?utf-8?B?U1dZRyt4cmJnaWlTYmFEQ0tocWNUNi9MUmZ4Mmd0emVYWmRLQ3RhOGJvVjJ5?= =?utf-8?B?T0YxWWJFUFpKU1p5YmRldzJhbjNyODQyWWgzMng0Q3N4SzQrR1oxaUdGNXFC?= =?utf-8?B?SzlkT1FUN1JtdjZHbzF0cWE0RE5seTAwQUtuL0tERFg2dmRhUU82RkxZNnRO?= =?utf-8?B?QmlkOVYrUEdyWVBaS2t1TWRwd012RVdiOE9sRElKaE8xWm1XSk8yU0xHUTdj?= =?utf-8?B?aUI1RHlWK2lNeXRuM2o0Uy9temZmd2JmeFJCa2xJQ1pBNG5jSDZmNGRFZlFH?= =?utf-8?B?MWZLMUJlWTRrV0JNNFljbXVIQmRkbWp0cEloN3VSV3ZRK1crQVlWcGMveG5q?= =?utf-8?Q?EegZWPXcizJIBd47nuHbfGAWg?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a3dcbc5-1abf-4607-b990-08dab8b52c61 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 07:22:30.0789 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1837UEFakiNuzQJsfLSQ4m+V+KTvb9jC3T0Kw8wrTHbJ2UndCmOsZj/NfdUJW4WgmDFqw2AXJaKYAeeQqriFbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9264 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1666941770152100001 Content-Type: text/plain; charset="utf-8" From: Igor Druzhinin The compat layer for multi-extent memory ops may need to split incoming requests. Since the guest handles in the interface structures may not be altered, it does so by leveraging do_memory_op()'s continuation handling: It hands on non-initial requests with a non-zero start extent, with the (native) handle suitably adjusted down. As a result do_memory_op() sees only the first of potentially several requests with start extent being zero. It's only that case when the function would issue a call to pv_shim_online_memory(), yet the range then covers only the first sub-range that results from the split. Address that breakage by making a complementary call to pv_shim_online_memory() in compat layer. Fixes: b2245acc60c3 ("xen/pvshim: memory hotplug") Signed-off-by: Igor Druzhinin Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- a/xen/common/compat/memory.c +++ b/xen/common/compat/memory.c @@ -7,6 +7,7 @@ EMIT_FILE; #include #include #include +#include #include =20 #define xen_domid_t domid_t @@ -146,7 +147,10 @@ int compat_memory_op(unsigned int cmd, X nat.rsrv->nr_extents =3D end_extent; ++split; } - + /* Avoid calling pv_shim_online_memory() when in a continuation= . */ + if ( pv_shim && op !=3D XENMEM_decrease_reservation && !start_e= xtent ) + pv_shim_online_memory(cmp.rsrv.nr_extents - nat.rsrv->nr_ex= tents, + cmp.rsrv.extent_order); break; =20 case XENMEM_exchange: From nobody Fri May 17 04:49:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=2; a=rsa-sha256; t=1666941813; cv=pass; d=zohomail.com; s=zohoarc; b=cjZoHWgFoMaS7aSfvnYYA/KW2BUiVghKThXhDW9gimbeiAc65c+aKembRoAC765LyM/2yEcTfiyfNKvnelSH14kPSlJFfhf2tAsPjxzL0BFK8kHgNskUaxo4nZIhn9kyWzMiqu9lXx5iilmBCX9OuIx5LmlejqLYyU3W0pBgVHk= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1666941813; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=B4EnGeRwXar3+da6jwqvXI51YktxFxeKbOMUsdd7OF8=; b=FHW8z/W8CB1AgOYIqD3YK/ewFRWIWwgbTXyplYaiqf+qKivS/vIO++xQowRDT9iDdj18f6BRTHy9sfwAy6zlQAz9LZm9MgUiqQVL0iM7WorFXvuj9PKf3/SvgxjQAEhdWf1XH5hYKDUNySESU5ozqsrse69dDOmI2XoFVkJEFiw= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=suse.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1666941813493809.6281050681805; Fri, 28 Oct 2022 00:23:33 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.431441.684348 (Exim 4.92) (envelope-from ) id 1ooJi1-0003I7-75; Fri, 28 Oct 2022 07:23:17 +0000 Received: by outflank-mailman (output) from mailman id 431441.684348; Fri, 28 Oct 2022 07:23:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ooJi1-0003Hy-4M; Fri, 28 Oct 2022 07:23:17 +0000 Received: by outflank-mailman (input) for mailman id 431441; Fri, 28 Oct 2022 07:23:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ooJi0-0003Hp-ED for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 07:23:16 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2066.outbound.protection.outlook.com [40.107.104.66]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 62d9dbd7-5691-11ed-8fd0-01056ac49cbb; Fri, 28 Oct 2022 09:23:15 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9264.eurprd04.prod.outlook.com (2603:10a6:20b:4c4::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct 2022 07:23:13 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Fri, 28 Oct 2022 07:23:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62d9dbd7-5691-11ed-8fd0-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RP0MM2Dbw+SIT8P/cq1IuvqZl0F4NCrnhjtHjOh0zPefiNKUPTiJ5IFHu2DDWekt2YvMDR6JXWtdRRUs3+cgzs/QK/Z08PWOugRodB6b153wg49cSno+DspqJEBmJl7cGlSUO8YquzU1eJJzKvHXWTCbX2lLwwrb1RbQYoLD62q7UZq4LqyJCDj0f2ioRIOl1dus+5JsJ5LYPDdbbNT+1Nxa29yfaEW0m8mdFzx3H7xfM5N+fbWl/e/B4M4suBiHddQsR565JBUUVY3xbS57pwwswRTrOC1boVIQmTvP/fuiPXJnAX7XWyEjaLG9aX6dvpnAb/MNoRgUDqQycf9toQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B4EnGeRwXar3+da6jwqvXI51YktxFxeKbOMUsdd7OF8=; b=n3ui2QSscLcNXWx53MsSA1MFmdJ0XphkFKK6l0i5EEpO1GS2BX4BxK/LDXLCu9duLoQ7/p/NitDlRJeiPpfL3/OjGGmji+QIydr3GBScSveFlKH98TZbEDHCBlgpJkjWHFGkoXm6r+Xn+mE7slHodEaNmh2nsGLNmASjjWyfmZxosdUvpVD74BUYncfDZmDGv6jMag6WieFWxhfaQ6yZnGbTPRjtqCGVUsHV1qmSVVN+hGy7C+PO6v9iKtJfZOXkArzzab/9j7mAwgTF2+YJXWV+G9xJ9WOgPE6g2ZxTschkN21MZRis2qCwAVmqQpVWy4auvAmEySq4oZt4wDymwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B4EnGeRwXar3+da6jwqvXI51YktxFxeKbOMUsdd7OF8=; b=CMf+uJBsEN0kWZASqJEnO7IYLhFosBujId9SraPi/42LRzZSbpdYm+E9UkurKX/K1M9Fu5mySFUtfPGrSMVehA0UI7rLQ9BVOFL5DGooI9XFIZyivjiqrF6SN8kffpiZ4Ffb9gecRCvbZ436ldqe7zdkpn3szOqm5PNf/1k36kZkOoDetUuWItuRc5j7zKk1d/tBaoz+71y23eznh0XBYEHAWILYIGKSzm5PxQnAT78WH0UqdVdYYRxlDuuGGsQ93VL4dNtxW5mI1DcLIIt5t8UNxe1L45hEVp/jHW89lCIz5b4AR7e1tSyBURMJHetNqlTT/8TtrO7bGDEx3C0N9Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 28 Oct 2022 09:23:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: [PATCH 3/3][4.17?] x86/pv-shim: correct ballooning down for compat guests Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Henry Wang , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu References: <2398b0e8-ea5f-dc8e-46d8-2d3994a98b34@suse.com> In-Reply-To: <2398b0e8-ea5f-dc8e-46d8-2d3994a98b34@suse.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS8PR04CA0015.eurprd04.prod.outlook.com (2603:10a6:20b:310::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9264:EE_ X-MS-Office365-Filtering-Correlation-Id: 401ac5b1-ad37-4fd6-5975-08dab8b54626 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MaKF6QKUQhTwCvkvqieXw77wWm1OI3YsgaHzzaH/MIhe9w0WrWinAM1GonlRIOV5or70tF+L2cEAWDcmc0H3f9sD4h/MG1MLF40Hj5hf+EsKY53DuQL1pXR/akaWD+O9fdkYTZZhIerdFHEGPZyyIizsfhXegCdnrkDUbvDOwonrZQrZ7ZbCQ2rRY8Mlttxktulx6kD8b6ZlUYoevDBJrUqy2ZxNQbHbBZ2QvQO8xag4AcLbvXZMc0u7mzobY1dr5cAyi58yVA6ruUN5JAyAqxKN8edJR+ZKtpsYyy2wFfYv+TOn/G4F7nFdY78tcIM7QmHkN9vZunNYJ3nB/vF/hf0vlktK00I5O54buj4yODDMpygPuv3+N07Q6t79zeEvF63Q592ivFKfq0JYXz4NkJY84LHN8XptJVr9MuEalQJ0FM/PmfOlenuer1aAMgpeJ3goyVbibbTY6lTo4lKPyzY+g6FRez1ZwBzD1nfeLZSWvGN/Ecv8u/wVWVR+yFJ305EeZ2E51czqOO80neMjmnHSVMnQleD+fyg5jmi6UMqSAn8zLBs9+9TMij5TlGOGVna1G+eWCQ1D1WmxQZ+IrjhUXa+q/nISKROQNH0anmmMYgidZCbImQT/wZaje8A7xzuHKZJjvc7YSc3DgNesXfkT/1JPqGDwX3aWu9BR3Jt4UCPpVFGNLvs54ADESemmANC+e+vXxeQ/kjR75NQmqGtVCYJZW5bGhuqqTa9ZAhF0WOmbvn5P77VldaPdqfNJzPB2ZR7ScmTFyDZYftL4+yCifXtXggLKoGgAvLsMcz0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(346002)(39860400002)(376002)(396003)(451199015)(316002)(54906003)(6916009)(8936002)(5660300002)(2616005)(186003)(4326008)(36756003)(8676002)(6506007)(66476007)(66946007)(66556008)(26005)(6512007)(41300700001)(2906002)(83380400001)(86362001)(31696002)(38100700002)(6486002)(478600001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cm1LNXNNS1U0aFg4dGpIZGVtVGp3WVkxS3R6WnJEQklzNmJCZHNacnJKSXRX?= =?utf-8?B?enRVWStDMGY0R0RQekR5RkJTcjZteGFDNHVwYmN1aFFxY2F2aDRvME9qYmIz?= =?utf-8?B?ajUzbWtyK1VERmZ1d082Q2RVSTRQOFBVeFNpMzdHTnNROWNkdHI4cWtmZG9O?= =?utf-8?B?L3RsTFhBcHJ6cUFTZmltU3Y4djc0SldWMjJkcmx5RWpPM3M2VUZ0QWVMUHlv?= =?utf-8?B?a0pNWnFmQnZsanpGUC85YW9PRlNubGlTZ0o4a0hHaW9LR2VWNnhkV0NTL1l5?= =?utf-8?B?bklpTGpMclF6K0NHVVZSTDBZL1FIYWxaVkZZUkVGdGpBREdhVTRxQTBMUFZQ?= =?utf-8?B?eEM3a2RCNXNVaVNmTkV6TFBXNHNMaXJzU0lOQWpDd25UTU1CME5KekdqL3lu?= =?utf-8?B?YUNrMVEyb0I0T3MwTE90anVZRDhKY0REUCt2Q3NBcTVhN056dmpzc3pmbkc4?= =?utf-8?B?czBNTTB2amVGL1F1VGxVWEhheDRRNFZncERKaHZac0t1UzIwMWxKYVZUR1VL?= =?utf-8?B?emh6cG01KzZXMUNUV3htc1BWdjlMZ0ZhVW9FVm5oYUxTQXZvTFAyb2NsQWM0?= =?utf-8?B?RzhteUs0NG54dHR4SUdMY3VrZEN6STN2bkV3WisxQ0NKcHhKcjcrR2I2OHRX?= =?utf-8?B?a2p1ejdOT1A5Z0R6RWVxS05QRHB6T3VUTmdnSmFVZ1BTTFBTaDMvSXVKNnZT?= =?utf-8?B?NzFJMS9TUTdJTi9tQ3g4V3JhaC9CT3JxOGY5bkhjWWVTb1J2bnluT3BrbHFM?= =?utf-8?B?UzBnYzAwZmxwWEoxUDIxd085Ly9rczJkT3hzT1NXL1BNVGcyd2NmQnlsSEhO?= =?utf-8?B?ZUlEalFDSVZ4UWJuS3ByY09KMTdrRExQK0xGZVV1TklOejkrQk8waXY5azBI?= =?utf-8?B?SnZCSXdzdkdma2crZmZIZHpHN09WQUJDalgxSUJwYXlHWnUxWThaYXhRYTdF?= =?utf-8?B?SWtzSEJPUzhtYy92NFdNNHVBRndvRWQwZC9WbEhET2ZWdjJFbU9LQ25MRWZU?= =?utf-8?B?Lzk1dmtIdmxWWUsyTHZYK2l0RXkwbEdmMkZxZ0U0aFBFT2dyd3B6WWEvdTQ0?= =?utf-8?B?NHZvS0RrU0VvZExwNkdUdEJSUXpsZWNrUmdOOGFNMVBCUDl4dHorUUs1Rmp6?= =?utf-8?B?M1ZvQmJCaUpXMXdNczVJdUJVU0tCM3h4YVBUWEM5YWNlek5OTW1GUDc5Rm11?= =?utf-8?B?bmZFd0lCUjRyVWRuR0hEbko1VHZTOXBLcUppRVhLRmJqR2VTZzJ2emZmR1pS?= =?utf-8?B?MzF3RVc3aDFSd3BhU1RwcE1hR2s5c3MxMVpHajY0dUx1TWsrdlMzSzBmMksw?= =?utf-8?B?TlNiUkJicEhpNDh4SGhHNEhkWGg5UmFadTdzOVIvOU5KK2dJaUZRRmRlWTY1?= =?utf-8?B?a0kwd1lLanpDUFVvY3Q1N0Rhai9Pak1OakIxbjQ0bHBpMW1OUzhsUE1NT1Vi?= =?utf-8?B?Z0xUM0xnWG53dDNQek5ZRFhxcHdla2lBYzFOWlcxTmtVWnY3VnVyWE9LOXZ2?= =?utf-8?B?VGw1a0FwUkVyODZGTTNrRDNVVk5IRzNyNnE1VVdzV0svRFdjZW1NSXFoUjNX?= =?utf-8?B?SUpsS0lhZGlOZmxOZStWMGs1cm5vcmpmOXFBN3VidkNKRjFMcnE5ZFN6Ykxh?= =?utf-8?B?cFVVakRxOGJnci9lOWIwb2ZEN3E1WjFOZyt5V0sydGFRdXB0WkgxaGtObUpK?= =?utf-8?B?Mll2dW1hQ0ZXVm5BQnNHUjhGdUtLRjI2TkVEeTl0V3hlR2N2c1E5UXVwcjFr?= =?utf-8?B?OUhaQ3F4TUJSbjlNWUZDTkZIbkllT0tsbm9BbkV5QlBlM1Q0aURRSERyRVgy?= =?utf-8?B?eTJGNlcwV3F6VmVEbDFBNkZsNWYvYTNhb3lzMUtsT3h0L1Z1OXkyWkZ5Mjdw?= =?utf-8?B?VWdieVllVHlrTzVxRXF5UEtOK04yc0k0emcvWkl0MG1RVmxNYk9PV1Iwcmg2?= =?utf-8?B?TFM0VmdwdDZNR1ByakNoOXZuOEJZNW1UNlpiZExxRGFtcmFCL2NqUVhSdjJT?= =?utf-8?B?ekhPU3J2UXY4QUZqNm85d0Y0QUwxTUFIU2NKSFZwQlJ4SmVBd1JDbDJxMEFN?= =?utf-8?B?eTgrc2RsZW00S0x3Q001QVhNdFpCV0oyLzJyMGlWZ2IzWkdkZHNvU1FGWXMv?= =?utf-8?Q?qPS/i+GMrZXg+HbUvTPPLS880?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 401ac5b1-ad37-4fd6-5975-08dab8b54626 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 07:23:13.2949 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: d2W5LiGUCBqks8d5844u/qQQNP+huyopMCOjkYs+eBRnVoBoZzOHTnz9bdrMjyu+E6fHKEpAfoGpn3HiaRIjfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9264 X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1666941814205100001 Content-Type: text/plain; charset="utf-8" From: Igor Druzhinin The compat layer for multi-extent memory ops may need to split incoming requests. Since the guest handles in the interface structures may not be altered, it does so by leveraging do_memory_op()'s continuation handling: It hands on non-initial requests with a non-zero start extent, with the (native) handle suitably adjusted down. As a result do_memory_op() sees only the first of potentially several requests with start extent being zero. In order to be usable as overall result, the function accumulates args.nr_done, i.e. it initialized the field with the start extent. Therefore non-initial requests resulting from the split would pass too large a number into pv_shim_offline_memory(). Address that breakage by always calling pv_shim_offline_memory() regardless of current hypercall preemption status, with a suitably adjusted first argument. Note that this is correct also for the native guest case: We now simply "commit" what was completed right away, rather than at the end of a series of preemption/re-start cycles. In fact this improves overall preemption behavior: There's no longer a potentially big chunk of work done non-preemptively at the end of the last "iteration". Fixes: b2245acc60c3 ("xen/pvshim: memory hotplug") Signed-off-by: Igor Druzhinin Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -1461,22 +1461,17 @@ long do_memory_op(unsigned long cmd, XEN =20 rc =3D args.nr_done; =20 - if ( args.preempted ) - return hypercall_create_continuation( - __HYPERVISOR_memory_op, "lh", - op | (rc << MEMOP_EXTENT_SHIFT), arg); - #ifdef CONFIG_X86 if ( pv_shim && op =3D=3D XENMEM_decrease_reservation ) - /* - * Only call pv_shim_offline_memory when the hypercall has - * finished. Note that nr_done is used to cope in case the - * hypercall has failed and only part of the extents where - * processed. - */ - pv_shim_offline_memory(args.nr_done, args.extent_order); + pv_shim_offline_memory(args.nr_done - start_extent, + args.extent_order); #endif =20 + if ( args.preempted ) + return hypercall_create_continuation( + __HYPERVISOR_memory_op, "lh", + op | (rc << MEMOP_EXTENT_SHIFT), arg); + break; =20 case XENMEM_exchange: