xen: constify xsd_errors array

[PATCH] xen: constify xsd_errors array

Len Bao posted 1 patch 6 hours ago

Download mbox

Failed in applying to current master (apply log)

There is a newer version of this series

include/xen/interface/io/xs_wire.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] xen: constify xsd_errors array

Posted by Len Bao 6 hours ago

The 'xsd_errors' array is initialized in the declaration and never
changed. So, constify it to reduce the attack surface.

At the same time, use the preferred '__maybe_unused' form over the
'__attribute__((unused))' form.

Signed-off-by: Len Bao <len.bao@gmx.us>
---
 include/xen/interface/io/xs_wire.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/xen/interface/io/xs_wire.h b/include/xen/interface/io/xs_wire.h
index b62365478..29d0394b8 100644
--- a/include/xen/interface/io/xs_wire.h
+++ b/include/xen/interface/io/xs_wire.h
@@ -51,7 +51,7 @@ struct xsd_errors
     const char *errstring;
 };
 #define XSD_ERROR(x) { x, #x }
-static struct xsd_errors xsd_errors[] __attribute__((unused)) = {
+static const struct xsd_errors xsd_errors[] __maybe_unused = {
     XSD_ERROR(EINVAL),
     XSD_ERROR(EACCES),
     XSD_ERROR(EEXIST),
-- 
2.43.0

Re: [PATCH] xen: constify xsd_errors array

Posted by Juergen Gross 4 hours ago

On 23.05.26 16:08, Len Bao wrote:
> The 'xsd_errors' array is initialized in the declaration and never
> changed. So, constify it to reduce the attack surface.
> 
> At the same time, use the preferred '__maybe_unused' form over the
> '__attribute__((unused))' form.
> 
> Signed-off-by: Len Bao <len.bao@gmx.us>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen