[v2] tools/xenstored: remove unneeded check in create_node()

[PATCH v2] tools/xenstored: remove unneeded check in create_node()

Juergen Gross posted 1 patch 1 month, 1 week ago

Diff against v1
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20260421071510.222547-1-jgross@suse.com

tools/xenstored/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH v2] tools/xenstored: remove unneeded check in create_node()

Posted by Juergen Gross 1 month, 1 week ago

create_node() is called only for issued xenstore commands. This means
that the "conn" parameter is never NULL.

Remove checking whether "conn" is not NULL.

Coverity ID: 1690859
Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- added Coverity ID (Jan Beulich)
---
 tools/xenstored/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/xenstored/core.c b/tools/xenstored/core.c
index 4786a2a82e..34cb266e8a 100644
--- a/tools/xenstored/core.c
+++ b/tools/xenstored/core.c
@@ -1524,7 +1524,7 @@ static struct node *create_node(struct connection *conn, const void *ctx,
 	if (!node)
 		return NULL;
 
-	if (conn && conn->transaction)
+	if (conn->transaction)
 		ta_node_created(conn->transaction);
 
 	node->data = data;
-- 
2.53.0

Re: [PATCH v2] tools/xenstored: remove unneeded check in create_node()

Posted by Jason Andryuk 1 month, 1 week ago

On 2026-04-21 03:15, Juergen Gross wrote:
> create_node() is called only for issued xenstore commands. This means
> that the "conn" parameter is never NULL.
> 
> Remove checking whether "conn" is not NULL.
> 
> Coverity ID: 1690859
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Jason Andryuk <jason.andryuk@amd.com>